cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bugfix. sometimes native copy to loose rows

Browse Source
This commit is contained in:
anton 2013-01-18 22:11:16 +02:00 committed by bmc
parent 583d059947
commit 88d684f925
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/copystream.js
View File

@ -114,7 +114,7 @@ CopyToStream.prototype._outputDataChunk = function () {
}
if (this.buffer.length) {
if (this._encoding) {
this.emit('data', this.buffer.toString(encoding));
this.emit('data', this.buffer.toString(this._encoding));
} else {
this.emit('data', this.buffer);
}

2
src/binding.cc
View File

@ -487,7 +487,7 @@ protected:
copied = PQgetCopyData(connection_, &buffer, 1);
while (copied > 0) {
chunk = Buffer::New(buffer, copied);
Handle<Value> node_chunk = chunk->handle_;
Local<Value> node_chunk = Local<Value>::New(chunk->handle_);
Emit("copyData", &node_chunk);
PQfreemem(buffer);
copied = PQgetCopyData(connection_, &buffer, 1);

6
test/native/copyto-largedata-tests.js
View File

@ -9,15 +9,15 @@ test("COPY TO large amount of data from postgres", function () {
var con = new Client(helper.config),
rowCount = 100000,
stdoutStream = con.copyTo('COPY (select generate_series(1, ' + rowCount + ')) TO STDOUT');
con.connect();
stdoutStream.on('data', function () {
rowCount --;
rowCount--;
});
stdoutStream.on('end', function () {
assert.equal(rowCount, 1, "copy to should load exactly requested number of rows" + rowCount);
assert.equal(rowCount, 0, "copy to should load exactly requested number of rows");
con.query("SELECT 1", assert.calls(function (error, result) {
assert.ok(!error && result, "loading large amount of data by copy to should not break connection");
con.end();
}));
});
con.connect();
});