From f4d50bad42caebfe09815f9dc35f5d1f3b8d9f0b Mon Sep 17 00:00:00 2001 From: Jarrod Overson Date: Wed, 29 Jan 2014 08:33:47 -0800 Subject: [PATCH] removed more unnecessary code in reporter --- tasks/jasmine/reporters/PhantomReporter.js | 62 +++++++--------------- 1 file changed, 18 insertions(+), 44 deletions(-) diff --git a/tasks/jasmine/reporters/PhantomReporter.js b/tasks/jasmine/reporters/PhantomReporter.js index 898fc03..9bdf4dc 100644 --- a/tasks/jasmine/reporters/PhantomReporter.js +++ b/tasks/jasmine/reporters/PhantomReporter.js @@ -45,32 +45,6 @@ phantom.sendMessage = function() { phantom.sendMessage('jasmine.suiteStarted', suiteMetadata); }; - PhantomReporter.prototype.suites = function() { - return this.suites_; - }; - - PhantomReporter.prototype.summarize_ = function(suiteOrSpec) { - var isSuite = suiteOrSpec instanceof jasmine.Suite; - var summary = { - id: suiteOrSpec.id, - name: suiteOrSpec.description, - type: isSuite ? 'suite' : 'spec', - children: [] - }; - - if (isSuite) { - var children = suiteOrSpec.children(); - for (var i = 0; i < children.length; i++) { - summary.children.push(this.summarize_(children[i])); - } - } - return summary; - }; - - PhantomReporter.prototype.results = function() { - return this.results_; - }; - PhantomReporter.prototype.jasmineDone = function() { this.finished = true; phantom.sendMessage('jasmine.jasmineDone'); @@ -82,6 +56,24 @@ phantom.sendMessage = function() { phantom.sendMessage('jasmine.suiteDone', suiteMetadata); }; + PhantomReporter.prototype.specDone = function(specMetadata) { + specMetadata.duration = (new Date()).getTime() - specMetadata.startTime; + this.results_[specMetadata.id] = specMetadata; + + // Quick hack to alleviate cyclical object breaking JSONification. + for (var ii = 0; ii < specMetadata.failedExpectations.length; ii++) { + var item = specMetadata.failedExpectations[ii]; + if (item.expected) { + item.expected = stringify(item.expected); + } + if (item.actual) { + item.actual = stringify(item.actual); + } + } + + phantom.sendMessage( 'jasmine.specDone', specMetadata); + }; + function stringify(obj) { if (typeof obj !== 'object') return obj; @@ -119,23 +111,5 @@ phantom.sendMessage = function() { return string; } - PhantomReporter.prototype.specDone = function(specMetadata) { - specMetadata.duration = (new Date()).getTime() - specMetadata.startTime; - this.results_[specMetadata.id] = specMetadata; - - // Quick hack to alleviate cyclical object breaking JSONification. - for (var ii = 0; ii < specMetadata.failedExpectations.length; ii++) { - var item = specMetadata.failedExpectations[ii]; - if (item.expected) { - item.expected = stringify(item.expected); - } - if (item.actual) { - item.actual = stringify(item.actual); - } - } - - phantom.sendMessage( 'jasmine.specDone', specMetadata); - }; - jasmine.getEnv().addReporter( new PhantomReporter() ); }());