Merge pull request #33 from CartoDB/SMOKES-reference-errors

Smokes reference errors

dist/carto.uncompressed.js

@@ -1779,11 +1779,12 @@ CartoCSS.prototype = {
       for(var i = 0; i < defs.length; ++i) {
         var def = defs[i];
 
+        if (this.options.strict) {
           def.toXML(parse_env, {});
-
-        if (this.options.strict && parse_env.errors.message) {
+          if (parse_env.errors.message) {
             throw new Error(parse_env.errors.message);
           }
+        }
 
         var k = defKey(def);
         var layer = layers[k];

lib/carto/renderer_js.js

@@ -239,11 +239,12 @@ CartoCSS.prototype = {
       for(var i = 0; i < defs.length; ++i) {
         var def = defs[i];
 
+        if (this.options.strict) {
           def.toXML(parse_env, {});
-
-        if (this.options.strict && parse_env.errors.message) {
+          if (parse_env.errors.message) {
             throw new Error(parse_env.errors.message);
           }
+        }
 
         var k = defKey(def);
         var layer = layers[k];

test/editor/editor.test.js

@@ -0,0 +1,8 @@
+var ref = require('./reference.json');
+var carto = require('../../lib/carto/index.js');
+
+
+var ccss = new carto.RendererJS({
+    reference: ref,
+    strict: true
+}).render("#layer { polygon-fill: #abcdef; }");

test/rendering_js-strict.test.js

@@ -124,9 +124,6 @@ describe('RendererJS Strict Mode', function() {
   function rendererStrictModeOffTest(RendererJS) {
     return function () {
       var shader = RendererJS.render(style);
-      assert.ok(shader.parse_env);
-      assert.ok(shader.parse_env.errors);
-      assert.ok(shader.parse_env.errors.message.match(expectedErrorMessageRegex));
 
       assert.ok(shader.layers);
       assert.equal(shader.layers.length, 2);