From 6b51cd370bfd22e3555f6067a570f435da300b73 Mon Sep 17 00:00:00 2001
From: Yohan Boniface <yb@enix.org>
Date: Sat, 21 Sep 2013 17:05:10 +0200
Subject: [PATCH] Fix empty name value resulting in non closed tag

---
 lib/carto/tree/definition.js      | 2 +-
 test/rendering-mss/empty_name.mss | 6 ++++++
 test/rendering-mss/empty_name.xml | 5 +++++
 3 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 test/rendering-mss/empty_name.mss
 create mode 100644 test/rendering-mss/empty_name.xml

diff --git a/lib/carto/tree/definition.js b/lib/carto/tree/definition.js
index bc79449..c475273 100644
--- a/lib/carto/tree/definition.js
+++ b/lib/carto/tree/definition.js
@@ -139,7 +139,7 @@ tree.Definition.prototype.symbolizersToXML = function(env, symbolizers, zoom) {
         }
         if (selfclosing) {
             xml += '/>\n';
-        } else if (tagcontent) {
+        } else if (typeof tagcontent !== "undefined") {
             if (tagcontent.indexOf('<') != -1) {
                 xml += '>' + tagcontent + '</' + name + '>\n';
             } else {
diff --git a/test/rendering-mss/empty_name.mss b/test/rendering-mss/empty_name.mss
new file mode 100644
index 0000000..d05bb16
--- /dev/null
+++ b/test/rendering-mss/empty_name.mss
@@ -0,0 +1,6 @@
+#poi-point {
+    text-name: "";
+    text-face-name: "DejaVu Sans Book";
+    text-size: 10;
+    text-fill: chocolate;
+}
\ No newline at end of file
diff --git a/test/rendering-mss/empty_name.xml b/test/rendering-mss/empty_name.xml
new file mode 100644
index 0000000..669849c
--- /dev/null
+++ b/test/rendering-mss/empty_name.xml
@@ -0,0 +1,5 @@
+<Style name="style" filter-mode="first">
+  <Rule>
+    <TextSymbolizer face-name="DejaVu Sans Book" size="10" fill="#d2691e" ><![CDATA[]]></TextSymbolizer>
+  </Rule>
+</Style>
\ No newline at end of file