cartodb/carto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

only call done when the test is actually finished, whether error or not - refs #210

Browse Source
This commit is contained in:
Dane Springmeyer 2012-12-18 16:02:44 -08:00
parent 7d7cc2653c
commit 4825f9aee8
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/errorhandling.test.js
View File

@ -21,6 +21,7 @@ helper.files('errorhandling', 'mml', function(file) {
}).render(mml, function (err) {
if (!err) {
console.warn("*** <--- WARNING invalid error handling test found (" + file + "): all error handling tests should throw errors!");
done();
} else {
var result = helper.resultFile(file);
var output = err.message;
@ -28,6 +29,7 @@ helper.files('errorhandling', 'mml', function(file) {
// at the end of read files. Determine why.
fs.readFile(helper.resultFile(file), 'utf8', function(err, data) {
if (!err) assert.deepEqual(output, data.substr(0, data.length - 1));
done();
});
}
});
@ -38,10 +40,9 @@ helper.files('errorhandling', 'mml', function(file) {
// at the end of read files. Determine why.
fs.readFile(helper.resultFile(file), 'utf8', function(err, data) {
if (!err) assert.deepEqual(output, data.substr(0, data.length - 1));
done();
});
}
done();
});
});
});
@ -62,13 +63,15 @@ helper.files('errorhandling', 'mss', function(file) {
}).renderMSS(mss, function (err) {
if (!err) {
console.warn("*** <--- WARNING invalid error handling test found (" + file + "): all error handling tests should throw errors!");
} else {
done();
} else {
var result = helper.resultFile(file);
var output = err.message;
// @TODO for some reason, fs.readFile includes an additional \n
// at the end of read files. Determine why.
fs.readFile(helper.resultFile(file), 'utf8', function(err, data) {
if (!err) assert.deepEqual(output, data.substr(0, data.length - 1));
done();
});
}
});
@ -79,9 +82,9 @@ helper.files('errorhandling', 'mss', function(file) {
// at the end of read files. Determine why.
fs.readFile(helper.resultFile(file), 'utf8', function(err, data) {
if (!err) assert.deepEqual(output, data.substr(0, data.length - 1));
done();
});
}
done();
});
});
});