Commit Graph

5238 Commits

Author SHA1 Message Date
Javier Goizueta
befedfd80a Use ifError to check for errors 2018-05-21 17:03:16 +02:00
Javier Goizueta
d828a92ea3 Use ifError to check for errors 2018-05-21 16:59:36 +02:00
Javier Goizueta
4711b28c25
Merge pull request #952 from CartoDB/metadata
Add optional layer metadata at instantiation
2018-05-21 16:05:43 +02:00
Javier Goizueta
d7a90e6be4 Remove debugging comment 2018-05-21 15:54:52 +02:00
Javier Goizueta
267e770c63 Update NEWS 2018-05-21 15:43:32 +02:00
Javier Goizueta
b233f18a0f Modernize code copied from SQL API 2018-05-21 15:43:23 +02:00
Javier Goizueta
32092d212e Fix bug 2018-05-21 14:05:27 +02:00
Javier Goizueta
11cdcc65ad Add safety limit to sample metadata
The sampling probability is now being computed using an estimate of the table row count
This could led to too high probabilities (to large samples) if the estimate is not accurate.
To avoid potential problems with large samples we've added a LIMIT to the sampling queries.
2018-05-21 12:45:16 +02:00
Javier Goizueta
fecd63e582 Fix bug 2018-05-21 11:59:49 +02:00
Javier Goizueta
38e55367b1 Revert error behaviour for estimatedFeatureCount
Keep current production behavior of ignoreing errors when computing this stat and returning -1.
This is done as to no introduce any instability in production at the moment.
2018-05-21 11:44:52 +02:00
Javier Goizueta
4e99ff1c39 Fix token substitution for stat queries 2018-05-18 22:25:32 +02:00
Javier Goizueta
8e8458e557 Merge branch 'master' into metadata 2018-05-18 20:49:26 +02:00
Javier Goizueta
391ac51f0f Implement metadata queries with plain Promises
Remove usage of PhasedExecution
This achives better query execution granularity and
removes questionable usage of shared results object.
It introduces a couple of behavior changes:
* estimatedFeatureCount desn't ignore errors now
* sample always uses estimatedFeatureCount,even if the actual count is also computed.
2018-05-18 15:33:07 +02:00
Javier Goizueta
4bc8fb207a Use sql_raw for query without aggregation 2018-05-18 15:29:46 +02:00
Daniel G. Aubert
42cd36afb7
Merge pull request #960 from CartoDB/upgrade-camshaft-0.61.9
Upgrade camshaft to version 0.61.9
2018-05-17 14:25:08 +02:00
Daniel García Aubert
dd0436e68e Update NEWS 2018-05-17 13:55:57 +02:00
Daniel García Aubert
d76a0d9f22 Upgrade camshaft to version 0.61.9 2018-05-17 13:47:52 +02:00
Simon Martín
d9e047e20e NEWS 2018-05-17 12:44:31 +02:00
Simon Martín
af35ff7419
Merge pull request #953 from CartoDB/fix-dataview-typeof
handling pg_typeof == undefined error in dataviews
2018-05-17 12:39:16 +02:00
Simon Martín
81bace1dca Merge branch 'master' into fix-dataview-typeof 2018-05-17 12:13:11 +02:00
Simon Martín
38c69de01b
Merge pull request #955 from CartoDB/fix-image-format-png
Unsupported static image format
2018-05-17 12:07:54 +02:00
Simon Martín
213ca07c38 Merge branch 'master' into fix-image-format-png 2018-05-17 11:41:30 +02:00
Javier Goizueta
012fa91e83 Typo 2018-05-16 14:45:34 +02:00
Javier Goizueta
3af1182206 Rename misleading function argument 2018-05-16 14:45:19 +02:00
Simon Martín
04e00bb834 Merge branch 'master' into fix-image-format-png 2018-05-16 14:40:59 +02:00
Raúl Marín
df089cb0a5
Merge pull request #958 from CartoDB/windshaft473
Windshaft 4.7.3
2018-05-16 12:30:59 +02:00
Simon Martín
56aa1b39f0 removing 'jpeg' as valid format and no checking agains lowercase 2018-05-16 12:00:40 +02:00
Daniel G. Aubert
d940ab36e1
Merge pull request #954 from CartoDB/controllers-goodies
Controllers goodies
2018-05-14 18:31:48 +02:00
Raul Marin
0f48d51062 Update yarn.lock 2018-05-14 15:01:04 +02:00
Raul Marin
1c5344ba6e Update Windshaft to 4.7.3 2018-05-14 14:54:29 +02:00
Daniel G. Aubert
0d4654122c
Merge pull request #956 from CartoDB/add-merge-params-options
Express Routers: Activate mergeParams option
2018-05-14 12:59:44 +02:00
Daniel García Aubert
63a9d58c67 Add regression test 2018-05-14 12:28:57 +02:00
Daniel García Aubert
5a397afd06 In order to extract common middlewares between routers and controlles we need to activate mergeParams options to preserve the req.params from the parent router 2018-05-14 11:50:48 +02:00
Javier Goizueta
b8109401d1 Tests for metadata with aggregation 2018-05-13 13:05:39 +02:00
Javier Goizueta
5e09c80b71 Remove comment 2018-05-11 19:57:49 +02:00
Javier Goizueta
b906f88a44 Slight refactor 2018-05-11 19:32:03 +02:00
Javier Goizueta
24b1b53ba0 Merge branch 'master' into metadata 2018-05-11 18:58:38 +02:00
Javier Goizueta
53fae9fbbd Comment 2018-05-11 18:57:14 +02:00
Simon Martín
ad4ed7a06b detail 2018-05-11 17:47:47 +02:00
Simon Martín
7f5e655730 static image format for last route 2018-05-11 17:45:17 +02:00
Simon Martín
e96a9f0b46 static image format controllers 2018-05-11 17:42:28 +02:00
Simon Martín
db7b4fa937 static image format tests 2018-05-11 17:41:26 +02:00
Simon Martín
7112341c51 checkStaticImageFormat middleware 2018-05-11 17:41:00 +02:00
Daniel García Aubert
f4d60f963d Add comment 2018-05-11 16:37:02 +02:00
Daniel García Aubert
c6babc7dc4 Create .middlewares() method to build midlleware stack to perform request 2018-05-11 16:26:05 +02:00
Daniel García Aubert
3905ed796e Use ES6 class syntax 2018-05-11 16:24:28 +02:00
Daniel García Aubert
595d006d5b Rename function 2018-05-11 16:21:57 +02:00
Daniel García Aubert
3bcf6d7ca0 Place comment 2018-05-11 16:20:44 +02:00
Daniel García Aubert
68f5ee7bde Use ES6 class syntax 2018-05-11 16:18:52 +02:00
Daniel García Aubert
9db6e2161b Use ES6 class syntax 2018-05-11 16:15:33 +02:00