Daniel García Aubert
8f797c3c41
Fix EOF
2017-09-12 10:16:16 +02:00
Daniel García Aubert
2576c3e7d5
Rename _shouldOverrideRange & _shouldOverrideBins methods
2017-09-12 10:14:55 +02:00
Daniel García Aubert
3a936474cf
Fix bad merge with master
2017-09-11 19:48:46 +02:00
Daniel García Aubert
a98f5bf08b
Merge branch 'master' into time-series-refactor
2017-09-11 19:38:21 +02:00
Daniel García Aubert
03babcb43b
Simplify condition and remove unused method
2017-09-11 19:31:38 +02:00
Daniel García Aubert
9aa5a9e850
Improve comment
2017-09-11 19:26:28 +02:00
Daniel García Aubert
e3bffcd39d
Use inline functions to filter desired fields of the row
2017-09-11 19:24:01 +02:00
Daniel García Aubert
5fc2b46d56
Fix bad condition
2017-09-11 19:14:11 +02:00
Daniel García Aubert
7c69240748
Use parameter default value
2017-09-11 19:10:06 +02:00
Daniel García Aubert
ee43378c68
Use arrow function
2017-09-11 19:09:05 +02:00
Daniel García Aubert
09981c2560
Extract method to check valid aggregation
2017-09-11 18:57:16 +02:00
Daniel García Aubert
fd9534797c
Minor refactors
2017-09-11 18:44:14 +02:00
Daniel García Aubert
38e7e71328
Implement template method pattern to format histogram query output
2017-09-11 17:19:02 +02:00
Daniel García Aubert
271932a80d
Extract condition to a method
2017-09-11 17:17:42 +02:00
Daniel García Aubert
4f33e0d794
Rename Histogram.dataview by Histogram.histogramImplementation
2017-09-11 15:34:42 +02:00
Daniel García Aubert
ec23bfc79b
Rename HistogramBase by BaseHistogram
2017-09-11 13:54:46 +02:00
Daniel García Aubert
6c3fa045cd
Rename HistogramBase by BaseHistogram
2017-09-11 13:53:05 +02:00
Simon
d75ee965ae
changing some 'var' to 'let/const'
2017-09-11 11:48:33 +02:00
Simon
5e9b2e45c7
creating HistogramBase with the common functions of NumericHistogram and DateHistogram
2017-09-11 11:32:20 +02:00
Simon
e4a20fa954
adding forgotten return
2017-09-08 17:57:35 +02:00
Simon
a20900210d
removing unneeded _isDateHistogram function
2017-09-08 17:54:25 +02:00
Simon
2650c3b3e6
removing self=this assignment
2017-09-08 17:51:02 +02:00
Simon
25ef2610aa
Varible declarations to let/const
2017-09-08 17:43:10 +02:00
Simon
92f6f59e07
Fix jshint style errors
2017-09-08 16:13:23 +02:00
Simon
5e07cc2ad1
Remove unneeded condittion
2017-09-08 16:06:54 +02:00
Simon
5593d92c4b
Do not choose histogram implementation until getResult()
2017-09-08 15:55:23 +02:00
Simon
29f32cb9cc
Expose dataview's methods to bypass concrete overview's implementations
2017-09-08 15:53:00 +02:00
Simon
1d4935cc9a
Fix undefined while destrutcuring assignment
2017-09-08 15:50:01 +02:00
Simon
f75b4312a1
Fix undefined while destructuring assignment
2017-09-08 15:49:25 +02:00
Simon
23dd143fa5
Make Histogram class as context of state pattern
2017-09-08 12:48:08 +02:00
Simon
7d42afcdb4
remove unnecessary properties of NumericHistogram
2017-09-08 12:22:24 +02:00
Simon
78b95d05d0
make private functions
2017-09-08 12:21:22 +02:00
Simon
fb753e50a2
remove getOffset function
2017-09-08 12:19:05 +02:00
Simon
c863cdd9f6
remove getAggregation function
2017-09-08 12:17:29 +02:00
Simon
a4ebce52db
remove unnecessary properties in format function
2017-09-08 12:16:56 +02:00
Simon
4a00a2d673
rename buildQueryTpl by _buildQueryTpl
2017-09-08 12:15:21 +02:00
Simon
38f0e23efe
rename buildNumericHistogramQueryTpl by buildQueryTpl
2017-09-08 12:10:31 +02:00
Simon
7f14785091
fix namespace for debugging
2017-09-08 12:07:49 +02:00
Simon
db969a51ad
make public some private functions
2017-09-08 12:07:07 +02:00
Simon
3441ad6aa9
rename _buildDateHistogramQueryTpl by _buildQueryTpl
2017-09-08 12:04:25 +02:00
Simon
347dea8f66
naming private functions
2017-09-08 12:01:15 +02:00
Simon
a3112aa929
fix function name in recursion
2017-09-08 11:55:28 +02:00
Simon
157946cc42
Rename DateHistogram class
2017-09-08 11:54:30 +02:00
Simon
8ce25d958c
fix namespace for debugging
2017-09-08 11:53:47 +02:00
Daniel García Aubert
7e099be134
Add specific implementations of histograms based on column type; still not used
2017-09-08 10:29:54 +02:00
Javier Torres
7dd5c5b15d
Do not use distinct when calculating quantiles
2017-09-07 14:39:25 +02:00
Daniel García Aubert
63a7ee08d0
Avoid nested ternaries for date histograms
2017-09-06 19:15:39 +02:00
Daniel García Aubert
b63a67a5b8
Avoid nested ternaries
2017-09-06 18:33:51 +02:00
Daniel García Aubert
1ac8455dc2
Use template strings to build histogram query
2017-09-06 18:13:34 +02:00
Daniel García Aubert
9f52e58be8
Rename BaseWidget by BaseDataview
2017-09-06 16:54:08 +02:00
Daniel García Aubert
4edf18f77a
Remove underscore requirement
2017-09-06 16:52:17 +02:00
Daniel García Aubert
b5d2de8edc
Do not use _.omit()
2017-09-06 16:49:00 +02:00
Ivan Malagon
bd8d147a7d
Fix out of range bug in date histograms
2017-09-06 16:21:01 +02:00
Daniel García Aubert
8ac041805c
Use typeof !== string instead of underscore's equivalent
2017-09-06 16:20:01 +02:00
Daniel García Aubert
6e0dc8666d
Use .hasOwnProperty() instead of underscore's equivalent
2017-09-06 16:14:29 +02:00
Daniel García Aubert
3e55bd2abb
Make happy to jshint
2017-09-06 15:56:52 +02:00
Daniel García Aubert
da1d0550f6
Use const keyword for constants
2017-09-06 15:52:13 +02:00
Daniel García Aubert
c37ef36a61
Move parseOffset function to a class method
2017-09-06 15:49:05 +02:00
Daniel García Aubert
9e3e1cad9a
Move getWidth function to a class method
2017-09-06 15:47:21 +02:00
Daniel García Aubert
e84f30488f
Move getBinsCount function to a class method
2017-09-06 15:45:51 +02:00
Daniel García Aubert
49a60caffc
Move getBinEnd function to a class method
2017-09-06 15:42:29 +02:00
Daniel García Aubert
392e004879
Move getBinStart and populateBinStart function to a class method
2017-09-06 15:38:23 +02:00
Daniel García Aubert
288656301b
Move getOffset function to a class method
2017-09-06 15:37:28 +02:00
Daniel García Aubert
96740b82ed
Move getAggregation function to a class method
2017-09-06 13:52:02 +02:00
Daniel García Aubert
1be66e1552
Use const for requirements
2017-09-06 13:47:19 +02:00
Daniel García Aubert
5ba2dfbbd6
Use ES6 class syntax
2017-09-06 13:43:54 +02:00
Daniel García Aubert
af4b3d81cd
make happy to jshint
2017-09-06 11:55:40 +02:00
Daniel García Aubert
bbd42b73f2
Remove dot requirement
2017-09-06 11:44:52 +02:00
Daniel García Aubert
8e2535745e
Use template string for columnCastTpl
2017-09-06 11:44:25 +02:00
Daniel García Aubert
4f75f6c07b
Use template string for dateBinsQueryTpl and dateHistogramQueryTpl
2017-09-06 11:41:24 +02:00
Daniel García Aubert
0ede3013db
Use template string for dateOverrideBasicsQueryTpl
2017-09-06 10:57:38 +02:00
Daniel García Aubert
0b79ac76db
Use template string for dateBasicsQueryTpl
2017-09-06 10:39:17 +02:00
Daniel García Aubert
2739364193
Use template string for histogramQueryTpl
2017-09-05 15:53:21 +02:00
Daniel García Aubert
adcff54589
Use template string for nansQueryTpl
2017-09-05 15:53:06 +02:00
Daniel García Aubert
734cfa6d83
Fix undefined argument
2017-09-05 15:51:31 +02:00
Daniel García Aubert
7ea6b3e371
Use template string for infinitiesQueryTpl
2017-09-05 12:21:30 +02:00
Daniel García Aubert
f1018f3272
Use template string for nullsQueryTpl
2017-09-05 12:18:42 +02:00
Daniel García Aubert
151bdec1fd
Use template string for overrideBinsQueryTpl
2017-09-05 12:16:38 +02:00
Daniel García Aubert
5d413ac1f9
Use template string for overrideBasicsQueryTpl
2017-09-05 11:26:38 +02:00
Daniel García Aubert
37b1376767
Fix bad find & replace
2017-09-05 11:26:27 +02:00
Daniel García Aubert
00741bc0a4
Use template string for basicsQueryTpl
2017-09-05 10:41:48 +02:00
Daniel García Aubert
c580600590
Extract template to filter out special numeric values
2017-09-05 10:36:18 +02:00
Daniel García Aubert
6373fe8652
Use template string for filteredQueryTpl
2017-09-04 19:01:58 +02:00
Daniel García Aubert
5ce419d863
Use template string for dateIntervalQueryTpl
2017-09-04 18:42:30 +02:00
Raul Ochoa
91ce3a5489
Going green: allow to use bbox param, along lon, lat, and zoom
...
The `bbox` param was removed from the base controller, the rest kept
working as they are declared in the base, but it's better to declare
them here as well.
Fixes #735 .
2017-08-29 13:05:03 +00:00
Raul Ochoa
1c6a76af72
Merge pull request #726 from CartoDB/725-polygon-count
...
725 fix polygon count
2017-08-16 15:33:19 +02:00
Raul Ochoa
e7c206762d
String comparison and regex to match errors instead of indexOf
2017-08-10 16:09:26 +02:00
Raul Ochoa
69eaa72819
String comparison and regex to match errors instead of indexOf
2017-08-10 16:06:10 +02:00
Raul Ochoa
23edf78a67
Remove unnecessary step
2017-08-10 15:58:25 +02:00
Simon
814b123b2b
fix 725 using the ST_Intersects function instead of &&
2017-08-09 18:55:14 +02:00
Daniel García Aubert
14f85abd39
Merge branch 'master' into response-time-limit
2017-08-09 18:48:38 +02:00
Daniel García Aubert
c643160671
Prefix date interval query (to calculate automatic aggregation) to avoid name collision
2017-08-08 10:32:53 +02:00
Daniel García Aubert
e7a0b246a3
Prefix with double underscore
2017-08-08 10:20:36 +02:00
Daniel García Aubert
3c061769c6
Prefix basics columns to avoid name collision
2017-08-08 10:11:35 +02:00
Daniel García Aubert
7e159c565b
Prefix iqr query calculation to avoid name collision
2017-08-08 10:03:40 +02:00
Daniel García Aubert
ff3d7ed7b2
Fix jshint typo
2017-08-08 09:57:12 +02:00
Daniel García Aubert
cf71489a7f
Prefix nans and infinities counters to avoid name collision
2017-08-08 09:54:49 +02:00
Daniel García Aubert
c7e5dbf158
Fix query aliases
2017-08-08 09:46:34 +02:00
Daniel García Aubert
34cf45bc9d
Prefix infinities query to avoid name collision
2017-08-08 09:43:31 +02:00
Daniel García Aubert
7e058955ea
Use final naming to group by
2017-08-08 09:39:51 +02:00
Daniel García Aubert
a9e3bc3cda
Prefix filtered source to avoid name collision
2017-08-08 09:36:23 +02:00
Daniel García Aubert
3ee064a59f
Prefix nulls query to avoid name collision
2017-08-08 09:32:13 +02:00
Daniel García Aubert
f3ababffc1
Prefix bins query to avoid name collision
2017-08-08 09:12:52 +02:00
Daniel García Aubert
0f8de9e74b
Add prefix to basics query to avoid name collision
2017-08-08 09:06:36 +02:00
Daniel García Aubert
91d5a0e4e4
Remove column avg_val in group_by
2017-08-08 08:46:26 +02:00
Daniel García Aubert
e446160151
Use final columns to group by
2017-08-08 08:45:05 +02:00
Daniel García Aubert
823925d091
Add prefix to bins_array to avoid name collision
2017-08-08 08:41:22 +02:00
Daniel García Aubert
994e58bef7
Add prefix to bins_number and nulls_cout to avoid name collision
2017-08-08 08:33:26 +02:00
Daniel García Aubert
5c80ff8191
Extract query: move condition to a method
2017-08-07 19:24:15 +02:00
Daniel García Aubert
b2bbc329ea
Apply prefix for intermediate query variables to avoid name colision
2017-08-07 19:03:49 +02:00
Daniel García Aubert
1f8da14c2a
Cast to timestamp start_date and end_date to calculate bins when date column is timestamptz
2017-08-07 18:27:24 +02:00
Daniel García Aubert
660078f284
Fix minor issues with timezones
2017-08-07 16:53:08 +02:00
Raul Ochoa
e9d925334c
Move layergroup-token to models
...
We will share it between tests and a middleware to parse the token.
2017-08-04 17:51:10 +02:00
Raul Ochoa
399561d076
Implement LZMA query param inflating as middleware
...
The req2params method is doing too many things,
this is an initial step to do fewer things in that method.
2017-08-04 17:30:46 +02:00
Javier Goizueta
82cab3ccc7
Merge pull request #719 from CartoDB/ramp-infinities-nans
...
Exclude Infinities & NaNs from ramps
2017-08-04 09:38:44 +02:00
Daniel García Aubert
48ad7059e1
Going green: do not rely on falsy conditional
2017-08-03 18:23:55 +02:00
Daniel
a696bdc723
Merge pull request #706 from CartoDB/705-special-numeric-values
...
Support special numeric values for json responses
2017-08-03 15:21:29 +02:00
Daniel García Aubert
b56d2ec30b
Validate aggregation value
2017-08-03 12:24:05 +02:00
Daniel García Aubert
7fed91900d
Handle error
2017-08-03 12:19:34 +02:00
Javier Goizueta
b4799124e6
Exclude non-finite values when computing ramps
2017-08-02 17:28:46 +02:00
Daniel García Aubert
0a57e86cb8
Do not build data histogram infinitely when overriding aggregation with auto mode
2017-08-02 12:06:10 +02:00
Daniel García Aubert
3574700c2d
Remove tiler render limit
2017-08-02 11:07:44 +02:00
Daniel García Aubert
ab879e2634
Use new version of getUserTimeoutRenderLimits
2017-08-01 19:13:55 +02:00
Daniel García Aubert
9034508244
Support automattic aggregation only when aggregation para is set to 'auto'
2017-08-01 17:15:45 +02:00
Daniel García Aubert
b2b68ffd5c
Merge branch 'master' into 691-date-histogram
2017-08-01 16:07:27 +02:00
Daniel García Aubert
0594407b38
Change error message
2017-08-01 15:03:09 +02:00
Daniel García Aubert
262f854e68
Remove error wrapping
2017-08-01 13:10:55 +02:00
Daniel García Aubert
9258ad7ecc
Fix style typo
2017-08-01 12:56:03 +02:00
Daniel García Aubert
4c3e3005aa
Apply asset fallback to database timeout errors
2017-08-01 12:52:34 +02:00
Daniel García Aubert
44fc34b1ce
Improve timeout error message
2017-07-31 20:07:31 +02:00
Daniel García Aubert
1fdc0621e7
Categorize timeout errors
2017-07-31 19:36:07 +02:00
Daniel García Aubert
5974413d5c
Use 429 to indicate timeout errors
2017-07-31 19:08:29 +02:00
Daniel García Aubert
49d2f513c6
Fix typo
2017-07-31 18:51:23 +02:00
Daniel García Aubert
f2e043b063
Do not expose database error info
2017-07-31 17:56:58 +02:00
Daniel García Aubert
eee4fc815e
Do not expose database error details
2017-07-25 19:11:56 +02:00
Daniel García Aubert
669707b26c
Fix typo
2017-07-18 11:56:54 +02:00
Daniel García Aubert
40dc94e010
Merge branch 'master' into response-time-limit
2017-07-18 11:25:23 +02:00
Daniel García Aubert
eccc3597aa
Respond with 204 when vector tile is empty
2017-07-17 19:44:18 +02:00
Carlos Matallín
e30b883906
Merge branch '691-date-histogram' into 691-date-histogram-offset
2017-07-14 18:38:13 +02:00
Carlos Matallín
70b4d5b7fd
replace timezone => offset
2017-07-14 18:30:36 +02:00
Daniel García Aubert
0fffafa1db
Add timestamp_start in histogram summary to help to build the histogram in frontend side
2017-07-14 18:22:05 +02:00
Daniel García Aubert
21b8655f85
Return timezone applied or 0 if not present
2017-07-13 19:42:22 +02:00
Daniel García Aubert
c8286233be
Do not apply timezone for minute an hour aggregations
2017-07-12 17:08:55 +02:00
Daniel García Aubert
b67f6053e8
Should respect first timestamp as bin_start
2017-07-12 15:19:28 +02:00
Daniel García Aubert
967dca9578
Improve readability
2017-07-12 15:10:39 +02:00
Daniel
5ea5c1b2dc
Merge pull request #708 from CartoDB/11245-aggregation-search
...
widgets: support for aggregation in search results
2017-07-11 09:44:33 +02:00
Carlos Matallín
dd934a3913
linter
2017-07-07 17:44:32 +02:00
Carlos Matallín
f7a763b637
widgets: add aggregation for search results
2017-07-07 17:09:17 +02:00
Daniel García Aubert
0684c1b9d3
Work in progress: get timeout from redis
2017-07-05 19:08:19 +02:00
Daniel García Aubert
468f641af8
Going green: automatic mode works with dates
2017-06-29 16:57:27 +02:00
Daniel García Aubert
6d2934b30b
Going red: add test to check automatic mode works with dates
2017-06-29 16:53:52 +02:00
Daniel García Aubert
7018af18b6
Support automatic aggregation for time-series histogram
2017-06-28 19:58:45 +02:00
Daniel García Aubert
3e12bfe27a
Going green: support special numeric values for json responses
2017-06-27 11:53:22 +02:00
Javier Goizueta
b2f3735e95
The formula widget wasn't using the no_filters query for checking column types
2017-06-23 18:59:51 +02:00
Javier Goizueta
166e29e8ce
Forward queries parameter from overview dataviews to base dataviews
2017-06-23 16:53:16 +02:00
Daniel García Aubert
32274e66fd
Dataview formula: count infinities and nans as we do with nulls
2017-06-23 12:24:22 +02:00
Daniel García Aubert
a6daca9628
Support date histograms using timestamp with and without timezones
2017-06-22 18:04:23 +02:00
Daniel García Aubert
6f7cb75256
Fix bad datetime conversion
2017-06-21 20:19:02 +02:00
Daniel García Aubert
5555b8ad8e
Going green: support numeric NaN values for dataviews
2017-06-21 18:59:36 +02:00
Ivan Malagon
6bfedef7eb
Cast histogram width bucket to timestamp
2017-06-19 12:47:08 +02:00
Daniel García Aubert
17aebf53e2
Merge branch 'master' into dataviews-special-float-values
2017-06-19 10:58:13 +02:00
Daniel García Aubert
b1ac5b8ca9
Handle special float values only if column is float
2017-06-16 12:57:46 +02:00
Daniel García Aubert
20d7f1a7c5
Handle special float values only when aggregation columns is float (overviews)
2017-06-15 19:22:26 +02:00
Daniel García Aubert
115d8fe685
Handle special float values only when aggregation columns is float
2017-06-15 19:07:31 +02:00
Daniel García Aubert
ad570ab6f2
Use dataview base to get column type in formula dataviews
2017-06-15 18:04:35 +02:00
Daniel García Aubert
443c1100d7
Formula dataview: support special values only if column is a float column
2017-06-15 16:31:31 +02:00
Daniel García Aubert
7d0af4e259
Going green: handle special float values for formula when overviews are involved
2017-06-14 19:44:48 +02:00
Daniel García Aubert
dee00e6abd
Going green: handle special float values for histogram when overviews are involved
2017-06-14 19:00:37 +02:00
Daniel García Aubert
3f17c8b15a
Filter out special float values before categorizing them
2017-06-14 15:05:46 +02:00
Daniel García Aubert
668b22628c
Going green: support special float values in aggergation dataview with overviews
2017-06-13 19:01:59 +02:00
Daniel García Aubert
551b6d409a
Remove bad condition
2017-06-13 09:44:53 +02:00
Daniel García Aubert
3ae66e4143
Do not filter special values out if aggregation column is not defined
2017-06-13 09:30:43 +02:00
Daniel García Aubert
cb7ec5d556
Fix jshint typos
2017-06-12 19:49:58 +02:00
Daniel García Aubert
8b2fa27ba7
Calculate aggregation filtering out special float values
2017-06-12 19:45:06 +02:00
Daniel García Aubert
962fa05574
Remove console
2017-06-12 19:28:49 +02:00
Daniel García Aubert
7b5111614c
Summarize special float values for ranked aggregation
2017-06-12 19:21:41 +02:00
Daniel García Aubert
e60bb770db
Summarizes infinity and NaN values
2017-06-12 18:55:33 +02:00
Daniel García Aubert
0aae29fb4b
Fix jshint typo
2017-06-09 15:28:18 +02:00
Daniel García Aubert
9ba65bd5a4
Going green: Fix test for formula overviews flavour
2017-06-09 15:18:52 +02:00
Daniel García Aubert
fe5c76d65b
Remove jshint hook
2017-06-08 19:25:05 +02:00
Daniel García Aubert
29a6658e3d
Migrate dataviews endpoints to use the allow-query-params
2017-06-08 19:22:33 +02:00
Daniel García Aubert
2772fc62d2
Use a set/dict for checking the existence
2017-06-08 18:38:44 +02:00
Daniel García Aubert
0d4ac64f00
Merge branch 'master' into 691-date-histogram
2017-06-08 18:34:25 +02:00
Daniel García Aubert
cd53eda0a5
Handle Infinity and NaN values for histograms
2017-06-08 16:01:41 +02:00
Daniel García Aubert
35d4fb4d27
Improve readability, using extract method pattern
2017-06-07 16:11:09 +02:00
Daniel García Aubert
42e2f9e4b1
Update commented use cases
2017-06-07 15:54:28 +02:00
Daniel García Aubert
d3bcf6f80d
Do not omit nonexistent property
2017-06-06 09:15:49 +02:00
Daniel García Aubert
eeea51e10d
Removed unused column in group by statement
2017-06-05 17:26:37 +02:00
Daniel García Aubert
9337cd948c
Fix typo
2017-06-05 16:26:29 +02:00
Daniel García Aubert
e82d688a18
Fix typo
2017-06-05 16:09:47 +02:00
Daniel García Aubert
95a6ad3b86
Support quarter aggregation in histograms over date columns
2017-06-05 16:04:42 +02:00
Daniel García Aubert
d01787842f
Support UTC timezone override
2017-06-05 15:23:04 +02:00
Daniel García Aubert
6ff3b33cde
Removed bins_start as query output
2017-06-05 14:17:50 +02:00
Daniel García Aubert
32eeb57fce
Reduce complexity in function
2017-06-02 19:00:26 +02:00
Daniel García Aubert
8bc38a375a
Support timezone aggregation
2017-06-02 18:37:49 +02:00
Daniel García Aubert
c1fac13d6b
Be able to accept timezone parameter
2017-06-02 12:45:34 +02:00
Daniel García Aubert
9c34428984
Allow override start and end params
2017-06-02 12:15:43 +02:00
Daniel García Aubert
1d66e49910
WIP implemented date histogram
2017-06-01 20:07:46 +02:00
Raul Ochoa
4b562e6768
Merge conditions
2017-05-31 13:00:37 -04:00
Raul Ochoa
b4fbe0b8cf
No in advance var definition
2017-05-31 12:58:35 -04:00
Raul Ochoa
62514fc563
Extract query rewrite data to function
2017-05-31 12:58:20 -04:00
Raul Ochoa
ef3cad6599
Extract to function
2017-05-31 12:52:41 -04:00
Raul Ochoa
4e53803b3b
Create BBoxFilter independently from rewrite data
2017-05-31 12:51:07 -04:00
Javier Goizueta
31557b06be
Add test to detect and fix incorrect bbox filter splitting
...
When bbox crosses date line and is split in two, the eastern box wasn't correct
2017-05-31 11:09:51 -04:00
Mario de Frutos
440953b1cd
If we have the stats FF disbabled return empty array instead of null
...
But we keep checking for elements in the returned object because
we don't want to include the stats property if the FF is disabled
2017-05-30 10:47:47 +02:00
Daniel García Aubert
87e6e64d42
Merge branch 'master' into 664-layergroup-stats
2017-05-23 12:41:14 +02:00
Raul Ochoa
8b0964ad7e
Remove Promise hack from turbo-carto adapter
2017-05-22 18:45:24 +02:00
Daniel García Aubert
cc2a96579b
Merge branch 'master' into 664-layergroup-stats
2017-05-18 16:39:52 +02:00
Daniel García Aubert
3978d58d66
Remove empty line
2017-05-18 16:12:28 +02:00
Daniel García Aubert
cd86387fa7
Merge branch 'fix-buffersize-undefined-in-mapconfig' into 664-layergroup-stats
2017-05-18 15:58:12 +02:00
Daniel García Aubert
3ce38d7081
Going green: fix type error when no buffersize is defined in mapconfig
2017-05-18 15:49:57 +02:00
Mario de Frutos
c9e6e921cb
Merge branch 'master' into 664-layergroup-stats
2017-05-18 13:45:38 +02:00
Mario de Frutos
ed56094be2
PR changes
2017-05-18 11:51:12 +02:00
Daniel García Aubert
c65518cf41
Get back layer-stats from windshaft-stats
2017-05-17 20:16:43 +02:00
Daniel García Aubert
fb4ee61b83
Use setInmmediate vs process.nextTick
2017-05-17 12:55:05 +02:00
Daniel García Aubert
808c729a0e
Now supported formats for buffer-size customization are bound to the adapter
2017-05-17 12:33:41 +02:00
Daniel García Aubert
4602fb3ecf
Send stats for png32 tiles
2017-05-17 12:16:16 +02:00
Daniel García Aubert
c59996303d
Send stats for mvt tiles
2017-05-17 12:04:11 +02:00
Daniel García Aubert
e13ae8d5af
Do not make optional layer param in URL template
2017-05-17 11:40:18 +02:00
Mario de Frutos
5969c99e8a
Removed not used parameters for layer stats
2017-05-12 16:42:10 +02:00
Mario de Frutos
59585b5cd9
We leave only one feature flag for stats
2017-05-12 16:42:10 +02:00
Daniel García Aubert
5a44d6c547
Drop geojson support for buffersize customization
2017-05-10 18:35:30 +02:00
Daniel García Aubert
53d1b2fbbf
Rename mapconfig-named-map-adapter by mapconfig-buffer-size-adapter
2017-05-10 18:16:22 +02:00
Daniel García Aubert
2c9d30e042
Be more flexible validating buffer-size customization
2017-05-10 17:49:28 +02:00
Mario de Frutos
daf19c5e27
Stats backend only provides stats not metadata
2017-05-10 17:17:01 +02:00
Mario de Frutos
7d5b6b0820
Lint changes and yarn.lock
2017-05-09 18:24:24 +02:00
Mario de Frutos
759d28f12f
Include feature flag to enable/disable stats
2017-05-09 12:51:22 +02:00
Mario de Frutos
15c68711aa
Create stats backend to decouple stats logic from map controller
2017-05-09 12:31:16 +02:00
Mario de Frutos
568d6b5458
Include the layers metadata into the layergroup object
2017-05-09 11:59:11 +02:00
Mario de Frutos
525c0f2afa
Added rendererCache as dependency for map controller
2017-05-09 11:58:48 +02:00
Mario de Frutos
3f6c8fa51c
Use windshaft-stats to get layer stats
2017-05-08 18:42:40 +02:00
Daniel García Aubert
c9af38ecd0
Fix issue when 'grid.json' format is not captured properly due to a weird behaviour in regex
2017-04-28 19:21:51 +02:00
Mario de Frutos
be58adb1b9
Be able to override buffer-size configuration without placeholders in named maps
2017-04-28 19:20:00 +02:00
Mario de Frutos
332a56b736
Mapconfig only support object for the buffer-size property
2017-04-28 14:22:16 +02:00
Daniel García Aubert
c481d6473c
Use parseInt instead of number constructor
2017-04-26 17:01:21 +02:00
Daniel García Aubert
07e507e1aa
Remove dictionary as placeholder type for named maps
2017-04-25 19:40:12 +02:00
Mario de Frutos
7ea7a991aa
Buffersize customizable through named maps' placeholders
2017-04-25 19:27:31 +02:00
Daniel García Aubert
0c08713521
First attempt: support buffer-size configuration for named maps
2017-04-25 14:34:17 +02:00
Mario de Frutos
9707881bf9
Include check for surrogate-key header and renamed the test file
2017-04-07 15:59:58 +02:00
Mario de Frutos
fa6493ae44
Affected tables are now included in X-Cache-Channel
2017-04-07 15:59:58 +02:00
Mario de Frutos
5e4d1d5c1c
Get affected tables and add it to the layergroup
2017-04-07 15:59:58 +02:00
Raul Ochoa
c325df1414
Merge pull request #655 from CartoDB/static-maps-layers-filter
...
Static maps layers filter
2017-04-03 12:07:38 +02:00
Raul Ochoa
ededc73fd7
Throw on invalid params argument
2017-03-31 18:39:29 +02:00
Raul Ochoa
cad02bfad7
Remove all conditional branches to call req.profiler
...
req.profiler is created in a middleware for all requests.
2017-03-30 20:31:53 +02:00
Raul Ochoa
94299f0452
Configure extra allowed params per endpoint via middleware
...
Instead of making all params available in all endpoints, we control
what endpoints allow what extra params.
Dataviews endpoints should be migrated to this.
2017-03-30 20:12:55 +02:00
Raul Ochoa
6468822295
Remove layer param before creating a better solution
2017-03-30 20:08:45 +02:00
Raul Ochoa
777ae31426
Merge branch 'master' into static-maps-layers-filter
2017-03-30 19:33:59 +02:00
Raul Ochoa
e0c2423ace
Remove unused import
2017-03-23 01:14:56 +01:00
Raul Ochoa
5e429ba71f
Use crc32 instead of md5 for computing subdomain candidate
2017-03-23 01:03:45 +01:00
Raul Ochoa
2da834784f
Generate URLs for resources based on CDN + template rules
2017-03-22 18:58:37 +01:00
Raul Ochoa
fa94550261
Include changes for overviews implementation
2017-03-16 19:15:34 +01:00
Raul Ochoa
8694c120bc
Allow to overwrite layers filter in static maps images
2017-03-15 11:00:10 +01:00
Raul Ochoa
992b2b6ba7
Histogram column type discovery query uses non-filtered query
...
Pass all queries to the dataview and use the no filters one for
discovering what is the column type associated to the histogram dataview.
2017-03-13 18:40:29 +01:00
Mario de Frutos
b446c31cbc
Other category now uses the selected aggregated function ( #633 )
...
* Other category in category widget uses selected aggregation function
Fixes https://github.com/CartoDB/Windshaft-cartodb/issues/628
2017-03-02 10:48:20 +01:00
Raul Ochoa
8a1c7f5b52
Close timer for response preparation
...
Timer for affectedTables is taking everything from response timing,
adding a tag to represent all the response preparation.
That way affectedTables only represents the time for retrieving the
affected tables themselves.
2017-02-22 18:38:25 +01:00
Raul Ochoa
8a76cd506f
Fix issue with global Promise object
2017-02-20 18:46:48 +01:00
Raul Ochoa
12279d5c00
Cast dataview override values to Number or throw error
...
We were letting params expected as Numbers to be passed as any type
when they were not Numbers.
2017-02-02 16:20:16 +01:00
Daniel García Aubert
83301238d2
Port changes to overviews
2017-01-17 17:10:08 +01:00
Daniel García Aubert
a4a1fb930a
Be able to not compute NULL categories and null values wheter aggregation operation is not 'count'
2017-01-17 17:09:17 +01:00
Javier Goizueta
6a4f5d52ec
Don't use overviews for date histograms
2016-12-16 17:51:36 +01:00
Javier Goizueta
ccaae2dd66
Remove spurious parameter from overviews dataviews functions
...
In the overviews-specialized dataview classes the sql-generating
functions had an unneeded parameter filters.
In some cases, since this parameter was not being paaased from
the base dataviews class it was masking the override parameter.
2016-12-16 17:37:05 +01:00
Javier Goizueta
cfcba4e578
Wueries with sql_wrap should not be rewritten
2016-12-02 14:00:21 +01:00
Raul Ochoa
bfacd56800
Allow to use workers for transforming cartocss into mapnik XML
2016-12-01 17:02:40 +01:00
Raul Ochoa
1f975e15c1
Default to empty object for cdn URLs
2016-11-22 17:01:34 +01:00
Raul Ochoa
6c69ba54db
Use actual CDN url for HTTP and HTTPS
2016-11-22 16:44:06 +01:00
Raul Ochoa
49f9904d00
Allow to set resource URL templates with substitution tokens
2016-11-22 16:41:31 +01:00
Raul Ochoa
7afd0dfa4e
Remove prototype reference
2016-11-22 13:38:56 +01:00
Raul Ochoa
e74ce9dfd8
Analyses limit configuration allows to set other limits than timeout
...
Configuration is now defined as a dictionary instead of just timeouts
per analysis type
2016-11-10 18:41:59 +01:00
Daniel García Aubert
9faac9f9fe
Retrieve error with context if map validation fails
2016-11-01 11:00:58 +01:00
Daniel García Aubert
c20fd9691a
Fix order in categories query to make it compatible with lenyends
2016-10-26 13:16:24 +02:00
Raul Ochoa
376573459c
Default analyses limits can be defined in configuration
2016-10-20 14:03:42 +02:00
Raul Ochoa
7352a28908
Fix variable assigning to itself
2016-10-11 16:01:43 +02:00
Raul Ochoa
cd978d7384
Retrieve analysis limits and pass them into camshaft
2016-10-11 15:46:11 +02:00
Raul Ochoa
adf5c17e0d
Use context from adapters as provider context
2016-09-28 19:22:03 +02:00
Raul Ochoa
2a4ae88bc0
Merge remote-tracking branch 'origin/master' into cartocss-meta
2016-09-28 17:06:36 +02:00
Daniel García Aubert
2d75985cb3
Recreate stream on SIGHUP event
2016-09-26 17:39:27 +02:00
Daniel García Aubert
10feea0d48
Pass logger configuration to analysis backend and create a stream based on config
2016-09-23 17:11:04 +02:00
Raul Ochoa
263294a3f5
Add metadata only for existing layers in turbocarto context
2016-09-20 16:19:22 +02:00
Raul Ochoa
f9df30f70b
Append turbo-carto metadata per layer
2016-09-20 16:09:21 +02:00
Raul Ochoa
61d31ec054
Handle metadata from turbo-carto
2016-09-20 16:08:53 +02:00
Raul Ochoa
c8917bfc4c
Return stats in callback
2016-09-20 16:00:33 +02:00
Raul Ochoa
36b69a05e5
Compute some stats in queries
2016-09-20 16:00:06 +02:00
Daniel García Aubert
908070ecd7
Fix jshint issue
2016-09-01 16:53:10 +02:00
Daniel García Aubert
7c6a58cd30
Made explicit to recreate named-map-provider
2016-09-01 16:42:06 +02:00
Daniel García Aubert
b0990a1132
Removed template-maps backend from named-maps controller
2016-09-01 16:31:30 +02:00
Daniel García Aubert
e0d304b033
Applied approach similar to static image options
2016-09-01 12:37:04 +02:00
Daniel García Aubert
e4a9f2d64c
Added template map as dependency of named maps controller
2016-09-01 12:35:35 +02:00
Daniel García Aubert
1bed8623a2
Overwrites rendererparams instead of layergroup in mapconfig
2016-08-31 20:40:55 +02:00
Daniel García Aubert
30c4b00f33
New approach: decorates named_map_provider to return the with visible layers
2016-08-31 19:40:00 +02:00
Daniel García Aubert
31e18d04d7
Undo unneeded optimization
2016-08-31 13:57:28 +02:00
Daniel García Aubert
b61f1d2b53
Attached layer_visibility
property to the named template
2016-08-26 17:30:03 +02:00
Daniel García Aubert
6a7613de6b
Improved layergroup instantiation to filter non visible layers
2016-08-26 14:42:33 +02:00
Daniel García Aubert
ee46549e04
First approach
2016-08-25 20:04:23 +02:00
Raul Ochoa
b5a6d6974c
Do not cast type in category ramp
2016-07-18 11:58:19 +02:00
Raul Ochoa
3af340d384
Add controller to list user analyses
2016-07-12 16:08:48 +02:00
Daniel García Aubert
77f691520c
Merge branch 'master' into 546-add-node-id-to-analyis-errors
2016-07-11 16:06:58 +02:00
Daniel García Aubert
dfaa6ec024
Fixes #546 , added node_id
property to analysis errors
2016-07-11 15:48:26 +02:00
Raul Ochoa
d0980a2872
Return last error message for failed nodes on map creation
2016-07-11 10:42:46 +02:00
Raul Ochoa
71c7d8a90c
Limit analysis creation concurrency
2016-07-07 00:36:59 +02:00
Raul Ochoa
57bb8dbbe3
Use mapconfig to to store/retrieve dataviews queries
2016-07-06 22:31:08 +02:00