cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop throwing up warnings during testing

Browse Source 
Yeah, I test with different repos and branches. Big deal. Shut up.
This commit is contained in:
Raul Marin 2019-09-12 13:28:33 +02:00 committed by Raul Marin
parent eb71601cd6
commit f9b6e92745
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lib/cartodb/server.js
View File

@ -79,22 +79,22 @@ function getAndValidateVersions(options) {
windshaft_cartodb: packageDefinition.version windshaft_cartodb: packageDefinition.version
}; };
var dependenciesToValidate = ['camshaft', 'turbo-carto', 'windshaft']; if (process.env.NODE_ENV !== 'test') {
dependenciesToValidate.forEach(function(depName) { var dependenciesToValidate = ['camshaft', 'turbo-carto', 'windshaft'];
var declaredDependencyVersion = declaredDependencies[depName]; dependenciesToValidate.forEach(function(depName) {
var installedDependencyVersion = installedDependenciesVersions[depName]; var declaredDependencyVersion = declaredDependencies[depName];
if (!semver.satisfies(installedDependencyVersion,declaredDependencyVersion)) { var installedDependencyVersion = installedDependenciesVersions[depName];
warn( if (!semver.satisfies(installedDependencyVersion,declaredDependencyVersion)) {
'Dependency="%s" installed version="%s" does not match declared version="%s". Check your installation.', warn(`Dependency="${depName}" installed version="${installedDependencyVersion}" does ` +
depName, installedDependencyVersion, declaredDependencyVersion `not match declared version="${declaredDependencyVersion}". Check your installation.`);
); }
} });
});
// Be nice and warn if configured mapnik version is != installed mapnik version // Be nice and warn if configured mapnik version is != installed mapnik version
if (windshaft.mapnik.versions.mapnik !== options.grainstore.mapnik_version) { if (windshaft.mapnik.versions.mapnik !== options.grainstore.mapnik_version) {
warn('WARNING: detected mapnik version (' + windshaft.mapnik.versions.mapnik + ')' + warn('WARNING: detected mapnik version (' + windshaft.mapnik.versions.mapnik + ')' +
' != configured mapnik version (' + options.grainstore.mapnik_version + ')'); ' != configured mapnik version (' + options.grainstore.mapnik_version + ')');
}
} }
return installedDependenciesVersions; return installedDependenciesVersions;