From dd8a70eb95d056eaea7d765e68865aac3946a9be Mon Sep 17 00:00:00 2001 From: Raul Ochoa Date: Wed, 29 Jun 2016 16:10:26 +0200 Subject: [PATCH] Uses node list so identical nodes are not de-duplicated and can be used with different ids Fixes #528 --- NEWS.md | 2 ++ lib/cartodb/backends/dataview.js | 4 ++-- .../models/mapconfig/adapter/analysis-mapconfig-adapter.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/NEWS.md b/NEWS.md index f82143c4..63a0fc8b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,8 @@ Released 2016-mm-dd +Bug fixes: + - Uses node list so identical nodes are not de-duplicated and can be used with different ids #528. ## 2.53.4 diff --git a/lib/cartodb/backends/dataview.js b/lib/cartodb/backends/dataview.js index 53911a7f..4481d8be 100644 --- a/lib/cartodb/backends/dataview.js +++ b/lib/cartodb/backends/dataview.js @@ -85,7 +85,7 @@ DataviewBackend.prototype.getDataview = function (mapConfigProvider, user, param sourceId2Node[rootNode.params.id] = rootNode; } - analysis.getSortedNodes().forEach(function(node) { + analysis.getNodes().forEach(function(node) { if (node.params && node.params.id) { sourceId2Node[node.params.id] = node; } @@ -232,7 +232,7 @@ DataviewBackend.prototype.search = function (mapConfigProvider, user, params, ca sourceId2Node[rootNode.params.id] = rootNode; } - analysis.getSortedNodes().forEach(function(node) { + analysis.getNodes().forEach(function(node) { if (node.params && node.params.id) { sourceId2Node[node.params.id] = node; } diff --git a/lib/cartodb/models/mapconfig/adapter/analysis-mapconfig-adapter.js b/lib/cartodb/models/mapconfig/adapter/analysis-mapconfig-adapter.js index e1b5620f..7fd2316b 100644 --- a/lib/cartodb/models/mapconfig/adapter/analysis-mapconfig-adapter.js +++ b/lib/cartodb/models/mapconfig/adapter/analysis-mapconfig-adapter.js @@ -92,7 +92,7 @@ AnalysisMapConfigAdapter.prototype.getMapConfig = function(user, requestMapConfi sourceId2Query[rootNode.params.id] = rootNode; } - analysis.getSortedNodes().forEach(function(node) { + analysis.getNodes().forEach(function(node) { if (node.params && node.params.id) { sourceId2Query[node.params.id] = node; }