cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not use underscore

Browse Source
This commit is contained in:
Daniel García Aubert 2017-09-14 18:02:13 +02:00
parent a4ecc18f2f
commit 9c64d674b3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/cartodb/models/dataview/formula.js
View File

@ -1,4 +1,3 @@
var _ = require('underscore');
var BaseDataview = require('./base'); var BaseDataview = require('./base');
var debug = require('debug')('windshaft:dataview:formula'); var debug = require('debug')('windshaft:dataview:formula');
@ -51,7 +50,7 @@ var TYPE = 'formula';
} }
*/ */
function Formula(query, options = {}, queries = {}) { function Formula(query, options = {}, queries = {}) {
if (!_.isString(options.operation)) { if (typeof options.operation !== 'string') {
throw new Error('Formula expects `operation` in widget options'); throw new Error('Formula expects `operation` in widget options');
} }
@ -59,7 +58,7 @@ function Formula(query, options = {}, queries = {}) {
throw new Error("Formula does not support '" + options.operation + "' operation"); throw new Error("Formula does not support '" + options.operation + "' operation");
} }
if (options.operation !== 'count' && !_.isString(options.column)) { if (options.operation !== 'count' && typeof options.column !== 'string') {
throw new Error('Formula expects `column` in widget options'); throw new Error('Formula expects `column` in widget options');
} }