cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use .hasOwnProperty() instead of underscore's equivalent

Browse Source
This commit is contained in:
Daniel García Aubert 2017-09-06 16:14:29 +02:00
parent 3e55bd2abb
commit 6e0dc8666d
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/cartodb/models/dataview/histogram.js
View File

@ -465,11 +465,14 @@ module.exports = class Histogram extends BaseWidget {
} }
_shouldOverride (override) { _shouldOverride (override) {
return override && _.has(override, 'start') && _.has(override, 'end') && _.has(override, 'bins'); return override &&
override.hasOwnProperty('start') &&
override.hasOwnProperty('end') &&
override.hasOwnProperty('bins');
} }
_shouldOverrideBins (override) { _shouldOverrideBins (override) {
return override && _.has(override, 'bins'); return override && override.hasOwnProperty('bins');
} }
_buildDateHistogramQuery (psql, override, callback) { _buildDateHistogramQuery (psql, override, callback) {
@ -499,7 +502,7 @@ module.exports = class Histogram extends BaseWidget {
var dateBasicsQuery; var dateBasicsQuery;
if (override && _.has(override, 'start') && _.has(override, 'end')) { if (override && override.hasOwnProperty('start') && override.hasOwnProperty('end')) {
dateBasicsQuery = dateOverrideBasicsQueryTpl({ dateBasicsQuery = dateOverrideBasicsQueryTpl({
_query: _query, _query: _query,
_column: _column, _column: _column,
@ -731,4 +734,4 @@ module.exports = class Histogram extends BaseWidget {
var offsetInHours = Math.ceil(offset / 3600); var offsetInHours = Math.ceil(offset / 3600);
return '' + offsetInHours; return '' + offsetInHours;
} }
} };