cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply extract method to condition

Browse Source
This commit is contained in:
Daniel García Aubert 2017-09-14 16:56:55 +02:00
parent 1f3b0beddf
commit 51907b9545
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cartodb/models/dataview/aggregation.js
View File

@ -236,7 +236,7 @@ module.exports = class Aggregation extends BaseDataview {
override = {};
}
if (this.aggregationColumn && this._isFloatColumn === null) {
if (this._shouldCheckColumnType()) {
this._isFloatColumn = false;
this.getColumnType(psql, this.aggregationColumn, this.queries.no_filters, function (err, type) {
if (!err && !!type) {
@ -266,6 +266,10 @@ module.exports = class Aggregation extends BaseDataview {
return callback(null, aggregationSql);
}
_shouldCheckColumnType () {
return this.aggregationColumn && this._isFloatColumn === null;
}
format (result) {
const {
count = 0,