cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a constant Last-Modified time with cache_policy=persist

Browse Source 
After all if the client is asking for persistance it doesn't make
sense to set a different Last-Modified for different incoming
requests (even if we don't expect any) ....
This commit is contained in:
Sandro Santilli 2013-07-15 12:09:13 +02:00
parent afd4c3b460
commit 4b5899ff1a
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cartodb/server_options.js
View File

@ -213,11 +213,11 @@ module.exports = function(){
if ( req.params.token ) cache_policy = 'persist'; if ( req.params.token ) cache_policy = 'persist';
if ( cache_policy == 'persist' ) { if ( cache_policy == 'persist' ) {
res.header('Cache-Control', 'public,max-age=31536000'); // 1 year res.header('Cache-Control', 'public,max-age=31536000'); // 1 year
// Set Last-Modified header to a constant time in the past
res.header('Last-Modified', new Date(0).toUTCString());
} else { } else {
var ttl = global.environment.varnish.ttl || 86400; var ttl = global.environment.varnish.ttl || 86400;
res.header('Cache-Control', 'no-cache,max-age='+ttl+',must-revalidate, public'); res.header('Cache-Control', 'no-cache,max-age='+ttl+',must-revalidate, public');
}
// Set Last-Modified header // Set Last-Modified header
// //
// Currently sets it to NOW // Currently sets it to NOW
@ -225,6 +225,8 @@ module.exports = function(){
// TODO: find out a real value, querying for most recent change in // TODO: find out a real value, querying for most recent change in
// any of the source tables // any of the source tables
res.header('Last-Modified', new Date().toUTCString()); res.header('Last-Modified', new Date().toUTCString());
}
me.generateCacheChannel(req, function(err, channel){ me.generateCacheChannel(req, function(err, channel){
if ( ! err ) { if ( ! err ) {