cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix HTTP status code distinction between 200 and 204

Browse Source
This commit is contained in:
David Manzanares 2017-10-06 16:19:00 +02:00
parent 58be2b8fc5
commit 43885f130b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cartodb/controllers/layergroup.js
View File

@ -278,6 +278,10 @@ LayergroupController.prototype.tileOrLayer = function (req, res) {
); );
}; };
function getStatusCode(tile, format){
return tile.length===0 && format==='mvt'? 204:200;
}
// This function is meant for being called as the very last // This function is meant for being called as the very last
// step by all endpoints serving tiles or grids // step by all endpoints serving tiles or grids
LayergroupController.prototype.finalizeGetTileOrGrid = function(err, req, res, tile, headers) { LayergroupController.prototype.finalizeGetTileOrGrid = function(err, req, res, tile, headers) {
@ -313,7 +317,7 @@ LayergroupController.prototype.finalizeGetTileOrGrid = function(err, req, res, t
global.statsClient.increment('windshaft.tiles.error'); global.statsClient.increment('windshaft.tiles.error');
global.statsClient.increment('windshaft.tiles.' + formatStat + '.error'); global.statsClient.increment('windshaft.tiles.' + formatStat + '.error');
} else { } else {
this.sendResponse(req, res, tile, tile.length===0? 204:200, headers); this.sendResponse(req, res, tile, getStatusCode(tile, formatStat), headers);
global.statsClient.increment('windshaft.tiles.success'); global.statsClient.increment('windshaft.tiles.success');
global.statsClient.increment('windshaft.tiles.' + formatStat + '.success'); global.statsClient.increment('windshaft.tiles.' + formatStat + '.success');
} }