cartodb/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Going green: fix type error when no buffersize is defined in mapconfig

Browse Source
This commit is contained in:
Daniel García Aubert 2017-05-18 15:49:57 +02:00
parent e9112da305
commit 3ce38d7081
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/cartodb/models/mapconfig/adapter/mapconfig-buffer-size-adapter.js
View File

@ -9,8 +9,13 @@ MapConfigBufferSizeAdapter.prototype.getMapConfig = function (user, requestMapCo
return callback(null, requestMapConfig); return callback(null, requestMapConfig);
} }
this.formats.forEach(function (format) { this.formats.forEach(function (format) {
if (Number.isFinite(context.templateParams.buffersize[format])) { if (Number.isFinite(context.templateParams.buffersize[format])) {
if (requestMapConfig.buffersize === undefined) {
requestMapConfig.buffersize = {};
}
requestMapConfig.buffersize[format] = context.templateParams.buffersize[format]; requestMapConfig.buffersize[format] = context.templateParams.buffersize[format];
} }
}); });

5
test/acceptance/buffer-size-format.js
View File

@ -283,7 +283,7 @@ describe('buffer size per format for named maps', function () {
}); });
describe.only('buffer size per format for named maps w/o placeholders', function () { describe('buffer size per format for named maps w/o placeholders', function () {
var testCases = [ var testCases = [
{ {
desc: 'should get png tile using buffer-size 0 overriden by template params', desc: 'should get png tile using buffer-size 0 overriden by template params',
@ -398,7 +398,8 @@ describe.only('buffer size per format for named maps w/o placeholders', function
} }
}, },
{ {
desc: 'should get png tile using buffer-size 0 overriden by template params with no buffersize in mapconfig', desc: 'should get png tile using buffer-size 0' +
' overriden by template params with no buffersize in mapconfig',
coords: { z: 7, x: 64, y: 48 }, coords: { z: 7, x: 64, y: 48 },
format: 'png', format: 'png',
placeholders: { placeholders: {