Leaflet/spec/suites/layer
ghybs fe9e0f2333
Fix(Draggable): compensate for container CSS scale (#6055)
* Test(MapDragSpec): add mouse drag with CSS scaled container

This test is failing as of this commit.

* Fix(Draggable): measure drag compensating for CSS scale

so that the computed offset (i.e. user drag length) is divided by the CSS scale applied on the `_element`'s container. Later on when `Draggable` updates the `_element`'s position, the latter is affected by the CSS scale by the browser.
Added a `getSizedParentNode` function in `DomUtil` in order to automatically retrieve the closest parent node in the DOM hierarchy tree that has a non null size (so that we can compute the scale in `DomEvent.getMousePosition`), without having to specify the parent node explicitly (which is ugly).

* Fix(getMousePosition): getBoundingClientRect is in page scale

therefore it must also be divided by the container scale in order to compute the relative position of the event in the scaled container.

* Test(MarkerDragSpec): add drag with CSS scaled container

this should pass automatically at this commit, thanks to the previous modification of Draggable.

* Debug(map-scaled): add draggable marker

as well as another CSS scaled wrapper, plus some border and padding, and debugging console logs, to make sure the computations of `getMousePosition` are correct (correctly removing the border width, and compensating for CSS scale).

* Docs(getMousePosition): explicitly exclude border

* Docs(DomUtil): add return value of getSizedParentNode

was missing in docstring.

* Feat(DomUtil): add getScale function

so that it can be used by DomEvent.getMousePosition and Draggable.

* Refactor(Draggable): cache container scale

to avoid triggering browser reflow continuously during _onMove, but only on drag start (_onDown).
By compensating for the scale within Draggable instead of delegating to DomEvent.getMousePosition, it also becomes possible to check first for the clickTolerance, so that we prevents user's small movement based on screen, irrespective of rendered scale.

* Test(Map+MarkerDrag): remove scale on initial movement

that is intended to overcome Draggable clickTolerance, since now it is based on screen pixels, irrespective of applied CSS scale on the map.
Thanks to the tolerance in the expected final position, this has no effect on the result of the test, even though the overall drag is now slightly shorter.

* Refactor(DomEvent): use DomUtil.getScale in getMousePosition

to factorize scale computation (also used within Draggable).
2018-03-16 19:46:44 +04:00
..
marker Fix(Draggable): compensate for container CSS scale (#6055) 2018-03-16 19:46:44 +04:00
tile Test(ImageOverlay+TileLayer): crossOrigin option add 5th test case (#6027) 2018-01-25 13:46:34 +01:00
vector Fix race condition when removing canvas before it has rendered (#6033) 2018-01-29 15:36:50 +01:00
FeatureGroupSpec.js Clean up and document event propagation properties (#5880) 2017-10-27 16:18:12 +02:00
GeoJSONSpec.js Add precision parameter to all toGeoJSON functions (#5444) 2017-05-31 14:06:58 +02:00
ImageOverlaySpec.js Test(ImageOverlay+TileLayer): crossOrigin option add 5th test case (#6027) 2018-01-25 13:46:34 +01:00
LayerGroupSpec.js [LayerGroup] Use eachLayer for iterations over layers (#5809) 2017-09-30 16:58:10 +03:00
PopupSpec.js add icon popupAnchor option test for nonPhantom browsers (#5865) 2017-10-23 15:29:28 +02:00
TooltipSpec.js skipIfNotTouch instead of overriding Browser.touch (#5869) 2017-10-26 15:34:31 +03:00