9d6e6fcdf4
* Adds initial tests for L.Layer#popup * Fixes Layer.isPopupOpen when no popup is bound This fixes uncaught exception when checking whether a popup isOpen(), when the layer has no popup bound to it.
395 lines
11 KiB
JavaScript
395 lines
11 KiB
JavaScript
describe('Popup', function () {
|
|
|
|
var c, map;
|
|
|
|
beforeEach(function () {
|
|
c = document.createElement('div');
|
|
c.style.width = '400px';
|
|
c.style.height = '400px';
|
|
document.body.appendChild(c);
|
|
map = new L.Map(c);
|
|
map.setView(new L.LatLng(55.8, 37.6), 6);
|
|
});
|
|
|
|
afterEach(function () {
|
|
document.body.removeChild(c);
|
|
});
|
|
|
|
it("closes on map click when map has closePopupOnClick option", function () {
|
|
map.options.closePopupOnClick = true;
|
|
|
|
var popup = new L.Popup()
|
|
.setLatLng(new L.LatLng(55.8, 37.6))
|
|
.openOn(map);
|
|
|
|
happen.click(c);
|
|
|
|
expect(map.hasLayer(popup)).to.be(false);
|
|
});
|
|
|
|
it("closes on map click when popup has closeOnClick option", function () {
|
|
map.options.closePopupOnClick = false;
|
|
|
|
var popup = new L.Popup({closeOnClick: true})
|
|
.setLatLng(new L.LatLng(55.8, 37.6))
|
|
.openOn(map);
|
|
|
|
happen.click(c);
|
|
|
|
expect(map.hasLayer(popup)).to.be(false);
|
|
});
|
|
|
|
it("does not close on map click when popup has closeOnClick: false option", function () {
|
|
map.options.closePopupOnClick = true;
|
|
|
|
var popup = new L.Popup({closeOnClick: false})
|
|
.setLatLng(new L.LatLng(55.8, 37.6))
|
|
.openOn(map);
|
|
|
|
happen.click(c);
|
|
|
|
expect(map.hasLayer(popup)).to.be(true);
|
|
});
|
|
|
|
it("toggles its visibility when marker is clicked", function () {
|
|
var marker = new L.Marker(new L.LatLng(55.8, 37.6));
|
|
map.addLayer(marker);
|
|
|
|
marker.bindPopup('Popup1');
|
|
expect(map.hasLayer(marker._popup)).to.be(false);
|
|
|
|
// toggle open popup
|
|
happen.click(marker._icon);
|
|
expect(map.hasLayer(marker._popup)).to.be(true);
|
|
|
|
// toggle close popup
|
|
happen.click(marker._icon);
|
|
expect(map.hasLayer(marker._popup)).to.be(false);
|
|
});
|
|
|
|
it("it should use a popup with a function as content with a FeatureGroup", function () {
|
|
var marker1 = new L.Marker(new L.LatLng(55.8, 37.6));
|
|
var marker2 = new L.Marker(new L.LatLng(54.6, 38.2));
|
|
var group = new L.FeatureGroup([marker1, marker2]).addTo(map);
|
|
|
|
marker1.description = "I'm marker 1.";
|
|
marker2.description = "I'm marker 2.";
|
|
group.bindPopup(function (layer) {
|
|
return layer.description;
|
|
});
|
|
|
|
map.options.closePopupOnClick = true;
|
|
|
|
// toggle popup on marker1
|
|
group.fire('click', {
|
|
latlng: new L.LatLng(55.8, 37.6),
|
|
layer: marker1
|
|
});
|
|
expect(map.hasLayer(group._popup)).to.be(true);
|
|
expect(group._popup._contentNode.innerHTML).to.be("I'm marker 1.");
|
|
|
|
// toggle popup on marker2
|
|
group.fire('click', {
|
|
latlng: new L.LatLng(54.6, 38.2),
|
|
layer: marker2
|
|
});
|
|
expect(map.hasLayer(group._popup)).to.be(true);
|
|
expect(group._popup._contentNode.innerHTML).to.be("I'm marker 2.");
|
|
});
|
|
|
|
it("it should function for popup content after bindPopup is called", function () {
|
|
var marker1 = new L.Marker(new L.LatLng(55.8, 37.6));
|
|
var marker2 = new L.Marker(new L.LatLng(54.6, 38.2));
|
|
var group = new L.FeatureGroup([marker1]).addTo(map);
|
|
|
|
marker1.description = "I'm marker 1.";
|
|
marker2.description = "I'm marker 2.";
|
|
group.bindPopup(function (layer) {
|
|
return layer.description;
|
|
});
|
|
|
|
group.addLayer(marker2);
|
|
|
|
map.options.closePopupOnClick = true;
|
|
|
|
// toggle popup on marker1
|
|
group.fire('click', {
|
|
latlng: new L.LatLng(55.8, 37.6),
|
|
layer: marker1
|
|
});
|
|
expect(map.hasLayer(group._popup)).to.be(true);
|
|
expect(group._popup._contentNode.innerHTML).to.be("I'm marker 1.");
|
|
|
|
// toggle popup on marker2
|
|
group.fire('click', {
|
|
latlng: new L.LatLng(54.6, 38.2),
|
|
layer: marker2
|
|
});
|
|
expect(map.hasLayer(group._popup)).to.be(true);
|
|
expect(group._popup._contentNode.innerHTML).to.be("I'm marker 2.");
|
|
});
|
|
|
|
it("should use a function for popup content when a source is passed to Popup", function () {
|
|
var marker = new L.Marker(new L.LatLng(55.8, 37.6)).addTo(map);
|
|
var popup = L.popup({}, marker);
|
|
|
|
marker.description = "I am a marker.";
|
|
|
|
marker.bindPopup(function (layer) {
|
|
return layer.description;
|
|
});
|
|
|
|
marker.fire('click', {
|
|
latlng: new L.LatLng(55.8, 37.6)
|
|
});
|
|
|
|
expect(map.hasLayer(marker._popup)).to.be(true);
|
|
expect(marker._popup._contentNode.innerHTML).to.be("I am a marker.");
|
|
});
|
|
|
|
it("triggers popupopen on marker when popup opens", function () {
|
|
var marker1 = new L.Marker(new L.LatLng(55.8, 37.6));
|
|
var marker2 = new L.Marker(new L.LatLng(57.123076977278, 44.861962891635));
|
|
|
|
map.addLayer(marker1);
|
|
map.addLayer(marker2);
|
|
|
|
marker1.bindPopup('Popup1');
|
|
marker2.bindPopup('Popup2');
|
|
|
|
var spy = sinon.spy();
|
|
|
|
marker1.on('popupopen', spy);
|
|
|
|
expect(spy.called).to.be(false);
|
|
marker2.openPopup();
|
|
expect(spy.called).to.be(false);
|
|
marker1.openPopup();
|
|
expect(spy.called).to.be(true);
|
|
});
|
|
|
|
it("triggers popupclose on marker when popup closes", function () {
|
|
var marker1 = new L.Marker(new L.LatLng(55.8, 37.6));
|
|
var marker2 = new L.Marker(new L.LatLng(57.123076977278, 44.861962891635));
|
|
|
|
map.addLayer(marker1);
|
|
map.addLayer(marker2);
|
|
|
|
marker1.bindPopup('Popup1');
|
|
marker2.bindPopup('Popup2');
|
|
|
|
var spy = sinon.spy();
|
|
|
|
marker1.on('popupclose', spy);
|
|
|
|
expect(spy.called).to.be(false);
|
|
marker2.openPopup();
|
|
expect(spy.called).to.be(false);
|
|
marker1.openPopup();
|
|
expect(spy.called).to.be(false);
|
|
marker2.openPopup();
|
|
expect(spy.called).to.be(true);
|
|
marker1.openPopup();
|
|
marker1.closePopup();
|
|
expect(spy.callCount).to.be(2);
|
|
});
|
|
|
|
it("should take into account icon popupAnchor option", function () {
|
|
var autoPanBefore = L.Popup.prototype.options.autoPan;
|
|
L.Popup.prototype.options.autoPan = false;
|
|
var popupAnchorBefore = L.Icon.Default.prototype.options.popupAnchor;
|
|
L.Icon.Default.prototype.options.popupAnchor = [0, 0];
|
|
|
|
var latlng = new L.LatLng(55.8, 37.6),
|
|
offset = new L.Point(20, 30),
|
|
icon = new L.DivIcon({popupAnchor: offset}),
|
|
marker1 = new L.Marker(latlng),
|
|
marker2 = new L.Marker(latlng, {icon: icon});
|
|
|
|
marker1.bindPopup('Popup').addTo(map);
|
|
marker1.openPopup();
|
|
var defaultLeft = parseInt(marker1._popup._container.style.left, 10);
|
|
var defaultBottom = parseInt(marker1._popup._container.style.bottom, 10);
|
|
marker2.bindPopup('Popup').addTo(map);
|
|
marker2.openPopup();
|
|
var offsetLeft = parseInt(marker2._popup._container.style.left, 10);
|
|
var offsetBottom = parseInt(marker2._popup._container.style.bottom, 10);
|
|
expect(offsetLeft - offset.x).to.eql(defaultLeft);
|
|
expect(offsetBottom + offset.y).to.eql(defaultBottom);
|
|
|
|
// Now retry passing a popup instance to bindPopup
|
|
marker2.bindPopup(new L.Popup());
|
|
marker2.openPopup();
|
|
offsetLeft = parseInt(marker2._popup._container.style.left, 10);
|
|
offsetBottom = parseInt(marker2._popup._container.style.bottom, 10);
|
|
expect(offsetLeft - offset.x).to.eql(defaultLeft);
|
|
expect(offsetBottom + offset.y).to.eql(defaultBottom);
|
|
|
|
L.Popup.prototype.options.autoPan = autoPanBefore;
|
|
L.Icon.Default.prototype.options.popupAnchor = popupAnchorBefore;
|
|
});
|
|
|
|
it("prevents an underlying map click for Layer", function () {
|
|
var layer = new L.Polygon([[55.8, 37.6], [55.9, 37.7], [56.0, 37.8]]).addTo(map);
|
|
layer.bindPopup("layer popup");
|
|
|
|
var mapClicked = false;
|
|
map.on('click', function (e) {
|
|
mapClicked = true;
|
|
new L.Popup()
|
|
.setLatLng(e.latlng)
|
|
.setContent("map popup")
|
|
.openOn(map);
|
|
});
|
|
|
|
expect(map.hasLayer(layer._popup)).to.be(false);
|
|
happen.click(layer._path);
|
|
expect(mapClicked).to.be(false);
|
|
expect(map.hasLayer(layer._popup)).to.be(true);
|
|
});
|
|
|
|
});
|
|
|
|
describe("L.Map#openPopup", function () {
|
|
var c, map;
|
|
|
|
beforeEach(function () {
|
|
c = document.createElement('div');
|
|
c.style.width = '400px';
|
|
c.style.height = '400px';
|
|
map = new L.Map(c);
|
|
map.setView(new L.LatLng(55.8, 37.6), 6);
|
|
});
|
|
|
|
afterEach(function () {
|
|
if (document.body.contains(c)) {
|
|
document.body.removeChild(c);
|
|
}
|
|
});
|
|
|
|
it("adds the popup layer to the map", function () {
|
|
var popup = new L.Popup()
|
|
.setLatLng(new L.LatLng(55.8, 37.6));
|
|
map.openPopup(popup);
|
|
expect(map.hasLayer(popup)).to.be(true);
|
|
});
|
|
|
|
it("sets popup location", function () {
|
|
var popup = new L.Popup();
|
|
map.openPopup(popup, L.latLng(55.8, 37.6));
|
|
expect(popup.getLatLng()).to.eql(L.latLng(55.8, 37.6));
|
|
});
|
|
|
|
it("creates a popup from content", function () {
|
|
map.openPopup("<h2>Hello World</h2>", L.latLng(55.8, 37.6));
|
|
expect(map._popup).to.be.an(L.Popup);
|
|
expect(map._popup.getContent()).to.eql("<h2>Hello World</h2>");
|
|
});
|
|
|
|
it("closes existing popup", function () {
|
|
var p1 = new L.Popup().setLatLng(new L.LatLng(55.8, 37.6));
|
|
var p2 = new L.Popup().setLatLng(new L.LatLng(55.8, 37.6));
|
|
map.openPopup(p1);
|
|
map.openPopup(p2);
|
|
expect(map.hasLayer(p1)).to.be(false);
|
|
});
|
|
|
|
it("does not close existing popup with autoClose: false option", function () {
|
|
var p1 = new L.Popup({autoClose: false}).setLatLng(new L.LatLng(55.8, 37.6));
|
|
var p2 = new L.Popup().setLatLng(new L.LatLng(55.8, 37.6));
|
|
map.openPopup(p1);
|
|
map.openPopup(p2);
|
|
expect(map.hasLayer(p1)).to.be(true);
|
|
expect(map.hasLayer(p2)).to.be(true);
|
|
});
|
|
|
|
it('should not be closen when dragging map', function (done) {
|
|
document.body.appendChild(c);
|
|
c.style.position = 'absolute';
|
|
c.style.left = 0;
|
|
c.style.top = 0;
|
|
c.style.zIndex = 10000;
|
|
var coords = map._container.getBoundingClientRect();
|
|
var spy = sinon.spy();
|
|
var p = new L.Popup().setLatLng(new L.LatLng(55.8, 37.6));
|
|
map.openPopup(p);
|
|
expect(map.hasLayer(p)).to.be(true);
|
|
map.on('drag', spy);
|
|
var hand = new Hand({
|
|
timing: 'fastframe',
|
|
onStop: function () {
|
|
expect(spy.called).to.be(true);
|
|
expect(map.hasLayer(p)).to.be(true);
|
|
done();
|
|
}});
|
|
var mouse = hand.growFinger('mouse');
|
|
mouse.moveTo(coords.left + 100, coords.left + 100, 0)
|
|
.down().moveBy(10, 10, 20).up();
|
|
});
|
|
|
|
});
|
|
|
|
describe('L.Layer#_popup', function () {
|
|
var c, map, marker;
|
|
|
|
beforeEach(function () {
|
|
c = document.createElement('div');
|
|
c.style.width = '400px';
|
|
c.style.height = '400px';
|
|
map = new L.Map(c);
|
|
map.setView(new L.LatLng(55.8, 37.6), 6);
|
|
marker = L.marker(L.latLng(55.8, 37.6)).addTo(map);
|
|
});
|
|
|
|
afterEach(function () {
|
|
if (document.body.contains(c)) {
|
|
document.body.removeChild(c);
|
|
}
|
|
});
|
|
|
|
it("only adds a popup to the map when opened", function () {
|
|
marker.bindPopup("new layer");
|
|
expect(map.hasLayer(marker.getPopup())).to.be(false);
|
|
marker.openPopup();
|
|
expect(map.hasLayer(marker.getPopup())).to.be(true);
|
|
});
|
|
|
|
it("keeps an open popup on the map when it's unbound from the layer", function () {
|
|
marker.bindPopup("new layer").openPopup();
|
|
var popup = marker.getPopup();
|
|
marker.unbindPopup();
|
|
expect(map.hasLayer(popup)).to.be(true);
|
|
});
|
|
|
|
it("should not give an error when the marker has no popup", function () {
|
|
expect(function () {
|
|
marker.isPopupOpen();
|
|
}).to.not.throwException();
|
|
expect(marker.isPopupOpen()).to.be(false);
|
|
});
|
|
|
|
it("should show a popup as closed if it's never opened", function () {
|
|
marker.bindPopup("new layer");
|
|
expect(marker.isPopupOpen()).to.be(false);
|
|
});
|
|
|
|
it("should show a popup as opend if it's opened", function () {
|
|
marker.bindPopup("new layer").openPopup();
|
|
expect(marker.isPopupOpen()).to.be(true);
|
|
});
|
|
|
|
it("should show a popup as closed if it's opened and closed", function () {
|
|
marker.bindPopup("new layer").openPopup().closePopup();
|
|
expect(marker.isPopupOpen()).to.be(false);
|
|
});
|
|
|
|
it("should show the popup as closed if it's unbound", function () {
|
|
marker.bindPopup("new layer").openPopup().unbindPopup();
|
|
expect(function () {
|
|
marker.isPopupOpen();
|
|
}).to.not.throwException();
|
|
expect(marker.isPopupOpen()).to.be(false);
|
|
});
|
|
|
|
});
|