Commit Graph

22 Commits

Author SHA1 Message Date
Yohan Boniface
d8a6ad4010 Use proper Hand onStop callback instead of setTimeout in popup spec 2016-06-16 15:34:16 +02:00
Jon Woyame
878a022897 Prevent map click when layer has popup (#4603)
* prevent map click when layer has popup

* add test cases for click events on Paths

* update test for Path popups to check popup is open
2016-05-29 22:01:16 +02:00
Yohan Boniface
5795f37fe4 Make sure a failing test will not leave the node in place 2016-03-29 10:39:05 +02:00
Yohan Boniface
6bc6e599a0 Increase timeout for "should not be closen when dragging map" test 2016-03-29 10:38:47 +02:00
Yohan Boniface
61da775379 Replace happen.drag by prosthetic-hand in specs 2016-03-28 21:51:27 +02:00
Yohan Boniface
fd5411d74b Fix popup toggle on marker click (fix #3992)
Issue was:
- popup toggling is made on 'click' event
- map listen to 'preclick' to close any open popup
- at second user click, 'preclick' has been fired, then popup
  closed, so the popup toggling was reopening it
- this was not an issue before 0d3448d494
  because 'preclick' on the marker was not bubbled to the map
- also the unittest covering this use case was too much coupled with
  the use case with calling marker.fire instead of simulating user
  click on the marker icon
2015-11-14 20:41:53 +01:00
Vladimir Agafonkin
cfdbd10431 enforce indentation in specs 2015-09-25 13:55:37 +03:00
Vladimir Agafonkin
08d655fe66 upgrade deps and stricter eslint 2015-09-04 17:46:55 +02:00
Yohan Boniface
8d980ce49b Add a unittest to cover dragging map not closing open popup (cf #3632) 2015-07-16 17:01:44 +02:00
Patrick Arlt
f3c802c97c add test for new popup functionality 2015-03-28 19:20:56 -07:00
Patrick Arlt
52be81b18b Merge branch 'master' of github.com:Leaflet/Leaflet into popup-debugging 2015-03-14 10:22:25 -07:00
Yohan Boniface
250f03339b Fix popupAnchor not taken into account when passing L.Popup to bindPopup 2015-03-07 19:00:27 +01:00
Patrick Arlt
9186eade96 remove method checks from test 2015-01-11 08:31:41 -08:00
Patrick Arlt
ff8023a460 fix passing latlng to openPopup, fix build 2015-01-07 09:50:06 -08:00
Patrick Arlt
ef0ee1483d consistant failing test 2015-01-02 07:39:00 -08:00
Patrick Arlt
2d709141a8 fix tests, misc cleanup 2014-12-29 13:50:23 -08:00
John Firebaugh
bad49e7612 Add autoClose option to Popup
Fixes #2716
Fixes #1853
2014-11-12 12:52:50 -08:00
Vladimir Agafonkin
91c039b7aa jshinting and major clean up of specs code, ref #2151 2013-11-07 23:54:33 +02:00
Paul Bonaud
1af9769ed0 Toggle the display of a marker s popup on click 2013-06-16 22:13:31 +02:00
John Firebaugh
ade9c943ff Popup-specific closeOnClick option 2013-05-10 15:22:03 -07:00
Vladimir Agafonkin
7cb7993571 simplify popup methods, merge #738 2013-04-20 16:58:42 +03:00
Konstantin.Myakshin
b65e95f96b Trigger popupopen/close on markers too. 2012-06-18 22:35:54 +03:00