cartodb/Leaflet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,878 Commits 13 Branches 25 Tags 44 MiB
cfdbd10431
Commit Graph

3878 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
John Firebaugh
7b5168acec Ensure that added tiles are retained 
Previously, quickly zooming out and then back in sometimes left
only overzoomed tiles for the lower zoom level visible. The
problem was a race condition with deferred pruning:

1. Start at z15. Zoom in. This triggers loading of z14 tiles. As each
tile loads, _pruneTiles (throttled) is called. This results in deferred
removal of z15 tiles (250ms setTimeout). The deferral is done to avoid
flicker while the z14 tiles are faded in.
2. During the 250ms, zoom in. This triggers `_addTiles`, but since the
deferred pruning of the z15 tiles hasn't happened yet, the tiles are
still present in `this._tiles`. Therefore no tiles are queued for
loading, triggering an early return in `_addTiles`, before `_pruneTiles`
is called.
3. Deferred pruning of the z15 tiles happens. Since `_pruneTiles` was
short-circuited at z15, these tiles were never retained, nor were the
z14 tiles scheduled for pruning. End result is that the z15 tiles are
removed from the DOM while the z14 tiles remain, scaled 2x.
 2014-11-06 16:27:47 -08:00
John Firebaugh
78463e826b jshint 2014-11-06 16:27:47 -08:00
Vladimir Agafonkin
5f9321bac0 Merge pull request #3001 from snkashis/latlng_bounds_conversion 
extract bounds conversion from Map.Geolocation.Also fix geolocation test...
 2014-11-06 21:55:57 +02:00
Steve Kashishian
f3b132e414 extract bounds conversion from Map.Geolocation.Also fix geolocation test page. 2014-11-06 13:23:14 -06:00
Vladimir Agafonkin
f04581f39d Merge pull request #3000 from snkashis/popup_esc 
closes an open popup with escape key
 2014-11-06 21:21:03 +02:00
Steve Kashishian
1eae1719bb no map._popup check needed 2014-11-06 13:02:21 -06:00
Steve Kashishian
ead96e500e closes an open popup with escape key 2014-11-06 12:48:13 -06:00
Fabian Zeindl
4f06ac30b0 Don't append/remove the SVG container 
Tested this on IOS7, which has 85% adoption and I see no flicker.
Reduces layout and paint-times.
 2014-11-05 18:19:35 -08:00
Jeff Smale
c6dea37d86 Preserve marker draggability on setIcon (fixes #2578) 2014-11-05 18:12:21 -08:00
John Firebaugh
4825fc05b3 Add test for #1871 2014-11-05 15:44:23 -08:00
John Firebaugh
e6d857eb70 jshint 2014-11-05 15:22:49 -08:00
John Firebaugh
ea2c397523 No-op bringToFront/Back when Path is not on a map (fixes #2439) 2014-11-05 15:13:28 -08:00
Vladimir Agafonkin
40376dc3be simpler retina detection fallback, close #2258 2014-11-04 13:46:53 +02:00
Vladimir Agafonkin
f10512f836 fix map.fitBounds race condition, close #2957 
Fixes a situation where map.fitBounds(map.getBounds()) sometimes zoomed
out.
 2014-10-31 13:57:23 +02:00
Vladimir Agafonkin
d4354bc370 fix TileLayer tms option regression 2014-10-29 18:27:55 +02:00
Vladimir Agafonkin
36b958cad0 fix WMS passing all options as WMS params, close #2972 2014-10-29 18:22:28 +02:00
Vladimir Agafonkin
f75133a482 fix blurry map after stopping inertia, close #2979 2014-10-29 17:28:50 +02:00
Vladimir Agafonkin
bdc683d1c6 update package.json & deps 2014-10-29 17:20:55 +02:00
Vladimir Agafonkin
0c70dcb581 remove slow tests 2014-10-29 17:20:06 +02:00
Vladimir Agafonkin
11b39edfa1 fix TileLayer loading event after setUrl 2014-10-29 17:19:54 +02:00
Vladimir Agafonkin
9923e4bb91 Merge pull request #2977 from yohanboniface/geojson-edge-case 
Fix array of array of LatLngs toGeoJSON edge case
 2014-10-27 10:40:55 +02:00
Vladimir Agafonkin
34c8f9a941 Merge pull request #2976 from bb-generation/gridlayer-readd 
fixed GridLayer not showing up after removing and adding the same instance
 2014-10-27 09:10:32 +02:00
Yohan Boniface
1ddac9361a Fix array of array of LatLngs toGeoJSON edge case 2014-10-26 21:00:56 +01:00
Bernhard Eder
9707648550 fixed GridLayer not showing up after removing and adding the same instance 2014-10-26 15:45:15 +01:00
Vladimir Agafonkin
72707e3e30 fix GridLayer.redraw regression, close #2966 2014-10-23 14:27:05 +03:00
Vladimir Agafonkin
e2e1ccb2f0 fix 404 warnings in tests 2014-10-23 13:52:19 +03:00
Vladimir Agafonkin
eacc499199 fix GridLayer tile loading edge case 2014-10-23 13:23:37 +03:00
Vladimir Agafonkin
2ff2c42847 move some GridLayer tests, add createTile stub 2014-10-23 12:58:29 +03:00
Vladimir Agafonkin
875db28993 update deps 2014-10-23 12:37:29 +03:00
Vladimir Agafonkin
ced80bec00 Merge pull request #2963 from ogwiz2/patch-1 
Minor change in comments for better consistency
 2014-10-22 11:52:45 +03:00
Alex Jeng
2f6ce64cc4 Minor change in comments for better consistency 2014-10-21 23:22:11 -07:00
Patrick Arlt
1f203fda69 Merge pull request #2962 from sheppard/patch-1 
update AMD recommendation in plugin guide
 2014-10-21 16:15:15 -07:00
S. Andrew Sheppard
64f904dd0e simplify AMD definition 2014-10-21 12:32:06 -05:00
Vladimir Agafonkin
d93e828935 stop panning/fly animations when necessary 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
23998c1f9c ditch transition stopping code 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
70923e6604 rename zoomPanTo to flyTo 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
7a75d07d89 update inertia settings 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
468e195ba1 rename PosAnimation.Timer to PosAnimation 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
a33eff73f0 replace CSS transitions in pan animations with frames 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
66c13bc94c fix tile loading regression after rebase 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
8b26a7399a fix build and cleanup tile pruning 2014-10-21 12:21:32 +03:00
Vladimir Agafonkin
a4e8f4e1a8 improve tile pruning 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
ad0cf365e7 fix world wrapping 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
44f16b2d9e much better tile pruning; add coords to tile events, ref #2378 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
fbe23087fa add prune lower res tiles algorithm 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
b0ce42f270 minor tile code cleanup 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
9b752757ef more flexible tile remove method 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
683cc4534c cleanup tile removal, make unloadInvisibleTiles work again 2014-10-21 12:21:31 +03:00
Vladimir Agafonkin
29a0eaef0f include zoom in tile coords, simplify parsing tile keys 2014-10-21 12:21:31 +03:00
Tom MacWright
fefe4b78eb Initialize tilesToLoad variable on GridLayer creation 2014-10-21 12:21:31 +03:00