Iván Sánchez Ortega
8cb745ce0a
L.Evented.listens() returns false on removed event handlers, #4474 ( #4476 )
...
* Fix L.Evented.listens() on removed event handlers, #4474
* Fix bad unit tests for marker events
* Only check for listerners.length if listerners is actually defined
2016-07-01 11:14:22 +02:00
Per Liedman
fbc6265fb7
Fix when all listeners are removed during dispatch ( #4555 )
...
Close #4478 .
2016-05-12 10:22:36 +02:00
Jan Pieter Waagmeester
37254587be
Allow dashes in template placeholders + tests
2016-03-21 14:36:21 +01:00
Iván Sánchez Ortega
ccd95e38e6
L.Class.include & mergeOptions now return 'this'
2016-02-15 16:38:35 +01:00
Vladimir Agafonkin
8c8d0ac7ee
fix whitespace in comments
2015-09-25 15:37:07 +03:00
Vladimir Agafonkin
cfdbd10431
enforce indentation in specs
2015-09-25 13:55:37 +03:00
Asko Kauppi
f61a681c56
fix 'jake'
2015-03-01 22:51:04 +02:00
Vladimir Agafonkin
d145b1fdba
fix a bunch of eslint warnings in the spec suite
2015-01-28 19:32:27 +02:00
John Firebaugh
ef96884021
Ensure parent init hooks are called ( fixes #2545 )
2014-11-12 14:49:46 -08:00
Vladimir Agafonkin
47783821f7
rename limitExecByInterval to throttle, better implementation
2013-12-21 01:49:25 -05:00
Vladimir Agafonkin
1dfec0a021
shortcut hasEventListeners as listens
2013-12-19 17:09:32 -05:00
Vladimir Agafonkin
6d1142a978
only propagate events if given true to fire, #2311
2013-12-18 23:23:22 -05:00
Vladimir Agafonkin
ce4a031d40
faster on/off, add private non-sugary versions
2013-12-18 23:07:39 -05:00
Vladimir Agafonkin
9f09f50812
remove Util invokeEach since on/off are hot functions
2013-12-18 22:05:47 -05:00
Vladimir Agafonkin
21cfd7f3d9
replace Events mixin with Evented inheritance
2013-12-17 14:07:21 -05:00
John Firebaugh
ad9d0f8c7f
Make options object prototype-inherited
...
Fixes #2294
2013-12-15 13:30:30 -08:00
Vladimir Agafonkin
88f21d01af
better bind, use native fn.bind if available
2013-12-02 19:16:00 +02:00
Calvin Metcalf
4a0beebde3
Revert "' #1968 compiled interpolation'"
2013-11-20 15:42:06 -05:00
Vladimir Agafonkin
91c039b7aa
jshinting and major clean up of specs code, ref #2151
2013-11-07 23:54:33 +02:00
Vladimir Agafonkin
77bd10c69d
Merge pull request #2149 from danzel/ios7-2122
...
Work around iOS7 memory trouble
2013-11-04 13:33:54 -08:00
danzel
fa35aba1e9
Improve this test and fix removeEventListener.
2013-11-05 10:29:52 +13:00
danzel
579c044c00
Fix a potential event bug due to bad cleanup.
2013-11-05 10:21:32 +13:00
Vladimir Agafonkin
ec7baabccf
merge runner cleanup #2134
2013-11-04 13:18:24 +02:00
danzel
9fce697982
Work around iOS7 memory trouble by not applying the contextId performance optimization when context==this. The optimization does nothing in this case anyway. Fixes #2122
2013-11-04 09:47:55 +13:00
Jan Pieter Waagmeester
99bd248566
Whitespace OCD
2013-10-29 11:49:09 +01:00
Jan Pieter Waagmeester
a7f2d1975f
Allow double quotes in template strings fixes #2120
2013-10-23 15:14:59 +02:00
Vladimir Agafonkin
361c9cab6d
fix isArray not working IE9 in rare cases, close #2077
2013-10-08 16:59:42 +03:00
Vladimir Agafonkin
21d8bde0b7
fix tempate interpolation test and build
2013-08-27 22:06:01 +03:00
Calvin Metcalf
b2b25c8941
' #1968 compiled interpolation'
2013-08-27 13:03:07 -04:00
Vladimir Agafonkin
0849d06c1b
fix whitespace in event spec, #1661
2013-05-08 12:58:50 +03:00
R. Merkert
bbb7acb3f4
Make sure events don't fire after listener is removed.
...
This patch fixes a problem with a dangling event listener, which is
called even after it has been removed. This situation can occur when a
listener is removed during an even dispatch.
To fix this problem, the old action is replaced with a NOOP, so that
when the listener is being fired, it is not the old listener but the
NOOP.
2013-05-07 20:16:25 -04:00
Daan Mortier
c6620859e4
Updated patch for issue #1631 based on feedback
2013-04-29 13:03:05 +02:00
Daan Mortier
52498f1ef9
Issue #1631 : Fixed a bug on removeEventListener
...
Bugfix for issue #1631 where removeEventListener would throw when no event listeners are registered on the object.
2013-04-29 11:53:16 +02:00
Vladimir Agafonkin
5647f37ae6
cleanup and merge #1596 , adds Events#once
2013-04-19 17:23:45 +03:00
Vladimir Agafonkin
a5e8bc0f49
add Util.invokeEach for hash arguments in event methods
2013-04-19 17:23:14 +03:00
iirvine
84ad7db070
clearEventListeners -> clearAllListeners
2013-04-15 14:09:32 -07:00
iirvine
2d5bf783fe
initial commit of #clearEventListeners
2013-04-15 14:09:32 -07:00
iirvine
031086681f
fix our context to the object that's registering this listener
2013-04-14 20:49:57 -07:00
iirvine
a469a387a1
back to first implementation to fix event leak
2013-04-13 22:11:01 -07:00
iirvine
e25f730b04
better implementation, more tests
2013-04-12 17:03:14 -07:00
iirvine
e41e8a886a
initial implementation of events#once
2013-04-12 15:21:48 -07:00
John Firebaugh
81f21125d4
Update specs for mocha
2013-04-03 15:22:45 -07:00
Tom MacWright
a2f7d7e834
Use mocha
2013-04-03 14:50:09 -07:00
danzel
9d4d894450
Add another events test and fix from @iirvine
2013-03-15 13:53:03 +13:00
danzel
44cbed0b5e
Replace the FeatureGroup test with a better one in events, this one currently fails
2013-03-13 10:08:04 +13:00
John Firebaugh
01332ebead
Omit "should" in spec descriptions
...
The rationale is this: the spec string describes the expected
behavior unconditionally. The code examples, on the other hand,
set up an expectation that is tested with the call to the expect
method. The code examples can violate the expectation, but the
spec string does not. The value of the spec string is as clearly
as possible describing the behavior. Including “should” in that
description adds no value. (From http://rubyspec.org/style_guide/ )
2013-02-19 12:41:48 -08:00
Tom MacWright
0a2000166a
Fix semicolons, breaking, whitespace, duplicate var statements.
2013-02-19 11:18:15 -05:00
Tom MacWright
eae5758ff4
Split template tests into logic groups, test for template without
...
tokens.
2013-02-15 17:38:11 -05:00
Vladimir Agafonkin
ed8dc9f4cd
improve core specs #1347
2013-02-04 18:31:14 +02:00
snkashis
6b4f5c4cf7
handling no existingUrl scenario
2012-12-27 14:39:19 -05:00