Commit Graph

49 Commits

Author SHA1 Message Date
louMoxy
3e8e76c790 Fix race condition when removing canvas before it has rendered (#6033)
Fixes #6030: Cancel animation frame request before removing the map.
This fixes the bug where the the delayed call to _redraw is trying to get the drawing context which has already been destroyed.
2018-01-29 15:36:50 +01:00
Martin Palmér
1d8cc53408 #5921 Remove touch based click tolerance (#5922) 2017-11-17 14:36:23 +01:00
Per Liedman
a9742e0d4b Round circle radius in renderer instead of layer
Makes bounds calculation more precise and zoom level independant.
Fixes #4582.
2017-10-20 14:51:48 +02:00
Vladimir Agafonkin
88dd22cfe8 upgrade deps, fix indenting (#5743) 2017-08-31 08:58:42 +02:00
Yohan Boniface
b675753422 Make L.LineUtil._flat public as L.LineUtil.isFlat (#5667)
Also, keep retrocompat for both L.LineUtil._flat and
L.Polyline._flat (<1.1).
2017-07-29 23:47:17 +02:00
Vladimir Agafonkin
703ae02aa8 ES6 modules & Rollup (#4989)
* WIP ES6 modules & rollup

* WIP ES6 modules & rollup 2

* WIP ES6 modules & rollup 3

* WIP ES6 modules Browser

* WIP ES6 module fixes

* WIP ES6 modules: simpler browser exports

* WIP ES6: refactor CRS/Projection modules, CRS obj -> CRS.Base

* get rid of unnecessary index.js

* WIP ES6 modules, dom events and stuff

* Make linter happy, rollup to dist/

* revert to CRS namespace/class for now

* WIP rollup: export more stuff

* export controls

* rollup: export Layer

* rollup: export DomEvent

* rollup: export more layer types

* rollup: export Popup/Tooltip

* WIP: ES6-ify marker, icon, domutil, draggable.

* ES6-ify gridlayer, tilelayer.

* ES6-ify: Tweak imports-exports, code is now runnable!!

* ES6-ify: Fix scope in some DomUtils

* ES6-ify: Path, fix Popup

* ES6-ify: Lint & cleanup

* ES6-ify map handlers, more linting

* ES6-ify: Icon.Default namespacing

* ES6-ify: Renderers, CircleMarker

* ES6-ify: Circle, Polyline, LineUtil

* ES6-ify: Polygon, Rectangle, LineUtil, PolyUtil, linting

* ES6-ify: SVG.VML

* ES6-ify: DomEvent.Pointer, DomEvent.DoubleTap

* ES6-ify: Linting, make Karma play nice with Rollup

* ES6-ify: More work on fixing bits breaking some unit tests.

* ES6-ify: rollup the version number, fiddled with build scripts

* ES6-ify: Fiddle with test scripts

* ES6-ify: cleanup (refs to global L, imports from (DOM)Util), prevent cyclic loop on Map imports

* ES6-ify: More cleanup of (DOM)Util/Browser/DomEvent imports

* ES6ify: Use rollup's "legacy" option for ES3 (IE8) builds

* ES6-ify: Clean up build scripts, fix CONTRIBUTING.md instructions

* Typo

* ES6-ify: minor fixes and lefovers after rebasing on top of 1.0.2

* ES6-ify: upgrade to rollup 0.38 for proper IE8 builds, fix L.SVG.VML

* Make linter happy.

* ES6: Fixing typos and sxrew-ups after big rebase

* Fix symlink for debugging scripts

* ES6: Cleanup old build scripts

* ES6-ify: Update build system to include git rev in L.version

* ES6-ify: re-enable unit tests replacing L.Path with L.Polyline

* Export Path

* ES6ify: cleanup old banner file

* ES6-ify: whitespace in var declarations

* ES6-ify: Export toTransformation as L.transformation

* ES6-ify: cleanup L.transform exports

* ES6-ify: "import Util" in Transformation and SVG.VML
2017-01-30 11:35:16 +01:00
ghybs
34dca3cfd9 Fix #5011 (canvas remove+add) (#5024)
Bug when using map option `preferCanvas: true` (canvas renderer for paths) and removing then adding back a vector within the same animation frame (typically in the same sequence, as done by Leaflet.markercluster at `"zoomend"` event, to remove layers and clusters outside visible bounds).
This commit clears the `_removed` flag from paths when they are added to the canvas.
Also added corresponding test suites.
2016-10-20 15:50:15 +03:00
Per Liedman
ed1a612e6f Make paths insensitive to the order of its map's moveend handlers (#4855)
* Make Paths always update after renderer updates

Close #4851

* Add test

* Add docs for update event

* Remove listener when layer is removed
2016-08-31 17:58:46 +03:00
Steve
92baa9c73f Throw error on call to L.Polygon getCenter before map add (#4820)
* Throw error on call to L.Polygon getCenter before map add

References #4740

* add polyline handling, tests, and docstring
2016-08-15 17:01:41 +02:00
Yohan Boniface
95d5b59c5f Fix canvas not filtering click event after drag (#4493)
* Fix preclick not fired in canvas
* Do not add canvas layers to click event targets if just dragged (fix #4458)
2016-06-01 17:43:32 +03:00
Jon Woyame
878a022897 Prevent map click when layer has popup (#4603)
* prevent map click when layer has popup

* add test cases for click events on Paths

* update test for Path popups to check popup is open
2016-05-29 22:01:16 +02:00
Per Liedman
593a553e64 Pass layer on when calling _updateDashArray
Add specs to verify intialization and setStyle with dashArray.
Close #4401.
2016-04-08 16:43:21 +02:00
Knut Hühne
df19ec7c30 Add test for throwing error if circle radius is NaN 2016-02-15 11:51:27 +01:00
Yohan Boniface
d901a5fc07 Fix interactive=false not taken into account for canvas (fix #3946) 2015-10-19 21:39:04 +02:00
Vladimir Agafonkin
8a5184193e Merge pull request #3917 from Leaflet/canvas-stop-event
Canvas events fixes (fix #3915)
2015-10-10 21:24:37 +03:00
Yohan Boniface
6c3b9e10b8 Fix L.Circle init without options.radius 2015-10-09 20:24:42 +02:00
Yohan Boniface
0b0989f9f1 Canvas events fixes (fix #3915)
- fix fireEvent called for each layer containing event point
- fix layer not removed from this._layer at remove
- fix L.DomEvent.stop(e) not honoured for canvas because events
  are both listenned on canvas container and map container
2015-10-09 18:28:35 +02:00
Vladimir Agafonkin
cfdbd10431 enforce indentation in specs 2015-09-25 13:55:37 +03:00
Iván Sánchez Ortega
3924d49bcd Consistency between L.circle and L.circleMarker (#3785) 2015-09-17 23:22:55 +09:00
Yohan Boniface
298a27fbe4 Add Polyline/Polygon.isEmpty method 2015-05-09 23:03:22 +02:00
Yohan Boniface
426f331874 Fix polygon.addTo(map) failing when latlngs was empty.
Since #3279 an empty polygon as a nested array [[]] as latlngs,
so _latlngs.length returns true.
2015-05-09 22:04:46 +02:00
Yohan Boniface
6aca7ef3c2 Add back L.Polyline.addLatLng 2015-05-08 14:53:21 +02:00
Yohan Boniface
2408cf2bb6 _flat is now a static method 2015-05-08 13:11:58 +02:00
Yohan Boniface
8b97b905e8 Merge branch 'master' into nested-polygons 2015-05-08 13:10:49 +02:00
Yohan Boniface
19d6008dfc Make L.Polyline._flat a static method 2015-05-08 11:52:00 +02:00
Yohan Boniface
8938754bd5 Merge branch 'master' into nested-polygons
Conflicts:
	spec/suites/layer/vector/PolygonSpec.js
2015-04-21 15:57:24 +02:00
Yohan Boniface
003e94ae11 Fix L.Polyline._flat returning true for a nested empty array 2015-04-18 17:41:36 +02:00
Yohan Boniface
3336bcbbe9 Fix Polygon.getCenter returning invalid LatLng when all points in same pixel 2015-04-12 18:43:04 +02:00
Yohan Boniface
a82c80ecd9 Fix Polyline.getCenter returning undefined with very small line 2015-04-12 11:25:46 +02:00
Yohan Boniface
19033957d7 A few more tests on Polyline and Polygon (cf #3279) 2015-03-06 09:14:00 +01:00
Yohan Boniface
0d0269ac15 Remove Polyline.addLatLng and Polyline.spliceLatLngs
Those method are not consistent (or too complexe) among
the supported Polygon/Polyline (cf #3279)
2015-03-06 09:05:50 +01:00
Yohan Boniface
602cff077f Ensure polygons latlngs are never flat (cf #2648) 2015-03-04 18:14:51 +01:00
Vladimir Agafonkin
d145b1fdba fix a bunch of eslint warnings in the spec suite 2015-01-28 19:32:27 +02:00
John Firebaugh
e6d857eb70 jshint 2014-11-05 15:22:49 -08:00
John Firebaugh
ea2c397523 No-op bringToFront/Back when Path is not on a map (fixes #2439) 2014-11-05 15:13:28 -08:00
Vladimir Agafonkin
dab0cbfc14 update tests to reflect no clamping near poles 2014-01-03 17:37:28 +02:00
Vladimir Agafonkin
7ff0fa9c72 approximate Circle with ellipse 2014-01-03 00:37:34 +02:00
Vladimir Agafonkin
33e23a69e7 fix specs for polygon holes 2013-12-18 12:03:22 -05:00
Vladimir Agafonkin
91c039b7aa jshinting and major clean up of specs code, ref #2151 2013-11-07 23:54:33 +02:00
Alexander Parshin
f5de36e229 Add holes support to L.Polygon.setLatLngs(). Fixes #1518 2013-10-13 20:17:12 +04:00
John Firebaugh
475e736346 Revert "Consistent mouse event propagation in Marker and Path"
This reverts commit 4015f49615.
2013-06-28 16:22:20 -04:00
John Firebaugh
4015f49615 Consistent mouse event propagation in Marker and Path
Marker was missing mouseup and mousemove.
Path was missing mouseup.
2013-06-28 14:44:10 -04:00
John Firebaugh
c9e2453eed Bounds-check array access in Polygon#initialize 2013-05-02 16:17:04 -07:00
Tom MacWright
a2f7d7e834 Use mocha 2013-04-03 14:50:09 -07:00
danzel
5873914062 Start on some Polyline/Polygon tests. 2013-02-20 11:03:37 +13:00
John Firebaugh
01332ebead Omit "should" in spec descriptions
The rationale is this: the spec string describes the expected
behavior unconditionally. The code examples, on the other hand,
set up an expectation that is tested with the call to the expect
method. The code examples can violate the expectation, but the
spec string does not. The value of the spec string is as clearly
as possible describing the behavior. Including “should” in that
description adds no value. (From http://rubyspec.org/style_guide/)
2013-02-19 12:41:48 -08:00
danzel
0390a86e7f More CircleMarker tests, move them where they should be. 2013-02-04 09:49:37 +13:00
Vladimir Agafonkin
cca3180f30 fix Circle getBounds, closes #1068 2012-10-15 11:39:07 +03:00
Andrey Rublev
263a5b9b5f Add method Polyline.closestLayerPoint
Also fix method L.LineUtil.simplify for empty geometry
2011-07-20 13:23:04 +07:00