cartodb/Leaflet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,290 Commits 13 Branches 25 Tags 44 MiB
35e2131aab
Commit Graph

252 Commits

Author SHA1 Message Date
R. Merkert
bbb7acb3f4 Make sure events don't fire after listener is removed. 
This patch fixes a problem with a dangling  event listener, which is
called even after it has been removed. This situation can occur when a
listener is removed during an even dispatch.

To fix this problem, the old action is replaced with a NOOP, so that
when the listener is being fired, it is not the old listener but the
NOOP.
 2013-05-07 20:16:25 -04:00
John Firebaugh
c9e2453eed Bounds-check array access in Polygon#initialize 2013-05-02 16:17:04 -07:00
Daan Mortier
c6620859e4 Updated patch for issue #1631 based on feedback 2013-04-29 13:03:05 +02:00
Daan Mortier
52498f1ef9 Issue #1631: Fixed a bug on removeEventListener 
Bugfix for issue #1631 where removeEventListener would throw when no event listeners are registered on the object.
 2013-04-29 11:53:16 +02:00
Vladimir Agafonkin
7cb7993571 simplify popup methods, merge #738 2013-04-20 16:58:42 +03:00
Vladimir Agafonkin
412f047533 Merge pull request #1462 from jfirebaugh/toGeoJSON 
Add #toGeoJSON to various layer types (#712)
 2013-04-19 09:55:40 -07:00
Vladimir Agafonkin
5647f37ae6 cleanup and merge #1596, adds Events#once 2013-04-19 17:23:45 +03:00
Vladimir Agafonkin
a5e8bc0f49 add Util.invokeEach for hash arguments in event methods 2013-04-19 17:23:14 +03:00
iirvine
84ad7db070 clearEventListeners -> clearAllListeners 2013-04-15 14:09:32 -07:00
iirvine
2d5bf783fe initial commit of #clearEventListeners 2013-04-15 14:09:32 -07:00
iirvine
031086681f fix our context to the object that's registering this listener 2013-04-14 20:49:57 -07:00
iirvine
a469a387a1 back to first implementation to fix event leak 2013-04-13 22:11:01 -07:00
iirvine
e25f730b04 better implementation, more tests 2013-04-12 17:03:14 -07:00
iirvine
e41e8a886a initial implementation of events#once 2013-04-12 15:21:48 -07:00
Tom MacWright
22810aacf7 Throw an exception if a map div is not found 
and test for initialization exceptions
 2013-04-08 12:28:27 -04:00
Vladimir Agafonkin
6009d4ae87 move phantomjs check for touch into Leaflet 
to allow standalone mocha-phantomjs usage on the browser reporter
 2013-04-05 12:32:19 +03:00
John Firebaugh
0e9b7249d8 Convert to expect.js assertions 2013-04-04 09:47:45 -07:00
John Firebaugh
55edd44678 Add #toGeoJSON to various layer types (#712) 2013-04-04 09:46:18 -07:00
John Firebaugh
81f21125d4 Update specs for mocha 2013-04-03 15:22:45 -07:00
John Firebaugh
a950e6873e Manage mocha dependency with npm; update to 1.9.0 2013-04-03 15:20:15 -07:00
John Firebaugh
a8ca5a2dbf Update mocha.js 2013-04-03 14:50:10 -07:00
Tom MacWright
8691889d49 Proper default for delta 2013-04-03 14:50:10 -07:00
Tom MacWright
bf99fdb70e Tighter tolerance for point-near check 2013-04-03 14:50:10 -07:00
Tom MacWright
a3ab4b1095 Fix mercator tests, these are broken in Leaflet master. 2013-04-03 14:50:10 -07:00
Tom MacWright
a2f7d7e834 Use mocha 2013-04-03 14:50:09 -07:00
John Firebaugh
28daa9e9b1 testacular -> karma 2013-04-03 14:12:51 -07:00
danzel
9d4d894450 Add another events test and fix from @iirvine 2013-03-15 13:53:03 +13:00
danzel
44cbed0b5e Replace the FeatureGroup test with a better one in events, this one currently fails 2013-03-13 10:08:04 +13:00
danzel
e2a852639a Add failing test case for #1495 from @iirvine 2013-03-12 17:24:46 +13:00
danzel
9300c58262 Fix copy/paste bug 2013-03-12 17:12:06 +13:00
Tom MacWright
71d17180c8 Add layerGroup#getLayers and tests. Fixes #1460 2013-02-27 17:10:19 -05:00
John Firebaugh
511fbb9f44 Add Map#eachLayer (fixes #1457) 2013-02-26 11:39:00 -08:00
John Firebaugh
bee90ce0e5 Fix whitespace 2013-02-26 11:31:23 -08:00
Vladimir Agafonkin
9c2e7cfbd4 add Point contains method 2013-02-22 17:28:55 +02:00
John Firebaugh
46dddc895c Fire an unload event on removal 
Plugins that need to bind events to `window` or `document`
can attach a listener for this event and unbind their event
handlers.

However, for symmetry, unload is fired only if load has been
fired.
 2013-02-21 17:31:09 -08:00
Vladimir Agafonkin
9c9d4286a1 Merge pull request #1439 from danzel/convert_option 
Make Polyline/Polygon not overwrite the source array
 2013-02-21 00:08:48 -08:00
Vladimir Agafonkin
501b179bbd fix 404 error in TileLayer tests 2013-02-20 21:22:47 +02:00
Vladimir Agafonkin
3063fd9192 Merge pull request #1433 from tmcw/layer-container 
Add a public API for getContainer for TileLayer
 2013-02-20 09:48:19 -08:00
John Firebaugh
fb9450f975 Force touch support off for PhantomJS 
PhantomJS has `'ontouchstart' in document.documentElement`, but
doesn't actually support touch.

http://code.google.com/p/phantomjs/issues/detail?id=375
https://github.com/ariya/phantomjs/pull/408
https://github.com/Leaflet/Leaflet/pull/1434#issuecomment-13843151
 2013-02-20 09:17:06 -08:00
Tom MacWright
d8fccfb3dc Spacing. 2013-02-19 21:15:36 -05:00
John Firebaugh
6ef25866eb Add Map#remove 
This is a minimal implementation; it only unbinds events
and deletes the _leaflet flag from the container.

Refs #1101.
 2013-02-19 17:36:03 -08:00
Tom MacWright
8735b87980 Add public getContainer API to TileLayer, and test for it. 2013-02-19 20:05:44 -05:00
danzel
5873914062 Start on some Polyline/Polygon tests. 2013-02-20 11:03:37 +13:00
Vladimir Agafonkin
0b14d71d7a Merge pull request #1427 from jfirebaugh/should 
Omit "should" in spec descriptions
 2013-02-19 12:54:33 -08:00
Dave Leaver
db2352ae9b Merge pull request #1424 from tmcw/use-tobe 
Use tobe instead of testing the result of an equality
 2013-02-19 12:49:04 -08:00
John Firebaugh
01332ebead Omit "should" in spec descriptions 
The rationale is this: the spec string describes the expected
behavior unconditionally. The code examples, on the other hand,
set up an expectation that is tested with the call to the expect
method. The code examples can violate the expectation, but the
spec string does not. The value of the spec string is as clearly
as possible describing the behavior. Including “should” in that
description adds no value. (From http://rubyspec.org/style_guide/)
 2013-02-19 12:41:48 -08:00
Tom MacWright
a324759268 Use tobe instead of testing the result of an equality 2013-02-19 14:21:06 -05:00
Vladimir Agafonkin
b84b83bf93 fix setView test, #1420 2013-02-19 19:25:49 +02:00
Tom MacWright
1b03d5d0b4 Test setView. The setTimeout can be removed when #1420 is fixed. 2013-02-19 11:53:42 -05:00
Vladimir Agafonkin
8e176f48aa Merge pull request #1419 from tmcw/test-jshint 
Fix semicolons, breaking, whitespace, duplicate var statements.
 2013-02-19 08:25:51 -08:00
Vladimir Agafonkin
aea0e3b05b fix browser test runner, close #1418 2013-02-19 18:21:01 +02:00
Tom MacWright
0a2000166a Fix semicolons, breaking, whitespace, duplicate var statements. 2013-02-19 11:18:15 -05:00
Vladimir Agafonkin
a0dd4a60e9 accept coordinates in form of simple objects, close #1412 2013-02-19 18:01:53 +02:00
Vladimir Agafonkin
5d41efe616 fix removeAttrubution, cover the control with tests, close #1410 2013-02-19 17:47:38 +02:00
Vladimir Agafonkin
d98b4ea035 throw meaningful exception on getCenter before setView, close #1395 2013-02-19 16:54:29 +02:00
Tom MacWright
eae5758ff4 Split template tests into logic groups, test for template without 
tokens.
 2013-02-15 17:38:11 -05:00
Mattias Bengtsson
3a834d35cd Add tests for the zoomlevelschanged-event. 2013-02-14 03:07:32 +01:00
danzel
513c6ca4cd Change _propagateEvent to be careful that it doesn't overwrite e.layer if it is already set. Allows markers to be in multiple FeatureGroups and have the events come through correctly. See the test for details. 
Fixes Leaflet.markercluster#128 ( https://github.com/Leaflet/Leaflet.markercluster/issues/128 )
 2013-02-08 14:44:28 +13:00
Vladimir Agafonkin
c327fa89ee add a couple of DomUtil tests, #1347 2013-02-05 17:01:01 +02:00
Vladimir Agafonkin
f01e32d764 fix specs sometimes failing 2013-02-05 17:00:38 +02:00
Vladimir Agafonkin
5e05068478 complete LatLng and LatLngBounds tests, #1347 2013-02-05 15:21:40 +02:00
Vladimir Agafonkin
17cf297c9b complete geometry tests to 100% #1347 2013-02-05 13:51:27 +02:00
Vladimir Agafonkin
ed8dc9f4cd improve core specs #1347 2013-02-04 18:31:14 +02:00
Vladimir Agafonkin
297d746a46 make test task less verbose 2013-02-04 14:30:49 +02:00
Vladimir Agafonkin
86cfce1771 merge #1340, fix whitespace 2013-02-04 13:42:27 +02:00
Vladimir Agafonkin
80f107cba3 Merge pull request #1318 from yohanboniface/add_lbrt_getters 
Add LatLngBounds.getLeft/getBottom/getRight/getTop
 2013-02-04 02:45:06 -08:00
danzel
0390a86e7f More CircleMarker tests, move them where they should be. 2013-02-04 09:49:37 +13:00
danzel
b905708f24 Test cases for #1297 circleMarker setRadius issue. 2013-02-03 15:34:32 +13:00
Eldar Djafarov
e4492b6f10 Fix: SpecHelper should be first 2013-02-02 10:59:30 -02:00
Eldar Djafarov
2da36a2851 test coverage initial commit 2013-02-02 05:29:20 -02:00
Vladimir Agafonkin
2ebe67f110 cleanup testacular config 2013-01-31 15:44:55 +02:00
Vladimir Agafonkin
687246128c update Jasmine to 1.3.1 2013-01-31 14:31:53 +02:00
Eldar Djafarov
82b327d9f5 use global deps file instead of ustom list 2013-01-30 18:01:32 -02:00
Eldar Djafarov
c8c19d3b6f Make getFiles more consistent 2013-01-30 16:48:22 -02:00
Eldar Djafarov
c4b8139ee8 fix code style 2013-01-30 16:41:13 -02:00
Eldar Djafarov
7e537eb954 enable testacular runner 2013-01-30 12:06:19 -02:00
Yohan Boniface
4f59140253 Eat our own food 2013-01-28 01:09:26 +01:00
Yohan Boniface
4b5746ffbc Use getWest/South/East/North instead of getLeft/Bottom/Right/Top 2013-01-28 01:04:09 +01:00
Yohan Boniface
69b925b057 Add LatLngBounds.getLeft/getBottom/getRight/getTop 2013-01-27 12:12:02 +01:00
Eldar Djafarov
e1a3e97349 testacular port 2013-01-20 05:04:06 -02:00
snkashis
6b4f5c4cf7 handling no existingUrl scenario 2012-12-27 14:39:19 -05:00
snkashis
3d416f38e1 whitespace for hash 2012-12-26 11:45:38 -05:00
Steve
3208db476c Semicolons in spec 2012-12-22 23:52:25 -05:00
snkashis
8c7c06431a handle existing query strings for WMS urls , #973 2012-12-22 17:47:38 -05:00
jacobtoye
c40878365d Fixing addInitHooks specs to test inherited hooks and child class' hooks. 2012-12-19 15:36:42 +13:00
Vladimir Agafonkin
782e8e7dcf implement hooks for Class constructors (AOP-style), close #1123 2012-12-12 12:26:33 +02:00
Vladimir Agafonkin
8350bb1e08 update LatLng specs after removing default clamping/wrapping 2012-12-12 12:04:54 +02:00
Mattias Bengtsson
5fa8dfa5a5 Add test for ensuring maxZoom and minZoom on the map overrides any layer settings. 2012-12-12 00:45:19 +01:00
Mattias Bengtsson
e475c04eaa Add a missing semi colon and make one line < 80 chars 2012-12-12 00:45:09 +01:00
Vladimir Agafonkin
0c5f401220 Merge pull request #1159 from moonlite/master 
First stab at a fix for Issue 623
 2012-11-29 06:44:25 -08:00
Mattias Bengtsson
593fa82fe8 Stupid typo 2012-11-29 08:10:04 +01:00
Mattias Bengtsson
2fd70b3bb7 Wrap the last test in a map.whenReady to ensure the map has finished loading 
before removeLayer is called.
 2012-11-29 08:05:08 +01:00
Tom Hughes
0b2a31c1fe Update the Layers control when layers are added or removed 2012-11-24 00:33:57 +00:00
Mattias Bengtsson
c0135a219d Added a bunch of tests and fixed some bugs those exposed. 
Also don't try to automatically adjust zoom. Leave that to the
layer control for now and wait for a setBaseLayer / switchLayer
or something instead.
 2012-11-19 04:36:13 +01:00
Pascal Borreli
9546599520 Fixed typos 2012-11-09 23:15:48 +00:00
Vladimir Agafonkin
cca3180f30 fix Circle getBounds, closes #1068 2012-10-15 11:39:07 +03:00
John Firebaugh
0b4d2b0c44 Add Map#whenReady 
Fixes #1063
 2012-10-12 12:54:13 -07:00
John Firebaugh
5ee7113fe4 Add a baselayerchange event 2012-10-12 12:19:21 -07:00
John Firebaugh
2cca6586dc Test the right class 2012-10-11 08:54:04 -07:00
John Firebaugh
fbf91fef54 Ensure that getBounds can be called during the first moveend event 
Fixes #1027
 2012-10-04 14:02:46 -07:00
Dominik Moritz
f8d6e7052e Implemented isValid() function for Bounds and LatLngBounds. Fixes issue #966. Added specification. 2012-09-11 12:43:16 +01:00
Vladimir Agafonkin
382ef5c0b2 spec cleanup 2012-07-05 12:54:40 +03:00
mourner
fe198ce9e4 Merge branch 'master' of https://github.com/Guiswa/Leaflet into better-events 2012-06-30 13:16:51 +03:00
mourner
2f25c36222 update jasmine to 1.2.0 2012-06-30 13:13:02 +03:00
Aaron King
95ed9cdda2 Allow L.Mixin.Events.addEventListener() to accept a map in which the string keys represent one or more space-separated event types and the values represent a handler function to be called for the event(s). 
Allow L.Mixin.Events.removeEventListener() to accept one or more space-separated event types. Omitting the fn parameter will remove all event handlers for the supplied event type(s).

Also allow L.Mixin.Events.removeEventListener() to accept a map where the string keys represent one or more space-separated event types and the values represent handler functions previously attached for the event(s).

Add unit tests for the above changes.
 2012-06-29 16:14:41 -07:00
danzel
61ce465134 Fix up the unit tests. Polyline.closestLayerPoint and noConflict were broken. 2012-06-25 12:16:46 +12:00
Konstantin.Myakshin
b65e95f96b Trigger popupopen/close on markers too. 2012-06-18 22:35:54 +03:00
mourner
b333f86e1d fix superclass regression 2012-03-09 11:28:14 +02:00
mourner
24375fe88d more cleanup 2012-02-25 18:57:28 +02:00
Alex Graul
57f44bc423 fix issue with 180 longs being clamped to -180 2011-12-21 13:22:07 +00:00
Vladimir Agafonkin
c726d6f3cb Merge pull request #189 from anru/domutil 
Add L.DomUtil.removeClass method
 2011-07-20 04:27:12 -07:00
Andrey Rublev
263a5b9b5f Add method Polyline.closestLayerPoint 
Also fix method L.LineUtil.simplify for empty geometry
 2011-07-20 13:23:04 +07:00
Andrey Rublev
b27922ea2c Add L.DomUtil.removeClass method 2011-07-15 19:03:35 +07:00
Andrey Rublev
9479911e69 Fix Bounds.contains method in case if obj argument is instance of L.Point 2011-07-13 18:13:35 +07:00
Mourner
e9b8353198 more Class specs to test @anru changes 2011-07-12 15:32:40 +03:00
Mourner
76d517e3e2 temporarily disable projection specs (need rewrite after refactoring) 2011-07-12 15:32:22 +03:00
Mourner
bad8021e9d update includes in spec runner 2011-07-12 15:31:54 +03:00
Mourner
61d636cc4f remove noSpec failures (enable when needed during development) 2011-07-12 14:59:43 +03:00
Mourner
ea4fd78b7c fix static properties inheritance 2011-06-21 12:09:49 +03:00
mourner
ff36820cf9 fix namespace spec 2010-09-23 17:25:55 +03:00
mourner
2b8d9eed1d LatLngBounds, moved MapSpec 2010-09-21 11:46:31 +03:00
mourner
a2d2fed2db new Point methods 2010-09-17 19:04:41 +03:00
mourner
d7a160470a empty Map spec 2010-09-15 16:46:27 +03:00
mourner
53bd768a47 TileLayer 2010-09-15 16:45:42 +03:00
mourner
b6ead1dbf2 Transformation fix 2010-09-15 16:45:16 +03:00
mourner
06d043853d multiplyBy 2010-09-15 16:45:02 +03:00
mourner
ad46474275 added getStyle, fixed setPosition 2010-09-14 14:57:45 +03:00
mourner
391e57c144 placeholder for spec 2010-09-13 19:02:49 +03:00
mourner
c958de9721 Bounds with specs 2010-09-13 14:58:28 +03:00
mourner
59a1736b3e Point fixes 2010-09-13 14:58:03 +03:00
mourner
7cef8d3851 Events fire shortcut 2010-09-10 16:54:20 +03:00
mourner
a8d55d0d47 Point add/subtract/divideBy 2010-09-10 16:54:03 +03:00
mourner
a9677fca55 removed Options 2010-09-07 18:20:43 +03:00
mourner
6a158218c1 DomUtil.get, spec 2010-09-07 17:02:45 +03:00
mourner
88ef7d1667 DomEvent fixes, specs 2010-09-07 15:04:00 +03:00
mourner
42bcb9b3b3 DomUtil, DomEvent, namespace config improvements, some specs 2010-09-07 14:27:44 +03:00
mourner
16097461f5 Projection fixes, specs 2010-09-07 11:59:58 +03:00
mourner
f734679158 Projection without specs 2010-09-06 19:17:27 +03:00
mourner
4854e0f9f7 minor renaming 2010-09-06 19:14:04 +03:00
mourner
0b5cc9c455 LatLng + specs 2010-09-06 19:06:38 +03:00
mourner
b50d878e5d minor spec fix 2010-09-06 18:38:14 +03:00
mourner
5b21def444 options merging 2010-09-06 18:26:20 +03:00
mourner
14bd27b088 Options, specs 2010-09-06 16:58:06 +03:00
mourner
0eb9cd8cc6 L.Util.stamp & specs 2010-09-06 16:17:06 +03:00
mourner
ada607fa2f namespace handling improvements, spec for noConflict 2010-09-03 19:49:32 +03:00
mourner
9d4e335fe0 improved Class spec 2010-09-03 19:27:26 +03:00
mourner
db5809b473 Events fixes, Events spec 2010-09-03 19:16:29 +03:00
mourner
341f6e726f added Events, folder renaming 2010-09-03 17:38:41 +03:00
mourner
e1efc0c93f Moved Transformation to geometry 2010-09-03 15:38:14 +03:00
mourner
7a1dcd9915 Transformation & Point classes, more specs 2010-09-02 18:23:53 +03:00