cartodb/Leaflet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,289 Commits 13 Branches 25 Tags 44 MiB
2431f5ec82
Commit Graph

153 Commits

Author SHA1 Message Date
Vladimir Agafonkin
0849d06c1b fix whitespace in event spec, #1661 2013-05-08 12:58:50 +03:00
R. Merkert
bbb7acb3f4 Make sure events don't fire after listener is removed. 
This patch fixes a problem with a dangling  event listener, which is
called even after it has been removed. This situation can occur when a
listener is removed during an even dispatch.

To fix this problem, the old action is replaced with a NOOP, so that
when the listener is being fired, it is not the old listener but the
NOOP.
 2013-05-07 20:16:25 -04:00
John Firebaugh
c9e2453eed Bounds-check array access in Polygon#initialize 2013-05-02 16:17:04 -07:00
Daan Mortier
c6620859e4 Updated patch for issue #1631 based on feedback 2013-04-29 13:03:05 +02:00
Daan Mortier
52498f1ef9 Issue #1631: Fixed a bug on removeEventListener 
Bugfix for issue #1631 where removeEventListener would throw when no event listeners are registered on the object.
 2013-04-29 11:53:16 +02:00
Vladimir Agafonkin
7cb7993571 simplify popup methods, merge #738 2013-04-20 16:58:42 +03:00
Vladimir Agafonkin
412f047533 Merge pull request #1462 from jfirebaugh/toGeoJSON 
Add #toGeoJSON to various layer types (#712)
 2013-04-19 09:55:40 -07:00
Vladimir Agafonkin
5647f37ae6 cleanup and merge #1596, adds Events#once 2013-04-19 17:23:45 +03:00
Vladimir Agafonkin
a5e8bc0f49 add Util.invokeEach for hash arguments in event methods 2013-04-19 17:23:14 +03:00
iirvine
84ad7db070 clearEventListeners -> clearAllListeners 2013-04-15 14:09:32 -07:00
iirvine
2d5bf783fe initial commit of #clearEventListeners 2013-04-15 14:09:32 -07:00
iirvine
031086681f fix our context to the object that's registering this listener 2013-04-14 20:49:57 -07:00
iirvine
a469a387a1 back to first implementation to fix event leak 2013-04-13 22:11:01 -07:00
iirvine
e25f730b04 better implementation, more tests 2013-04-12 17:03:14 -07:00
iirvine
e41e8a886a initial implementation of events#once 2013-04-12 15:21:48 -07:00
Tom MacWright
22810aacf7 Throw an exception if a map div is not found 
and test for initialization exceptions
 2013-04-08 12:28:27 -04:00
Vladimir Agafonkin
6009d4ae87 move phantomjs check for touch into Leaflet 
to allow standalone mocha-phantomjs usage on the browser reporter
 2013-04-05 12:32:19 +03:00
John Firebaugh
0e9b7249d8 Convert to expect.js assertions 2013-04-04 09:47:45 -07:00
John Firebaugh
55edd44678 Add #toGeoJSON to various layer types (#712) 2013-04-04 09:46:18 -07:00
John Firebaugh
81f21125d4 Update specs for mocha 2013-04-03 15:22:45 -07:00
John Firebaugh
a950e6873e Manage mocha dependency with npm; update to 1.9.0 2013-04-03 15:20:15 -07:00
John Firebaugh
a8ca5a2dbf Update mocha.js 2013-04-03 14:50:10 -07:00
Tom MacWright
8691889d49 Proper default for delta 2013-04-03 14:50:10 -07:00
Tom MacWright
bf99fdb70e Tighter tolerance for point-near check 2013-04-03 14:50:10 -07:00
Tom MacWright
a3ab4b1095 Fix mercator tests, these are broken in Leaflet master. 2013-04-03 14:50:10 -07:00
Tom MacWright
a2f7d7e834 Use mocha 2013-04-03 14:50:09 -07:00
John Firebaugh
28daa9e9b1 testacular -> karma 2013-04-03 14:12:51 -07:00
danzel
9d4d894450 Add another events test and fix from @iirvine 2013-03-15 13:53:03 +13:00
danzel
44cbed0b5e Replace the FeatureGroup test with a better one in events, this one currently fails 2013-03-13 10:08:04 +13:00
danzel
e2a852639a Add failing test case for #1495 from @iirvine 2013-03-12 17:24:46 +13:00
danzel
9300c58262 Fix copy/paste bug 2013-03-12 17:12:06 +13:00
Tom MacWright
71d17180c8 Add layerGroup#getLayers and tests. Fixes #1460 2013-02-27 17:10:19 -05:00
John Firebaugh
511fbb9f44 Add Map#eachLayer (fixes #1457) 2013-02-26 11:39:00 -08:00
John Firebaugh
bee90ce0e5 Fix whitespace 2013-02-26 11:31:23 -08:00
Vladimir Agafonkin
9c2e7cfbd4 add Point contains method 2013-02-22 17:28:55 +02:00
John Firebaugh
46dddc895c Fire an unload event on removal 
Plugins that need to bind events to `window` or `document`
can attach a listener for this event and unbind their event
handlers.

However, for symmetry, unload is fired only if load has been
fired.
 2013-02-21 17:31:09 -08:00
Vladimir Agafonkin
9c9d4286a1 Merge pull request #1439 from danzel/convert_option 
Make Polyline/Polygon not overwrite the source array
 2013-02-21 00:08:48 -08:00
Vladimir Agafonkin
501b179bbd fix 404 error in TileLayer tests 2013-02-20 21:22:47 +02:00
Vladimir Agafonkin
3063fd9192 Merge pull request #1433 from tmcw/layer-container 
Add a public API for getContainer for TileLayer
 2013-02-20 09:48:19 -08:00
John Firebaugh
fb9450f975 Force touch support off for PhantomJS 
PhantomJS has `'ontouchstart' in document.documentElement`, but
doesn't actually support touch.

http://code.google.com/p/phantomjs/issues/detail?id=375
https://github.com/ariya/phantomjs/pull/408
https://github.com/Leaflet/Leaflet/pull/1434#issuecomment-13843151
 2013-02-20 09:17:06 -08:00
Tom MacWright
d8fccfb3dc Spacing. 2013-02-19 21:15:36 -05:00
John Firebaugh
6ef25866eb Add Map#remove 
This is a minimal implementation; it only unbinds events
and deletes the _leaflet flag from the container.

Refs #1101.
 2013-02-19 17:36:03 -08:00
Tom MacWright
8735b87980 Add public getContainer API to TileLayer, and test for it. 2013-02-19 20:05:44 -05:00
danzel
5873914062 Start on some Polyline/Polygon tests. 2013-02-20 11:03:37 +13:00
Vladimir Agafonkin
0b14d71d7a Merge pull request #1427 from jfirebaugh/should 
Omit "should" in spec descriptions
 2013-02-19 12:54:33 -08:00
Dave Leaver
db2352ae9b Merge pull request #1424 from tmcw/use-tobe 
Use tobe instead of testing the result of an equality
 2013-02-19 12:49:04 -08:00
John Firebaugh
01332ebead Omit "should" in spec descriptions 
The rationale is this: the spec string describes the expected
behavior unconditionally. The code examples, on the other hand,
set up an expectation that is tested with the call to the expect
method. The code examples can violate the expectation, but the
spec string does not. The value of the spec string is as clearly
as possible describing the behavior. Including “should” in that
description adds no value. (From http://rubyspec.org/style_guide/)
 2013-02-19 12:41:48 -08:00
Tom MacWright
a324759268 Use tobe instead of testing the result of an equality 2013-02-19 14:21:06 -05:00
Vladimir Agafonkin
b84b83bf93 fix setView test, #1420 2013-02-19 19:25:49 +02:00
Tom MacWright
1b03d5d0b4 Test setView. The setTimeout can be removed when #1420 is fixed. 2013-02-19 11:53:42 -05:00