cartodb/Leaflet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The internal MSPointerUp/Cancel listener should be set on the document and never let go otherwise we can miss MSPointerUp events.

Browse Source
This commit is contained in:
danzel 2012-10-17 09:19:44 +13:00
parent 1bf755dce3
commit f373d6b0d4
1 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/dom/DomEvent.MsTouch.js
View File

@ -1,6 +1,7 @@
L.Util.extend(L.DomEvent, {
_msTouches: [],
_msDocumentListener: false,
// Provides a touch events wrapper for msPointer events.
// Based on changes by veproza https://github.com/CloudMade/Leaflet/pull/1019
@ -46,18 +47,22 @@ L.Util.extend(L.DomEvent, {
obj.addEventListener('MSPointerDown', cb, false);
//Need to also listen for end events to keep the _msTouches list accurate
var internalCb = function (e) {
for (var i = 0; i < touches.length; i++) {
if (touches[i].pointerId === e.pointerId) {
touches.splice(i, 1);
break;
//this needs to be on the body and never go away
if (!this._msDocumentListener) {
var internalCb = function(e) {
for (var i = 0; i < touches.length; i++) {
if (touches[i].pointerId === e.pointerId) {
touches.splice(i, 1);
break;
}
}
}
};
//We listen on the documentElement as any drags that end by moving the touch off the screen get fired there
obj.addEventListener('MSPointerUp', internalCb, false);
obj.addEventListener('MSPointerCancel', internalCb, false);
obj[pre + 'touchstartend' + id] = internalCb;
};
//We listen on the documentElement as any drags that end by moving the touch off the screen get fired there
document.documentElement.addEventListener('MSPointerUp', internalCb, false);
document.documentElement.addEventListener('MSPointerCancel', internalCb, false);
this._msDocumentListener = true;
}
return this;
},
@ -124,9 +129,6 @@ L.Util.extend(L.DomEvent, {
switch (type) {
case 'touchstart':
obj.removeEventListener('MSPointerDown', cb, false);
obj.removeEventListener('MSPointerUp', obj[pre + 'touchstartend' + id], false);
obj.removeEventListener('MSPointerCancel', obj[pre + 'touchstartend' + id], false);
break;
case 'touchmove':
obj.removeEventListener('MSPointerMove', cb, false);