cartodb/Leaflet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #1631: Fixed a bug on removeEventListener

Browse Source 
Bugfix for issue #1631 where removeEventListener would throw when no event listeners are registered on the object.
This commit is contained in:
Daan Mortier 2013-04-29 11:53:16 +02:00
parent b31c9d50b8
commit 52498f1ef9
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spec/suites/core/EventsSpec.js
View File

@ -126,6 +126,11 @@ describe('Events', function() {
expect(spy5.called).to.be(false);
});
it('can handle calls to #removeEventListener on objects with no registered event listeners', function () {
var obj = new Klass();
obj.removeEventListener('test');
});
// added due to context-sensitive removeListener optimization
it('fires multiple listeners with the same context with id', function () {
var obj = new Klass(),

4
src/core/Events.js
View File

@ -63,6 +63,10 @@ L.Mixin.Events = {
removeEventListener: function (types, fn, context) { // ([String, Function, Object]) or (Object[, Object])
if (!this[eventsKey]) {
return this;
}
if (!types) {
return this.clearAllEventListeners();
}