cartodb/Leaflet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Push back keyboard navigation order of L.Popup's close button (#5461)

Browse Source 
* Web accessibility

so tabbing through the page make the link(in the popup) to the first entry focussed before the 'x' for close

* remove spaces
This commit is contained in:
Mirodil 2017-04-18 09:12:00 -04:00 committed by Iván Sánchez Ortega
parent c06db46191
commit 458b7177b2
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/layer/Popup.js
View File

@ -174,14 +174,6 @@ export var Popup = DivOverlay.extend({
prefix + ' ' + (this.options.className || '') + prefix + ' ' + (this.options.className || '') +
' leaflet-zoom-animated'); ' leaflet-zoom-animated');
if (this.options.closeButton) {
var closeButton = this._closeButton = DomUtil.create('a', prefix + '-close-button', container);
closeButton.href = '#close';
closeButton.innerHTML = '×';
DomEvent.on(closeButton, 'click', this._onCloseButtonClick, this);
}
var wrapper = this._wrapper = DomUtil.create('div', prefix + '-content-wrapper', container); var wrapper = this._wrapper = DomUtil.create('div', prefix + '-content-wrapper', container);
this._contentNode = DomUtil.create('div', prefix + '-content', wrapper); this._contentNode = DomUtil.create('div', prefix + '-content', wrapper);
@ -191,6 +183,14 @@ export var Popup = DivOverlay.extend({
this._tipContainer = DomUtil.create('div', prefix + '-tip-container', container); this._tipContainer = DomUtil.create('div', prefix + '-tip-container', container);
this._tip = DomUtil.create('div', prefix + '-tip', this._tipContainer); this._tip = DomUtil.create('div', prefix + '-tip', this._tipContainer);
if (this.options.closeButton) {
var closeButton = this._closeButton = DomUtil.create('a', prefix + '-close-button', container);
closeButton.href = '#close';
closeButton.innerHTML = '×';
DomEvent.on(closeButton, 'click', this._onCloseButtonClick, this);
}
}, },
_updateLayout: function () { _updateLayout: function () {