Daniel García Aubert
f7f96f004a
Be more specific with arguments
2019-05-16 12:19:03 +02:00
Daniel García Aubert
2208fb9764
Implement a cancel backend through query instead of node-postgres protocol
2019-05-14 15:39:54 +02:00
Raul Marin
915d86ab50
Update doc ref
2019-04-10 12:03:26 +02:00
Daniel García Aubert
a616982ec3
Use strict mode
2018-10-24 15:42:33 +02:00
Rafa de la Torre
d5a7f6d2d6
Fix paused stream (DB socket) after copy to #590
...
Ideally, the CopyToQueryStream would take care o piping, unpiping and
resuming the connection with the DB.
For some reason it does not always work when trying that from the
_transform callback.
Since there's no better callback (at least in node6), this patch is
required to make sure that such connection can be returned to the pool
and reused by some other query.
2018-09-17 16:54:51 +02:00
Rafa de la Torre
19c9c15969
Replace let by const in pseudo-constant conditional assignment
2018-07-23 18:41:27 +02:00
Rafa de la Torre
151bffaad4
return to avoid further errors
...
As per a PR comment: `return done(err);` should prevent further errors
and make sure the request is over.
2018-07-23 18:39:30 +02:00
Rafa de la Torre
cc348f3725
Make the SET statement_timeout async
2018-07-20 16:25:47 +02:00
Rafa de la Torre
17c8cbc723
Add a timeout setting for COPY commands
2018-07-20 15:32:32 +02:00
Rafa de la Torre
763134437b
Use the db_batch_port for copy
2018-07-20 10:22:54 +02:00
Simon Martín
f5641a1873
remove unneeded this.connectionClosedByClient
2018-06-21 15:18:26 +02:00
Simon Martín
823e3abcfe
unify to and from method in only one getPGStream
2018-06-21 15:16:47 +02:00
Simon Martín
3ede1ea9f1
unify streams
2018-06-21 14:53:07 +02:00
Simon Martín
f4651cadae
using this.copyFromStream
2018-06-21 14:49:38 +02:00
Simon Martín
9970052e1b
copy from: removing copyFromStream dependency
2018-06-21 14:38:22 +02:00
Simon Martín
01eff0a5a2
copy from: removing done dependecy
2018-06-21 14:36:40 +02:00
Simon Martín
925115e8c1
copy from: remove client dependecy
2018-06-21 14:25:54 +02:00
Simon Martín
327aaf3450
jshint happy
2018-06-21 13:41:13 +02:00
Simon Martín
bafcb8051f
StreamCopy getResults refactor
...
- changing get Result to getRowCount
- ensuring to and from independecy in StreamCopy
2018-06-21 13:39:33 +02:00
Simon Martín
2cecc54cb2
copy to: removing copyToStream dependecy
2018-06-21 13:21:23 +02:00
Simon Martín
1dac5355d1
copy to: remove unneeded done and removing it as a dependency
2018-06-21 13:13:16 +02:00
Simon Martín
42a94a3b6c
copy to: removing unnedeed client dependecy
2018-06-21 13:01:59 +02:00
Daniel García Aubert
8eab164e4e
Be more one liner
2018-06-14 00:54:03 +02:00
Daniel García Aubert
508d688b9d
Use request 'close' event when the request is closed unexpectedly by the client
2018-06-14 00:16:06 +02:00
Daniel García Aubert
37a079363a
Do not extend from EventEmitter
2018-06-13 20:12:56 +02:00
Daniel García Aubert
bd8e4be596
Do not emit to regist the number of rows processed in copyfrom
2018-06-13 20:11:39 +02:00
Daniel García Aubert
5655f26fbd
Do not emit to regist the number of rows processed in copyto
2018-06-13 20:06:35 +02:00
Daniel García Aubert
eb4ba60ba0
Pass the error to the pg connection's callback
2018-06-13 19:56:56 +02:00
Daniel García Aubert
b9971d94dd
Do not use the regular callback in streams events
2018-06-13 18:28:34 +02:00
Daniel García Aubert
7d1a0abadd
Preventing callbacks from accidentally being called twice
2018-06-13 18:26:58 +02:00
Simon Martín
409273bafe
removing 2nd calback using events
2018-06-12 18:39:50 +02:00
Simon Martín
19aae3c40f
manage pgstrem error on stream copy class
2018-06-12 17:04:44 +02:00
Simon Martín
ba2f85421d
StreamCopy to class
2018-06-12 16:56:18 +02:00
Simon Martín
b63806f8de
cleaning stream copy
2018-06-08 17:04:28 +02:00
Simon Martín
014f0a1491
refactor of copy to PoC
2018-06-08 16:58:32 +02:00
Simon Martín
f7454228c6
refactor of copy from PoC
2018-06-08 16:50:12 +02:00
Simon Martín
e259a51623
unifiyng to see 'the forest'
2018-06-08 15:03:21 +02:00
Simon Martín
c62ef15dda
using StreamCopy in controller
2018-06-08 11:15:23 +02:00
Simon Martín
732c229e63
creating StreamCopy class
2018-06-08 11:09:51 +02:00
Simon Martín
66af518deb
jshint
2018-06-05 13:16:14 +02:00
Simon Martín
29d1fb1274
logging GzipSize
2018-06-05 13:02:14 +02:00
Simon Martín
550c736032
metrics in errors
2018-06-05 12:35:52 +02:00
Rafa de la Torre
d2c0e68a78
Merge pull request #497 from CartoDB/cancel-copy-to-client-disconnect
...
Cancel copy to upon client disconnect
2018-06-05 09:59:49 +02:00
Simon Martín
66f7ab45fe
release connection with error
2018-06-04 20:51:21 +02:00
Simon Martín
7b6056b799
using the correct errors in done
2018-06-04 20:36:16 +02:00
Rafa de la Torre
014ea8142b
A cleaner approach to the cancel command
2018-06-04 19:06:11 +02:00
Simon Martín
1cf7032c9a
adding user and date in copy logs
2018-06-04 18:08:34 +02:00
Rafa de la Torre
994e8a702b
Add callbacks to pg.connect
...
And call them to return connections to the pool.
2018-05-31 18:59:19 +02:00
Rafa de la Torre
b59ae1d057
Make sure the COPY TO query is cancelled
...
Issue a CancelRequest upon client disconnection, to make sure the COPY
TO query is cancelled and the connection/session is put back to the pg
pool.
2018-05-31 17:27:35 +02:00
Rafa de la Torre
332f7096d3
Listen to response events (on behalf of @oleurud)
2018-05-31 17:06:19 +02:00
