Rafa de la Torre
942b0073d8
Please jshint
...
As suggested by jshint:
- Remove the unused `res` return value
- Add a semicolon at the end of the file
2018-07-30 12:36:16 +02:00
Rafa de la Torre
2afe845d78
More descriptive comment about the intent of the code
...
As suggested in review comment.
2018-07-30 12:34:29 +02:00
Rafa de la Torre
bf1d5bf3b4
Early return instead of if/else
...
As suggested in review comment.
2018-07-30 12:31:57 +02:00
Rafa de la Torre
7277143c27
Merge remote-tracking branch 'origin/master' into 521-test-robustness-pgbouncer
2018-07-25 15:07:55 +02:00
Rafa de la Torre
75f25a6c02
Test for the max POST size
2018-07-23 16:58:05 +02:00
Rafa de la Torre
a8e538aba4
Test for COPY TO and DB quota
2018-07-23 16:20:15 +02:00
Rafa de la Torre
7b405cee5d
Add test for DB quota exceeded
2018-07-23 16:14:10 +02:00
Rafa de la Torre
153ae3ea3d
Fix test: increase timeout for DB quota middleware
...
In order to give the DB quota middleware a chance of getting executed,
increase the 1 ms timeout to 10 ms. This is short but enough, as the
quota mocks are constant functions.
2018-07-23 15:36:13 +02:00
Rafa de la Torre
44858df713
Add a mock for DB quota functions
2018-07-23 15:29:53 +02:00
Rafa de la Torre
fdab0136e6
Fix copy/paste test
2018-07-20 16:17:44 +02:00
Rafa de la Torre
ce409b4925
Fix typo in test describe
2018-07-20 16:09:10 +02:00
Rafa de la Torre
0f8e1f43c4
Add more tests for copy_timeout
2018-07-20 15:57:36 +02:00
Rafa de la Torre
682d7e6812
Simplify timeout tests
2018-07-20 15:38:20 +02:00
Rafa de la Torre
f437df9045
Fix timeout tests
2018-07-20 15:33:12 +02:00
Rafa de la Torre
632e6818fa
Test that COPY uses db_batch_port
2018-07-20 12:04:06 +02:00
Rafa de la Torre
5b65252c4a
Ensure no connection pgbouncer -> test_db #521
...
This is needed to make the setup a little bit more robust: when trying
to delete the test database, it won't be able if there are "idle
sessions" in the db (that is, connections from pgbouncer to the test
database).
Otherwise it fails when trying to create the database, because there's
already one with the same name.
2018-07-19 18:46:28 +02:00
Rafa de la Torre
20d1db78dc
Helper to reset pgbouncer connections #521
...
This sends a PAUSE and RESUME to pgbouncer (in case there's one) before
and after executing tests, to make sure new connections are established
in the tests.
This may be especially important when role or session settings are
modified in the DB (same happens in prod, BTW).
2018-07-19 18:43:17 +02:00
Rafa de la Torre
6eeb949583
This is a bash script #521
...
And using sh can make some things fail. E.g:
```
[[: not found
```
2018-07-19 18:40:31 +02:00
Rafa de la Torre
d3e31a9d6c
Allow tests to be executed against pgbouncer
...
pgbouncer does not support the `--client-min-messages` option. Actually
it fails connections if used like that with this somewhat cryptic
message:
```
psql: ERROR: Unsupported startup parameter: options
```
In order to be able to execute tests against pgbouncer port (which is
desirable IMO), we either need to remove that option (with little to no
impact) or change the lines above to choose the batch API port from the
config.
Mind that this affects just test setup.
2018-07-18 15:50:57 +02:00
Eneko Lakasta
1bf8a06ec2
Rephrase error message
2018-06-29 13:19:32 +02:00
Eneko Lakasta
3c603d65c8
update tests messages accordingly
2018-06-27 16:27:10 +02:00
Simon Martín
e7750eb4c8
undo remove line
2018-06-21 16:36:21 +02:00
Simon Martín
7e593bb3c9
copy to tests: cancel query with only 1 connection
2018-06-21 13:06:38 +02:00
Simon Martín
f46669fd4f
details from merge
2018-06-21 12:25:19 +02:00
Simon Martín
6955d254f8
Merge branch 'master' into pgcopy-stream-refactor2-dgaubert
2018-06-21 12:19:16 +02:00
Simon Martín
dd088215c1
unify client disconnect timeout
2018-06-20 19:03:23 +02:00
Simon Martín
030a8f1ef4
checking connection reuse properly
2018-06-20 19:02:34 +02:00
Simon Martín
50da363ae0
improving name dropTableOptions
2018-06-20 18:39:17 +02:00
Simon Martín
5b87defb97
remove unneeded test table copy_endpoints_test2
2018-06-20 15:09:37 +02:00
Simon Martín
20e43f6029
ensuring query cancelation in copy from
2018-06-20 14:43:50 +02:00
Simon Martín
84c43344e4
jshgint happy
2018-06-20 13:18:32 +02:00
Simon Martín
c37ea82c0e
updating copyto test making them independent
2018-06-20 11:12:19 +02:00
Simon Martín
5021c8d466
making copy test independent
2018-06-20 11:08:41 +02:00
Simon Martín
16c2fd728f
js hint happy
2018-06-20 10:48:03 +02:00
Simon Martín
81e33b632d
Merge branch 'master' into copyto-cancel-test
2018-06-19 15:50:46 +02:00
Daniel García Aubert
258baa3792
Remove test filter
2018-06-18 10:56:14 +02:00
Daniel García Aubert
bd499b88e5
Add tests to check copyto cancel works properly
2018-06-18 10:53:44 +02:00
Simon Martín
7dec3f4e95
jshint happy
2018-06-15 13:47:37 +02:00
Simon Martín
d4e03303f9
done after response end in test copy to
2018-06-14 18:25:38 +02:00
Simon Martín
0757d11bd0
more deterministic tests when client disconnects
2018-06-14 18:10:41 +02:00
Simon Martín
34c0c5c738
removing console log
2018-06-14 10:48:00 +02:00
Simon Martín
2fa5e7b84a
grouping all copy related tests in a describe
2018-06-14 10:44:57 +02:00
Simon Martín
d67cf2f7d5
removing only
2018-06-12 16:53:37 +02:00
Simon Martín
a00891ff98
grouping all the copy tests in one describe
2018-06-12 16:46:54 +02:00
Simon Martín
8a15b2f8d1
Merge branch 'master' into pgcopy-stream-refactor2
2018-06-12 15:21:28 +02:00
Rafa de la Torre
fc12917938
Please jshint
2018-06-11 19:26:40 +02:00
Rafa de la Torre
b1073dc401
Test for the COPY FROM + disconnect
2018-06-11 19:17:23 +02:00
Rafa de la Torre
66664de286
Make the test far more robust
2018-06-11 19:04:33 +02:00
Rafa de la Torre
1417dedfd3
Final touches for client disconnect test
2018-06-11 18:45:12 +02:00
Rafa de la Torre
62fe8abd0a
A much cleaner test
2018-06-11 18:38:18 +02:00
