Commit Graph

2634 Commits

Author SHA1 Message Date
Rafa de la Torre
17c8cbc723 Add a timeout setting for COPY commands 2018-07-20 15:32:32 +02:00
Rafa de la Torre
632e6818fa Test that COPY uses db_batch_port 2018-07-20 12:04:06 +02:00
Rafa de la Torre
763134437b Use the db_batch_port for copy 2018-07-20 10:22:54 +02:00
Rafa de la Torre
5b65252c4a Ensure no connection pgbouncer -> test_db #521
This is needed to make the setup a little bit more robust: when trying
to delete the test database, it won't be able if there are "idle
sessions" in the db (that is, connections from pgbouncer to the test
database).

Otherwise it fails when trying to create the database, because there's
already one with the same name.
2018-07-19 18:46:28 +02:00
Rafa de la Torre
20d1db78dc Helper to reset pgbouncer connections #521
This sends a PAUSE and RESUME to pgbouncer (in case there's one) before
and after executing tests, to make sure new connections are established
in the tests.

This may be especially important when role or session settings are
modified in the DB (same happens in prod, BTW).
2018-07-19 18:43:17 +02:00
Rafa de la Torre
6eeb949583 This is a bash script #521
And using sh can make some things fail. E.g:

```
[[: not found
```
2018-07-19 18:40:31 +02:00
Rafa de la Torre
b88a45889f
Merge pull request #520 from CartoDB/allow-tests-on-pgbouncer
Allow tests to be executed against pgbouncer
2018-07-18 17:12:46 +02:00
Rafa de la Torre
d3e31a9d6c Allow tests to be executed against pgbouncer
pgbouncer does not support the `--client-min-messages` option. Actually
it fails connections if used like that with this somewhat cryptic
message:

```
psql: ERROR:  Unsupported startup parameter: options
```

In order to be able to execute tests against pgbouncer port (which is
desirable IMO), we either need to remove that option (with little to no
impact) or change the lines above to choose the batch API port from the
config.

Mind that this affects just test setup.
2018-07-18 15:50:57 +02:00
Rafa de la Torre
dce803d04e
Merge pull request #518 from CartoDB/copy-doc-improvements
Copy doc improvements
2018-07-18 10:50:12 +02:00
Rafa de la Torre
c86f49e468 Remove confusing usage of filename request param 2018-07-17 18:41:46 +02:00
Rafa de la Torre
d853350135 Address the CDB_CartodbfyTable doc issue 2018-07-17 18:19:58 +02:00
Rafa de la Torre
c9d560e585 Note about (HEADER true) in CSV files 2018-07-17 18:11:57 +02:00
Simon Martín
a8ef19d318 updating NEWS 2018-07-06 11:46:30 +02:00
Simon Martín
b93e67ce01
Merge pull request #517 from CartoDB/upgrade-cartodb-redis-v2
Upgrading cartodb-redis
2018-07-06 11:41:18 +02:00
Simon Martín
b32338983d Merge branch 'master' into upgrade-cartodb-redis-v2 2018-07-06 11:05:21 +02:00
Simon Martín
cef024cf70 fixed version of cartodb-redis 2018-07-06 10:35:33 +02:00
Simon Martín
f11b87a07d upgrading cartodb-redis to 2.0.1 2018-07-05 16:37:30 +02:00
Simon Martín
5e837558ed adding shrinkwrap 2018-07-05 12:54:51 +02:00
Simon Martín
e3da2ee298 upgrading cartodb-redis version (github version) 2018-07-05 12:34:33 +02:00
Eneko Lakasta
6897101797
Merge pull request #514 from CartoDB/984-sql-timeout-error-message
Improve sql timeout error message
2018-07-02 13:10:51 +02:00
Eneko Lakasta
55acccd89e Update NEWS 2018-07-02 11:30:07 +02:00
Eneko Lakasta
1bf8a06ec2 Rephrase error message 2018-06-29 13:19:32 +02:00
Eneko Lakasta
3c603d65c8 update tests messages accordingly 2018-06-27 16:27:10 +02:00
Eneko Lakasta
99058e68af add space to message 2018-06-27 15:53:51 +02:00
Eneko Lakasta
2bb28b5578 remove line break in the error message 2018-06-27 15:43:06 +02:00
Eneko Lakasta
879e85d07f add 'SQL query timeout expired error.' to DB timeout limit error message. 2018-06-27 15:17:38 +02:00
Daniel G. Aubert
b066b6da3a
Merge pull request #512 from CartoDB/add-release-note
Add relase note about to run a rake task to create the new api-keys f…
2018-06-25 13:24:52 +02:00
Daniel García Aubert
328c1895ff Add relase note about to run a rake task to create the new api-keys for the development environment 2018-06-25 13:22:35 +02:00
Simon Martín
c34c4ae4fb
Merge pull request #508 from CartoDB/pgcopy-stream-refactor2-dgaubert
copy refactor splitting:
- Expressjs and streams
- Database / pgstream
2018-06-22 11:10:08 +02:00
Simon Martín
59dd495a87 small style details 2018-06-22 10:50:39 +02:00
Simon Martín
e7750eb4c8 undo remove line 2018-06-21 16:36:21 +02:00
Simon Martín
06c40a396b copy from: events is series 2018-06-21 15:58:23 +02:00
Simon Martín
195a4866c3 managing gzip pipe with PassThrough 2018-06-21 15:54:42 +02:00
Simon Martín
f5641a1873 remove unneeded this.connectionClosedByClient 2018-06-21 15:18:26 +02:00
Simon Martín
fae18fb242 using getPGStream 2018-06-21 15:17:32 +02:00
Simon Martín
823e3abcfe unify to and from method in only one getPGStream 2018-06-21 15:16:47 +02:00
Simon Martín
3ede1ea9f1 unify streams 2018-06-21 14:53:07 +02:00
Simon Martín
f4651cadae using this.copyFromStream 2018-06-21 14:49:38 +02:00
Simon Martín
9970052e1b copy from: removing copyFromStream dependency 2018-06-21 14:38:22 +02:00
Simon Martín
01eff0a5a2 copy from: removing done dependecy 2018-06-21 14:36:40 +02:00
Simon Martín
a15c2e58aa copy from: manage error in 1 point 2018-06-21 14:36:03 +02:00
Simon Martín
d17a5608fb copy from: unneeded pgstream.end in req error 2018-06-21 14:32:36 +02:00
Simon Martín
5a28d36d69 copy from: pgstream events in series 2018-06-21 14:29:19 +02:00
Simon Martín
925115e8c1 copy from: remove client dependecy 2018-06-21 14:25:54 +02:00
Simon Martín
327aaf3450 jshint happy 2018-06-21 13:41:13 +02:00
Simon Martín
bafcb8051f StreamCopy getResults refactor
- changing get Result to getRowCount
- ensuring to and from independecy in StreamCopy
2018-06-21 13:39:33 +02:00
Simon Martín
2cecc54cb2 copy to: removing copyToStream dependecy 2018-06-21 13:21:23 +02:00
Simon Martín
e39a9b2bf7 copy to: manage error in 1 point 2018-06-21 13:13:37 +02:00
Simon Martín
1dac5355d1 copy to: remove unneeded done and removing it as a dependency 2018-06-21 13:13:16 +02:00
Simon Martín
7e593bb3c9 copy to tests: cancel query with only 1 connection 2018-06-21 13:06:38 +02:00