Commit Graph

2553 Commits

Author SHA1 Message Date
Simon Martín
39e5395edc change gzip to isGzip 2018-06-14 18:29:03 +02:00
Simon Martín
d4e03303f9 done after response end in test copy to 2018-06-14 18:25:38 +02:00
Simon Martín
0757d11bd0 more deterministic tests when client disconnects 2018-06-14 18:10:41 +02:00
Simon Martín
4cb7de7318 changing let for const 2018-06-14 10:51:05 +02:00
Simon Martín
b091a375fc fix ensuring right validation error 2018-06-14 10:49:36 +02:00
Simon Martín
34c0c5c738 removing console log 2018-06-14 10:48:00 +02:00
Simon Martín
1f31b8e2ae removing old copy logs 2018-06-14 10:45:23 +02:00
Simon Martín
2fa5e7b84a grouping all copy related tests in a describe 2018-06-14 10:44:57 +02:00
Daniel García Aubert
9299fe51ce Add todo 2018-06-14 01:01:05 +02:00
Daniel García Aubert
8eab164e4e Be more one liner 2018-06-14 00:54:03 +02:00
Daniel García Aubert
9c8d802f75 Chain response event callbacks after .pipe() in order to improve readability in copyto controller 2018-06-14 00:31:08 +02:00
Daniel García Aubert
508d688b9d Use request 'close' event when the request is closed unexpectedly by the client 2018-06-14 00:16:06 +02:00
Daniel García Aubert
37a079363a Do not extend from EventEmitter 2018-06-13 20:12:56 +02:00
Daniel García Aubert
bd8e4be596 Do not emit to regist the number of rows processed in copyfrom 2018-06-13 20:11:39 +02:00
Daniel García Aubert
5655f26fbd Do not emit to regist the number of rows processed in copyto 2018-06-13 20:06:35 +02:00
Daniel García Aubert
eb4ba60ba0 Pass the error to the pg connection's callback 2018-06-13 19:56:56 +02:00
Daniel García Aubert
e6a331433a Handle error when client disconnects in copyto requests 2018-06-13 19:54:34 +02:00
Daniel García Aubert
6aba1ea307 Handle error when sql injected in pgstream fails (e.g: unexisting table) 2018-06-13 19:52:53 +02:00
Daniel García Aubert
2792d95c41 Do not handle stream unpiping when it wasn't even created 2018-06-13 18:30:05 +02:00
Daniel García Aubert
b9971d94dd Do not use the regular callback in streams events 2018-06-13 18:28:34 +02:00
Daniel García Aubert
7d1a0abadd Preventing callbacks from accidentally being called twice 2018-06-13 18:26:58 +02:00
Simon Martín
6ecd0c00dd stubs next version 2018-06-13 13:29:26 +02:00
Eneko Lakasta
4e52ca39a5
Merge pull request #507 from CartoDB/patch-oauth-missing-return
FIX add return to callback call
2018-06-13 13:25:10 +02:00
Eneko Lakasta
f5d56a2253
FIX add return to callback call 2018-06-13 13:17:01 +02:00
Simon Martín
ad79717069 NEWS 2.1.0 date 2018-06-13 10:39:44 +02:00
Simon Martín
270daae579 removing forgotten callback 2018-06-12 18:40:51 +02:00
Simon Martín
409273bafe removing 2nd calback using events 2018-06-12 18:39:50 +02:00
Simon Martín
19aae3c40f manage pgstrem error on stream copy class 2018-06-12 17:04:44 +02:00
Simon Martín
ba2f85421d StreamCopy to class 2018-06-12 16:56:18 +02:00
Simon Martín
d67cf2f7d5 removing only 2018-06-12 16:53:37 +02:00
Simon Martín
a00891ff98 grouping all the copy tests in one describe 2018-06-12 16:46:54 +02:00
Simon Martín
8a15b2f8d1 Merge branch 'master' into pgcopy-stream-refactor2 2018-06-12 15:21:28 +02:00
Simon Martín
4d99872975 return in next err 2018-06-12 15:18:28 +02:00
Rafa de la Torre
c0ef36ec5c Update npm shrinkwrap (just version of cartodb_sql_api) 2018-06-12 12:29:22 +02:00
Rafa de la Torre
b8fcae9b5b Update NEWS.md and version w/ COPY 2018-06-12 12:23:32 +02:00
Rafa de la Torre
0ce6205127
Merge pull request #480 from CartoDB/pgcopy-stream
/copyfrom and /copyto end points
2018-06-12 11:31:08 +02:00
Rafa de la Torre
3b4e23d150
Merge pull request #505 from CartoDB/pgcopy-stream-disconnect-tests
Pgcopy stream disconnect tests
2018-06-12 10:06:26 +02:00
Rafa de la Torre
fc12917938 Please jshint 2018-06-11 19:26:40 +02:00
Rafa de la Torre
b1073dc401 Test for the COPY FROM + disconnect 2018-06-11 19:17:23 +02:00
Rafa de la Torre
66664de286 Make the test far more robust 2018-06-11 19:04:33 +02:00
Rafa de la Torre
1417dedfd3 Final touches for client disconnect test 2018-06-11 18:45:12 +02:00
Rafa de la Torre
62fe8abd0a A much cleaner test 2018-06-11 18:38:18 +02:00
Rafa de la Torre
4b6ee133df Mess a little with the timeouts 2018-06-11 18:18:44 +02:00
Rafa de la Torre
52590faeac Add a test for client disconnection scenarios 2018-06-11 17:28:53 +02:00
Rafa de la Torre
646f4fc11d
Merge pull request #504 from CartoDB/pgcopy-stream-update-node-module
Use our patched node-pg-copy-streams
2018-06-11 15:54:30 +02:00
Rafa de la Torre
bbe5db64d0 Use our patched node-pg-copy-streams
The patch includes a performance improvement for the COPY TO. It can
eventually be removed in the PR to upstream is approved. See

https://github.com/brianc/node-pg-copy-streams/pull/70

and

https://github.com/CartoDB/node-pg-copy-streams/pull/1
2018-06-11 15:36:19 +02:00
Simon Martín
b9a0fa78d2 adding metadataBackend to user middleware in copycontroller 2018-06-11 14:55:37 +02:00
Simon Martín
1174499dcf Merge branch 'master' into pgcopy-stream 2018-06-11 14:38:52 +02:00
Simon Martín
df63e0eedb adding log of the error when headers are already sent 2018-06-11 13:19:12 +02:00
Simon Martín
2995676adb let to const 2018-06-11 12:56:16 +02:00