cartodb/CartoDB-SQL-API
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactoring copy controller middlewares

Browse Source
This commit is contained in:
Simon Martín 2018-05-22 11:56:50 +02:00
parent 433bd01c27
commit f01191472b
1 changed files with 67 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/controllers/copy_controller.js
View File

@ -34,8 +34,8 @@ CopyController.prototype.route = function (app) {
authorizationMiddleware(this.metadataBackend),
connectionParamsMiddleware(this.userDatabaseService),
timeoutLimitsMiddleware(this.metadataBackend),
this.handleCopyFrom.bind(this),
this.responseCopyFrom.bind(this),
handleCopyFrom(),
responseCopyFrom(),
errorMiddleware()
];
};
@ -106,7 +106,8 @@ function handleCopyTo (statsClient) {
};
}
CopyController.prototype.handleCopyFrom = function (req, res, next) {
function handleCopyFrom () {
return function handleCopyFromMiddleware (req, res, next) {
const { sql } = req.query;
if (!sql) {
@ -158,10 +159,11 @@ CopyController.prototype.handleCopyFrom = function (req, res, next) {
} catch (err) {
next(err);
}
};
}
CopyController.prototype.responseCopyFrom = function (req, res, next) {
function responseCopyFrom () {
return function responseCopyFromMiddleware (req, res, next) {
if (!res.body || !res.body.total_rows) {
return next(new Error("No rows copied"));
}
@ -181,5 +183,6 @@ CopyController.prototype.responseCopyFrom = function (req, res, next) {
res.send(res.body);
};
}
module.exports = CopyController;