cartodb/CartoDB-SQL-API
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use console.log to log errors

Browse Source
This commit is contained in:
Daniel García Aubert 2019-05-16 17:46:59 +02:00
parent 17de6e8d4f
commit e743fefe37
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/controllers/copy_controller.js
View File

@ -36,7 +36,7 @@ CopyController.prototype.route = function (app) {
dbQuotaMiddleware(),
handleQueryMiddleware(),
handleCopyFrom(this.logger),
errorHandler(),
errorHandler(this.logger),
errorMiddleware()
];
};
@ -51,7 +51,7 @@ CopyController.prototype.route = function (app) {
validateCopyQuery(),
handleQueryMiddleware(),
handleCopyTo(this.logger),
errorHandler(),
errorHandler(this.logger),
errorMiddleware()
];
};
@ -94,7 +94,7 @@ function handleCopyTo (logger) {
.pipe(res)
.on('close', () => {
const err = new Error('Connection closed by client');
pgstream.emit('cancelQuery', err);
pgstream.emit('cancelQuery');
pgstream.emit('error', err);
})
.on('error', err => {
@ -193,10 +193,10 @@ function validateCopyQuery () {
};
}
function errorHandler () {
function errorHandler (logger) {
return function errorHandlerMiddleware (err, req, res, next) {
if (res.headersSent) {
console.error("EXCEPTION REPORT: " + err.stack);
logger.error(err);
const errorHandler = errorHandlerFactory(err);
res.write(JSON.stringify(errorHandler.getResponse()));
res.end();