cartodb/CartoDB-SQL-API
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use named params for controllers

Browse Source
This commit is contained in:
Daniel García Aubert 2020-07-01 12:32:51 +02:00
parent c4db741028
commit dc6e28097f
4 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/api/sql/copy-controller.js
View File

@ -19,7 +19,7 @@ const params = require('../middlewares/params');
const tag = require('../middlewares/tag');
module.exports = class CopyController {
constructor (metadataBackend, userDatabaseService, statsdClient, userLimitsService, logger) {
constructor ({ metadataBackend, userDatabaseService, statsdClient, userLimitsService, logger }) {
this.metadataBackend = metadataBackend;
this.userDatabaseService = userDatabaseService;
this.statsdClient = statsdClient;

2
lib/api/sql/job-controller.js
View File

@ -14,7 +14,7 @@ const params = require('../middlewares/params');
const tag = require('../middlewares/tag');
module.exports = class JobController {
constructor (metadataBackend, userDatabaseService, jobService, statsdClient, userLimitsService, logger) {
constructor ({ metadataBackend, userDatabaseService, jobService, statsdClient, userLimitsService, logger }) {
this.metadataBackend = metadataBackend;
this.userDatabaseService = userDatabaseService;
this.jobService = jobService;

8
lib/api/sql/query-controller.js
View File

@ -26,9 +26,9 @@ const { RATE_LIMIT_ENDPOINTS_GROUPS } = rateLimits;
const PSQL = require('cartodb-psql');
module.exports = class QueryController {
constructor (metadataBackend, userDatabaseService, statsdClient, userLimitsService, logger) {
constructor ({ metadataBackend, userDatabaseService, statsdClient, userLimitsService, logger }) {
this.metadataBackend = metadataBackend;
this.stats = statsdClient;
this.statsdClient = statsdClient;
this.userDatabaseService = userDatabaseService;
this.userLimitsService = userLimitsService;
this.logger = logger;
@ -40,7 +40,7 @@ module.exports = class QueryController {
const queryMiddlewares = () => {
return [
initLogger({ logger: this.logger }),
profiler({ statsClient: this.stats }),
profiler({ statsClient: this.statsdClient }),
tag({ tags: ['query'] }),
bodyParser(),
user(this.metadataBackend),
@ -60,7 +60,7 @@ module.exports = class QueryController {
lastModified(),
formatter(),
content(),
handleQuery({ stats: this.stats })
handleQuery({ stats: this.statsdClient })
];
};

12
lib/api/sql/sql-router.js
View File

@ -24,30 +24,30 @@ module.exports = class SqlRouter {
const userDatabaseService = new UserDatabaseService(metadataBackend);
const userLimitsService = new UserLimitsService(metadataBackend, userLimitsServiceOptions);
this.queryController = new QueryController(
this.queryController = new QueryController({
metadataBackend,
userDatabaseService,
statsClient,
userLimitsService,
logger
);
});
this.copyController = new CopyController(
this.copyController = new CopyController({
metadataBackend,
userDatabaseService,
statsClient,
userLimitsService,
logger
);
});
this.jobController = new JobController(
this.jobController = new JobController({
metadataBackend,
userDatabaseService,
jobService,
statsClient,
userLimitsService,
logger
);
});
}
route (apiRouter, routes) {