Use strict mode

app.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 /*
 * SQL API loader
 * ===============

app/auth/apikey.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * this module allows to auth user using an pregenerated api key
  */

app/auth/auth_api.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var ApiKeyAuth = require('./apikey'),
     OAuthAuth  = require('./oauth');
 

app/auth/oauth.js

@@ -1,3 +1,5 @@
+'use strict';
+
 // too bound to the request object, but ok for now
 var _ = require('underscore');
 var OAuthUtil = require('oauth-client');

app/controllers/job_controller.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const util = require('util');
 
 const bodyParserMiddleware = require('../middlewares/body-parser');

app/middlewares/authorization.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const AuthApi = require('../auth/auth_api');
 const basicAuth = require('basic-auth');
 

app/middlewares/body-parser.js

@@ -1,3 +1,4 @@
+'use strict';
 
 /*!
  * Connect - bodyParser

app/middlewares/connection-params.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function connectionParams (userDatabaseService) {
     return function connectionParamsMiddleware (req, res, next) {
         const { user, api_key: apikeyToken, authorizationLevel } = res.locals;

app/middlewares/db-quota.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const PSQL = require('cartodb-psql');
 
 const remainingQuotaQuery = 'SELECT _CDB_UserQuotaInBytes() - CDB_UserDataSize(current_schema()) AS remaining_quota';

app/middlewares/error.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const errorHandlerFactory = require('../services/error_handler_factory');
 
 module.exports = function error() {

app/middlewares/profiler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports.initializeProfilerMiddleware = function initializeProfiler (label) {
     return function initializeProfilerMiddleware (req, res, next) {
         if (req.profiler) {

app/middlewares/timeout-limits.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function timeoutLimits (metadataBackend) {
     return function timeoutLimitsMiddleware (req, res, next) {
         const { user, authorizationLevel } = res.locals;

app/middlewares/user.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const CdbRequest = require('../models/cartodb_request');
 
 module.exports = function user(metadataBackend) {

app/models/bin_encoder.js

@@ -1,3 +1,4 @@
+'use strict';
 
 function ArrayBufferSer(type, data, options) {
   if(type === undefined) {

app/models/cartodb_request.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * this module provides cartodb-specific interpretation
  * of request headers

app/models/formats/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var fs = require("fs");
 var formats = {};
 

app/models/formats/ogr.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var crypto = require('crypto');
 var step = require('step');
 var fs = require('fs');

app/models/formats/ogr/csv.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var ogr = require('./../ogr');
 
 function CsvFormat() {}

app/models/formats/ogr/geopackage.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var ogr = require('./../ogr');
 
 function GeoPackageFormat() {}

app/models/formats/ogr/kml.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var ogr = require('./../ogr');
 
 function KmlFormat() {}

app/models/formats/ogr/shp.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var step = require('step');
 var fs = require('fs');
 var spawn = require('child_process').spawn;

app/models/formats/ogr/spatialite.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var ogr = require('./../ogr');
 
 function SpatiaLiteFormat() {}

app/models/formats/pg.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var step = require('step');
 var PSQL = require('cartodb-psql');
 var assert = require('assert');

app/models/formats/pg/arraybuffer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('underscore');
 
 var pg  = require('./../pg');

app/models/formats/pg/geojson.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('underscore');
 
 var pg  = require('./../pg');

app/models/formats/pg/json.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('underscore');
 
 var pg  = require('./../pg');

app/models/formats/pg/svg.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var pg  = require('./../pg');
 
 var svg_width  = 1024.0;

app/models/formats/pg/topojson.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var pg  = require('./../pg');
 var _ = require('underscore');
 var geojson = require('./geojson');

app/monitoring/health_check.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var step = require('step'),
     fs   = require('fs');
 

app/postgresql/error_codes.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('underscore');
 
 // reference http://www.postgresql.org/docs/9.3/static/errcodes-appendix.html

app/server.js

@@ -1,3 +1,5 @@
+'use strict';
+
 // CartoDB SQL API
 //
 // all requests expect the following URL args:

app/services/cached-query-tables.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var QueryTables = require('cartodb-query-tables');
 
 var generateMD5 = require('../utils/md5');

app/services/error_handler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 class ErrorHandler extends Error {
     constructor({ message, context, detail, hint, http_status, name }) {
         super(message);

app/services/error_handler_factory.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const ErrorHandler = require('./error_handler');
 const { codeToCondition } = require('../postgresql/error_codes');
 

app/services/pg-entities-access-validator.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const FORBIDDEN_ENTITIES = {
     carto: ['*'],
     cartodb: [

app/services/stream_copy.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const PSQL = require('cartodb-psql');
 const copyTo = require('pg-copy-streams').to;
 const copyFrom = require('pg-copy-streams').from;

app/services/stream_copy_metrics.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { getFormatFromCopyQuery } = require('../utils/query_info');
 
 module.exports = class StreamCopyMetrics {

app/services/user_database_service.js

@@ -1,3 +1,5 @@
+'use strict';
+
 function isApiKeyFound(apikey) {
     return apikey.type !== null &&
         apikey.user !== null &&

app/services/user_limits.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * UserLimits
  * @param {cartodb-redis} metadataBackend

app/stats/client.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('underscore');
 var debug = require('debug')('windshaft:stats_client');
 var StatsD = require('node-statsd').StatsD;

app/stats/profiler-proxy.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var Profiler = require('step-profiler');
 
 /**

app/utils/query_info.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const COPY_FORMATS = ['TEXT', 'CSV', 'BINARY'];
 
 module.exports = {

client/bin_decoder.js

@@ -1,4 +1,4 @@
-
+'use strict';
 
 function ArrayBufferSer(arrayBuffer) {
   this.buffer = arrayBuffer;

test/acceptance/app-configuration.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/app.auth.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/app.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Requires the database and tables setup in config/environments/test.js to exist

test/acceptance/auth-api.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const assert = require('../support/assert');
 const TestClient = require('../support/test-client');
 const BatchTestClient = require('../support/batch-test-client');

test/acceptance/backend_crash.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var assert = require('../support/assert');

test/acceptance/batch/batch-drain.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 var assert = require('../../support/assert');
 var redisUtils = require('../../support/redis_utils');

test/acceptance/batch/batch-limits.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/batch/batch.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/batch/batch.wip.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/batch/job.callback-template.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/batch/job.fallback.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/batch/job.query.limit.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Requires the database and tables setup in config/environments/test.js to exist

test/acceptance/batch/job.query.order.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 var assert = require('../../support/assert');
 

test/acceptance/batch/job.query.timeout.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 var assert = require('../../support/assert');
 

test/acceptance/batch/job.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Requires the database and tables setup in config/environments/test.js to exist

test/acceptance/batch/job.timing.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var BatchTestClient = require('../../support/batch-test-client');

test/acceptance/batch/leader-multiple-users-query-order.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 var assert = require('../../support/assert');
 

test/acceptance/batch/leader.job.query.order.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 var assert = require('../../support/assert');
 

test/acceptance/batch/queued-jobs-limit.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/batch/scheduler-basic.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 var assert = require('../../support/assert');
 

test/acceptance/batch/use-cases.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var assert = require('../../support/assert');

test/acceptance/cache.js

@@ -1,4 +1,4 @@
-'use const';
+'use strict';
 
 var server = require('../../app/server')();
 const assert = require('../support/assert');

test/acceptance/copy-abort.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const querystring = require('querystring');
 const StatsClient = require('../../app/stats/client');
 const statsClient = StatsClient.getInstance(global.settings.statsd);

test/acceptance/copy-endpoints.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 const fs = require('fs');

test/acceptance/copy-statements.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/error-handler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var server = require('../../app/server')();
 var assert = require('../support/assert');
 

test/acceptance/export/arraybuffer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 require('../../support/assert');
 

test/acceptance/export/csv.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 require('../../support/assert');
 

test/acceptance/export/folder.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 require('../../support/assert');
 

test/acceptance/export/geojson.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/export/geopackage.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/export/kml.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/export/shapefile.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/export/spatialite.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/export/svg.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/export/timeout.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const TestClient = require('../../support/test-client');
 
 require('../../support/assert');

test/acceptance/export/topojson.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../../helper');
 
 var server = require('../../../app/server')();

test/acceptance/frontend_abort.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var assert = require('../support/assert');

test/acceptance/health_check.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 require('../support/assert');
 

test/acceptance/last-modified-header.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/logging.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var appServer = require('../../app/server');

test/acceptance/pagination.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/pg-entities-access-validator.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const assert = require('../support/assert');
 const TestClient = require('../support/test-client');
 

test/acceptance/query-float-values.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/query-multipart.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 const server = require('../../app/server')();

test/acceptance/query-returning.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/query-tables-api-cache.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var qs = require('querystring');

test/acceptance/rate-limit.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 const qs = require('querystring');

test/acceptance/regressions.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/skipfields.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/stream-responses.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/surrogate-key.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/system-queries.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/acceptance/timeout.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Requires the database and tables setup in config/environments/test.js to exist

test/acceptance/transaction.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var assert = require('../support/assert');

test/acceptance/x-cache-channel.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('../helper');
 
 var server = require('../../app/server')();

test/helper.js

@@ -1,2 +1,4 @@
+'use strict';
+
 global.settings = require('../config/environments/test');
 process.env.NODE_ENV = 'test';