Moved userDatabaseMetadataService from job_runner to query_runner

batch/index.js

@@ -24,11 +24,10 @@ module.exports = function batchFactory (metadataBackend) {
     var userIndexer = new UserIndexer(metadataBackend);
     var jobBackend = new JobBackend(metadataBackend, jobQueue, jobPublisher, userIndexer);
     var userDatabaseMetadataService = new UserDatabaseMetadataService(metadataBackend);
-    // TODO: down userDatabaseMetadataService
+    var queryRunner = new QueryRunner(userDatabaseMetadataService);
-    var queryRunner = new QueryRunner();
     var jobCanceller = new JobCanceller(userDatabaseMetadataService);
     var jobService = new JobService(jobBackend, jobCanceller);
-    var jobRunner = new JobRunner(jobService, jobQueue, queryRunner, userDatabaseMetadataService);
+    var jobRunner = new JobRunner(jobService, jobQueue, queryRunner);
 
     return new Batch(jobSubscriber, jobQueuePool, jobRunner, jobService);
 };

batch/job_runner.js

@@ -3,11 +3,10 @@
 var errorCodes = require('../app/postgresql/error_codes').codeToCondition;
 var jobStatus = require('./job_status');
 
-function JobRunner(jobService, jobQueue, queryRunner, userDatabaseMetadataService) {
+function JobRunner(jobService, jobQueue, queryRunner) {
     this.jobService = jobService;
     this.jobQueue = jobQueue;
     this.queryRunner = queryRunner;
-    this.userDatabaseMetadataService = userDatabaseMetadataService; // TODO: move to queryRunner
 }
 
 JobRunner.prototype.run = function (job_id, callback) {
@@ -39,47 +38,40 @@ JobRunner.prototype.run = function (job_id, callback) {
 JobRunner.prototype._run = function (job, query, callback) {
     var self = this;
 
-    // TODO: move to query
+    self.queryRunner.run(job.data.job_id, query, job.data.user, function (err /*, result */) {
-    self.userDatabaseMetadataService.getUserMetadata(job.data.user, function (err, userDatabaseMetadata) {
         if (err) {
+            // if query has been cancelled then it's going to get the current
+            // job status saved by query_canceller
+            if (errorCodes[err.code.toString()] === 'query_canceled') {
+                return self.jobService.get(job.data.job_id, callback);
+            }
+        }
+
+        try {
+            if (err) {
+                job.setStatus(jobStatus.FAILED, err.message);
+            } else {
+                job.setStatus(jobStatus.DONE);
+            }
+        } catch (err) {
             return callback(err);
         }
 
-        self.queryRunner.run(job.data.job_id, query, userDatabaseMetadata, function (err /*, result */) {
+        self.jobService.save(job, function (err, job) {
             if (err) {
-                // if query has been cancelled then it's going to get the current
-                // job status saved by query_canceller
-                if (errorCodes[err.code.toString()] === 'query_canceled') {
-                    return self.jobService.get(job.data.job_id, callback);
-                }
-            }
-
-            try {
-                if (err) {
-                    job.setStatus(jobStatus.FAILED, err.message);
-                } else {
-                    job.setStatus(jobStatus.DONE);
-                }
-            } catch (err) {
                 return callback(err);
             }
 
-            self.jobService.save(job, function (err, job) {
+            if (!job.hasNextQuery()) {
+                return callback(null, job);
+            }
+
+            self.jobQueue.enqueue(job.data.job_id, job.data.host, function (err) {
                 if (err) {
                     return callback(err);
                 }
 
-                if (!job.hasNextQuery()) {
+                callback(null, job);
-                    return callback(null, job);
-                }
-
-                self.jobQueue.enqueue(job.data.job_id, userDatabaseMetadata.host, function (err) {
-                    if (err) {
-                        return callback(err);
-                    }
-
-                    callback(null, job);
-                });
             });
         });
     });

batch/models/job_base.js

@@ -19,6 +19,7 @@ var mandatoryProperties = [
     'query',
     'created_at',
     'updated_at',
+    'host',
     'user'
 ];
 

batch/query_runner.js

@@ -2,37 +2,43 @@
 
 var PSQL = require('cartodb-psql');
 
-function QueryRunner() {
+function QueryRunner(userDatabaseMetadataService) {
+    this.userDatabaseMetadataService = userDatabaseMetadataService;
 }
 
 module.exports = QueryRunner;
 
-QueryRunner.prototype.run = function (job_id, sql, userDatabaseMetadata, callback) {
+QueryRunner.prototype.run = function (job_id, sql, user, callback) {
-    var pg = new PSQL(userDatabaseMetadata, {}, { destroyOnError: true });
+    this.userDatabaseMetadataService.getUserMetadata(user, function (err, userDatabaseMetadata) {
-
+        if (err) {
-    pg.query('SET statement_timeout=0', function (err) {
-        if(err) {
             return callback(err);
         }
 
-        // mark query to allow to users cancel their queries
+        var pg = new PSQL(userDatabaseMetadata, {}, { destroyOnError: true });
-        sql = '/* ' + job_id + ' */ ' + sql;
 
-        pg.eventedQuery(sql, function (err, query) {
+        pg.query('SET statement_timeout=0', function (err) {
-            if (err) {
+            if(err) {
                 return callback(err);
             }
 
-            query.on('error', callback);
+            // mark query to allow to users cancel their queries
+            sql = '/* ' + job_id + ' */ ' + sql;
 
-            query.on('end', function (result) {
+            pg.eventedQuery(sql, function (err, query) {
-                // only if result is present then query is done sucessfully otherwise an error has happened
+                if (err) {
-                // and it was handled by error listener
+                    return callback(err);
-                if (result) {
-                    callback(null, result);
                 }
+
+                query.on('error', callback);
+
+                query.on('end', function (result) {
+                    // only if result is present then query is done sucessfully otherwise an error has happened
+                    // and it was handled by error listener
+                    if (result) {
+                        callback(null, result);
+                    }
+                });
             });
         });
     });
-
 };