cartodb/CartoDB-SQL-API
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed commented healthcheck tests

Browse Source
This commit is contained in:
Luis Bosque 2015-04-06 19:04:28 +02:00
parent 21cbdfd4a3
commit 0b63c35e85
2 changed files with 0 additions and 115 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
test/acceptance/health_check.js
View File

@ -65,52 +65,4 @@ suite('health checks', function() {
);
});
//test('fails for invalid user because it is not in redis', function(done) {
// global.settings.health.username = 'invalid';
// assert.response(app,
// healthCheckRequest,
// {
// status: 503
// },
// function(res, err) {
// assert.ok(!err);
// var parsed = JSON.parse(res.body);
// assert.equal(parsed.enabled, true);
// assert.equal(parsed.ok, false);
// assert.equal(parsed.result.redis.ok, false);
// done();
// }
// );
//});
//test('fails for wrong query', function(done) {
// global.settings.health.query = 'select wadus query';
// assert.response(app,
// healthCheckRequest,
// {
// status: 503
// },
// function(res, err) {
// assert.ok(!err);
// var parsed = JSON.parse(res.body);
// assert.equal(parsed.enabled, true);
// assert.equal(parsed.ok, false);
// assert.ok(parsed.result.redis.ok);
// assert.equal(parsed.result.postgresql.ok, false);
// done();
// }
// );
//});
});

67
test/unit/health_check.js
View File

@ -14,66 +14,6 @@ var healthCheck = new HealthCheck(metadataBackend, PSQL);
suite('health checks', function() {
//beforeEach(function(done) {
// mockGetAllUserDBParams(function(username, callback) {
// callback(null, {user: 'fake', dbname: 'fake'});
// });
// mockQuery(function(query, callback) {
// callback(null, {rows: [{},{},{}]});
// });
// done();
//});
//test('happy case, everything goes OK', function(done) {
// healthCheck.check('fake', 'select 1::text', function(err, result) {
// assert.ok(result.redis.ok);
// assert.ok(result.redis.elapsed >= 0);
// assert.equal(result.redis.count, 2);
// assert.ok(result.postgresql.ok);
// assert.ok(result.postgresql.elapsed >= 0);
// assert.ok(result.postgresql.count, 3);
// done();
// });
//});
//test('error in metadataBackend reports as false and does not report postgresql except ok=false', function(done) {
// mockGetAllUserDBParams(function() {
// throw "Error";
// });
// healthCheck.check('fake', 'select 1::text', function(err, result) {
// assert.equal(result.redis.ok, false);
// assert.ok(result.redis.elapsed >= 0);
// assert.ok(_.isUndefined(result.redis.count));
// assert.equal(result.postgresql.ok, false);
// assert.ok(_.isUndefined(result.postgresql.elapsed));
// assert.ok(_.isUndefined(result.postgresql.count));
// done();
// });
//});
//test('error in metadataBackend reports as false and does not report postgresql except ok=false', function(done) {
// mockQuery(function() {
// throw "Error";
// });
// healthCheck.check('fake', 'select 1::text', function(err, result) {
// assert.ok(result.redis.ok);
// assert.ok(result.redis.elapsed >= 0);
// assert.equal(result.redis.count, 2);
// assert.equal(result.postgresql.ok, false);
// assert.ok(_.isUndefined(result.postgresql.elapsed));
// assert.ok(_.isUndefined(result.postgresql.count));
// done();
// });
//});
test('error if disabled file exists', function(done) {
var fs = require('fs');
@ -103,11 +43,4 @@ suite('health checks', function() {
});
});
//function mockGetAllUserDBParams(func) {
// metadataBackend.getAllUserDBParams = func;
//}
//function mockQuery(func) {
// PSQL.prototype.query = func;
//}
});