From f0589f985e755301234683ab76b62652e2a8aa86 Mon Sep 17 00:00:00 2001
From: Davis King <davis@dlib.net>
Date: Sat, 13 Oct 2012 19:29:05 -0400
Subject: [PATCH] Made the BSP routines take their function arguments by value
 rather than by reference.

---
 dlib/bsp/bsp.h          | 40 ++++++++++++++++++++--------------------
 dlib/bsp/bsp_abstract.h | 20 ++++++++++----------
 2 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/dlib/bsp/bsp.h b/dlib/bsp/bsp.h
index a7662820e..7e4662cb3 100644
--- a/dlib/bsp/bsp.h
+++ b/dlib/bsp/bsp.h
@@ -293,7 +293,7 @@ namespace dlib
             >
         friend void bsp_connect (
             const std::vector<std::pair<std::string,unsigned short> >& hosts,
-            funct_type& funct
+            funct_type funct
         );
 
         template <
@@ -302,7 +302,7 @@ namespace dlib
             >
         friend void bsp_connect (
             const std::vector<std::pair<std::string,unsigned short> >& hosts,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1
         );
 
@@ -313,7 +313,7 @@ namespace dlib
             >
         friend void bsp_connect (
             const std::vector<std::pair<std::string,unsigned short> >& hosts,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1,
             ARG2 arg2
         );
@@ -326,7 +326,7 @@ namespace dlib
             >
         friend void bsp_connect (
             const std::vector<std::pair<std::string,unsigned short> >& hosts,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1,
             ARG2 arg2,
             ARG3 arg3
@@ -341,7 +341,7 @@ namespace dlib
             >
         friend void bsp_connect (
             const std::vector<std::pair<std::string,unsigned short> >& hosts,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1,
             ARG2 arg2,
             ARG3 arg3,
@@ -355,7 +355,7 @@ namespace dlib
             >
         friend void bsp_listen (
             unsigned short listening_port,
-            funct_type& funct
+            funct_type funct
         );
 
         template <
@@ -364,7 +364,7 @@ namespace dlib
             >
         friend void bsp_listen (
             unsigned short listening_port,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1
         );
 
@@ -375,7 +375,7 @@ namespace dlib
             >
         friend void bsp_listen (
             unsigned short listening_port,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1,
             ARG2 arg2
         );
@@ -388,7 +388,7 @@ namespace dlib
             >
         friend void bsp_listen (
             unsigned short listening_port,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1,
             ARG2 arg2,
             ARG3 arg3
@@ -403,7 +403,7 @@ namespace dlib
             >
         friend void bsp_listen (
             unsigned short listening_port,
-            funct_type& funct,
+            funct_type funct,
             ARG1 arg1,
             ARG2 arg2,
             ARG3 arg3,
@@ -423,7 +423,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct
+        funct_type funct
     )
     {
         impl1::map_id_to_con cons;
@@ -443,7 +443,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1
     )
     {
@@ -465,7 +465,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2
     )
@@ -489,7 +489,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3
@@ -515,7 +515,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3,
@@ -540,7 +540,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct
+        funct_type funct
     )
     {
         impl1::map_id_to_con cons;
@@ -559,7 +559,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1
     )
     {
@@ -580,7 +580,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2
     )
@@ -603,7 +603,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3
@@ -628,7 +628,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3,
diff --git a/dlib/bsp/bsp_abstract.h b/dlib/bsp/bsp_abstract.h
index a5fe621e4..0c5c1687a 100644
--- a/dlib/bsp/bsp_abstract.h
+++ b/dlib/bsp/bsp_abstract.h
@@ -120,7 +120,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct
+        funct_type funct
     );
 
 // ----------------------------------------------------------------------------------------
@@ -131,7 +131,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1
     );
 
@@ -144,7 +144,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2
     );
@@ -159,7 +159,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3
@@ -176,7 +176,7 @@ namespace dlib
         >
     void bsp_connect (
         const std::vector<std::pair<std::string,unsigned short> >& hosts,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3,
@@ -191,7 +191,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct
+        funct_type funct
     );
 
 // ----------------------------------------------------------------------------------------
@@ -202,7 +202,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1
     );
 
@@ -215,7 +215,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2
     );
@@ -230,7 +230,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3
@@ -247,7 +247,7 @@ namespace dlib
         >
     void bsp_listen (
         unsigned short listening_port,
-        funct_type& funct,
+        funct_type funct,
         ARG1 arg1,
         ARG2 arg2,
         ARG3 arg3,