mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-30 06:21:09 +08:00
26e1570dd6
* iframe title in AppTile Signed-off-by: Kerry Archibald <kerrya@element.io> * iframe title in hostSignupDialog Signed-off-by: Kerry Archibald <kerrya@element.io> * iframe title in MFileBody * iframe titles in modal widget and int man Signed-off-by: Kerry Archibald <kerrya@element.io> * enable jsx-a11y/iframe-has-title rule Signed-off-by: Kerry Archibald <kerrya@element.io>
106 lines
3.4 KiB
JavaScript
106 lines
3.4 KiB
JavaScript
module.exports = {
|
|
plugins: [
|
|
"matrix-org",
|
|
],
|
|
extends: [
|
|
"plugin:matrix-org/babel",
|
|
"plugin:matrix-org/react",
|
|
"plugin:matrix-org/a11y",
|
|
],
|
|
env: {
|
|
browser: true,
|
|
node: true,
|
|
},
|
|
globals: {
|
|
LANGUAGES_FILE: "readonly",
|
|
},
|
|
rules: {
|
|
// Things we do that break the ideal style
|
|
"no-constant-condition": "off",
|
|
"prefer-promise-reject-errors": "off",
|
|
"no-async-promise-executor": "off",
|
|
"quotes": "off",
|
|
"no-extra-boolean-cast": "off",
|
|
|
|
// Bind or arrow functions in props causes performance issues (but we
|
|
// currently use them in some places).
|
|
// It's disabled here, but we should using it sparingly.
|
|
"react/jsx-no-bind": "off",
|
|
"react/jsx-key": ["error"],
|
|
|
|
"no-restricted-properties": [
|
|
"error",
|
|
...buildRestrictedPropertiesOptions(
|
|
["window.innerHeight", "window.innerWidth", "window.visualViewport"],
|
|
"Use UIStore to access window dimensions instead.",
|
|
),
|
|
...buildRestrictedPropertiesOptions(
|
|
["*.mxcUrlToHttp", "*.getHttpUriForMxc"],
|
|
"Use Media helper instead to centralise access for customisation.",
|
|
),
|
|
],
|
|
|
|
// There are too many a11y violations to fix at once
|
|
// Turn violated rules off until they are fixed
|
|
"jsx-a11y/alt-text": "off",
|
|
"jsx-a11y/aria-activedescendant-has-tabindex": "off",
|
|
"jsx-a11y/click-events-have-key-events": "off",
|
|
"jsx-a11y/interactive-supports-focus": "off",
|
|
"jsx-a11y/label-has-associated-control": "off",
|
|
"jsx-a11y/media-has-caption": "off",
|
|
"jsx-a11y/mouse-events-have-key-events": "off",
|
|
"jsx-a11y/no-autofocus": "off",
|
|
"jsx-a11y/no-noninteractive-element-interactions": "off",
|
|
"jsx-a11y/no-noninteractive-element-to-interactive-role": "off",
|
|
"jsx-a11y/no-noninteractive-tabindex": "off",
|
|
"jsx-a11y/no-static-element-interactions": "off",
|
|
"jsx-a11y/role-supports-aria-props": "off",
|
|
"jsx-a11y/tabindex-no-positive": "off",
|
|
},
|
|
overrides: [{
|
|
files: [
|
|
"src/**/*.{ts,tsx}",
|
|
"test/**/*.{ts,tsx}",
|
|
],
|
|
extends: [
|
|
"plugin:matrix-org/typescript",
|
|
"plugin:matrix-org/react",
|
|
],
|
|
rules: {
|
|
// Things we do that break the ideal style
|
|
"prefer-promise-reject-errors": "off",
|
|
"quotes": "off",
|
|
"no-extra-boolean-cast": "off",
|
|
|
|
// Remove Babel things manually due to override limitations
|
|
"@babel/no-invalid-this": ["off"],
|
|
|
|
// We're okay being explicit at the moment
|
|
"@typescript-eslint/no-empty-interface": "off",
|
|
// We disable this while we're transitioning
|
|
"@typescript-eslint/no-explicit-any": "off",
|
|
// We'd rather not do this but we do
|
|
"@typescript-eslint/ban-ts-comment": "off",
|
|
},
|
|
}],
|
|
settings: {
|
|
react: {
|
|
version: "detect",
|
|
},
|
|
},
|
|
};
|
|
|
|
function buildRestrictedPropertiesOptions(properties, message) {
|
|
return properties.map(prop => {
|
|
let [object, property] = prop.split(".");
|
|
if (object === "*") {
|
|
object = undefined;
|
|
}
|
|
return {
|
|
object,
|
|
property,
|
|
message,
|
|
};
|
|
});
|
|
}
|