mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-25 09:58:11 +08:00
cf8b87fd14
* Create new method for header button behaviour With the introduction of tabs, the behaviour of the header buttons is changed as follows: - Close any right panel if open - Open the correct right panel if no panel was open before The old method (and behaviour) is retained as showOrHidePhase. * Implement tabs in the right panel There are three tabs: Info, People and Threads * Remove unwanted code from RoomSummaryCard - Remove the menu item for opening the memberlist since that is now taken of by the tabs. - Remove the close button * Remove code for focusing close button from tac item See https://github.com/matrix-org/matrix-react-sdk/pull/12410 There's no longer a close button to focus so we instead focus the thread tab. This is done in RightPaneltabs.tsx so we just need to remove this code. * Introduce a room info icon to the header This was previously present in the legacy room header but not in the new header. * BaseCard changes - Adds id, ariaLabelledBy and role props to implement tab accessibility. - Adds hideHeaderButtons prop to hide header buttons (think back and close buttons). - Change confusing header rendering code: header is not rendered ONLY when no header is passed AND hideHeaderButtons is true. * Refactor repeated code into function Created a new function createSpaceScopeHeader which returns the component if the room is a space room. Previously this code was duplicated in every component that uses SpaceScopeHeader component. * Pass BaseCard attributes and use helper function Actually using the code from the last two commits * Add, update and remove tests/screenshots/snapshots * Fix distance between search bar and tabs * Update compound * Update screenshots/snapshots
120 lines
2.5 KiB
Plaintext
120 lines
2.5 KiB
Plaintext
// Jest Snapshot v1, https://goo.gl/fbAQLP
|
|
|
|
exports[`<RightPanelTabs /> Component renders the correct tabs 1`] = `
|
|
<div>
|
|
<nav
|
|
class="mx_RightPanelTabs _nav-bar_135dy_16"
|
|
role="presentation"
|
|
>
|
|
<ul
|
|
aria-label="right panel"
|
|
class="_nav-bar-items_135dy_22"
|
|
role="tablist"
|
|
>
|
|
<li
|
|
class="_nav-tab_135dy_33"
|
|
data-current="true"
|
|
role="presentation"
|
|
>
|
|
<button
|
|
aria-controls="room-summary-panel"
|
|
aria-selected="true"
|
|
class="_nav-item_135dy_55"
|
|
id="room-summary-panel-tab"
|
|
role="tab"
|
|
>
|
|
Info
|
|
</button>
|
|
</li>
|
|
<li
|
|
class="_nav-tab_135dy_33"
|
|
role="presentation"
|
|
>
|
|
<button
|
|
aria-controls="memberlist-panel"
|
|
aria-selected="false"
|
|
class="_nav-item_135dy_55"
|
|
id="memberlist-panel-tab"
|
|
role="tab"
|
|
>
|
|
People
|
|
</button>
|
|
</li>
|
|
<li
|
|
class="_nav-tab_135dy_33"
|
|
role="presentation"
|
|
>
|
|
<button
|
|
aria-controls="thread-panel"
|
|
aria-selected="false"
|
|
class="_nav-item_135dy_55"
|
|
id="thread-panel-tab"
|
|
role="tab"
|
|
>
|
|
Threads
|
|
</button>
|
|
</li>
|
|
</ul>
|
|
</nav>
|
|
</div>
|
|
`;
|
|
|
|
exports[`<RightPanelTabs /> Correct tab is active 1`] = `
|
|
<div>
|
|
<nav
|
|
class="mx_RightPanelTabs _nav-bar_135dy_16"
|
|
role="presentation"
|
|
>
|
|
<ul
|
|
aria-label="right panel"
|
|
class="_nav-bar-items_135dy_22"
|
|
role="tablist"
|
|
>
|
|
<li
|
|
class="_nav-tab_135dy_33"
|
|
role="presentation"
|
|
>
|
|
<button
|
|
aria-controls="room-summary-panel"
|
|
aria-selected="false"
|
|
class="_nav-item_135dy_55"
|
|
id="room-summary-panel-tab"
|
|
role="tab"
|
|
>
|
|
Info
|
|
</button>
|
|
</li>
|
|
<li
|
|
class="_nav-tab_135dy_33"
|
|
data-current="true"
|
|
role="presentation"
|
|
>
|
|
<button
|
|
aria-controls="memberlist-panel"
|
|
aria-selected="true"
|
|
class="_nav-item_135dy_55"
|
|
id="memberlist-panel-tab"
|
|
role="tab"
|
|
>
|
|
People
|
|
</button>
|
|
</li>
|
|
<li
|
|
class="_nav-tab_135dy_33"
|
|
role="presentation"
|
|
>
|
|
<button
|
|
aria-controls="thread-panel"
|
|
aria-selected="false"
|
|
class="_nav-item_135dy_55"
|
|
id="thread-panel-tab"
|
|
role="tab"
|
|
>
|
|
Threads
|
|
</button>
|
|
</li>
|
|
</ul>
|
|
</nav>
|
|
</div>
|
|
`;
|