mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-27 02:48:39 +08:00
c894bebaa0
* Split up slow Playwright tests To optimise parallelism Deals with: ``` Slow test file: read-receipts/redactions.spec.ts (5.4m) Slow test file: read-receipts/new-messages.spec.ts (3.9m) Slow test file: read-receipts/high-level.spec.ts (3.6m) Slow test file: read-receipts/editing-messages.spec.ts (3.1m) Slow test file: read-receipts/reactions.spec.ts (2.2m) Slow test file: crypto/crypto.spec.ts (2.4m) Slow test file: settings/appearance-user-settings-tab/appearance-user-settings-tab.spec.ts (1.2m) Slow test file: composer/composer.spec.ts (1.1m) Slow test file: crypto/verification.spec.ts (1.1m) ``` Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Move around snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Fix test Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> |
||
|---|---|---|
| .. | ||
| editing-messages-in-threads.spec.ts | ||
| editing-messages-main-timeline.spec.ts | ||
| editing-messages-thread-roots.spec.ts | ||
| high-level.spec.ts | ||
| index.ts | ||
| message-ordering.spec.ts | ||
| missing-referents.spec.ts | ||
| new-messages-in-threads.spec.ts | ||
| new-messages-main-timeline.spec.ts | ||
| new-messages-thread-roots.spec.ts | ||
| notifications.spec.ts | ||
| reactions-in-threads.spec.ts | ||
| reactions-main-timeline.spec.ts | ||
| reactions-thread-roots.spec.ts | ||
| read-receipts.spec.ts | ||
| readme.md | ||
| redactions-in-threads.spec.ts | ||
| redactions-main-timeline.spec.ts | ||
| redactions-thread-roots.spec.ts | ||
| room-list-order.spec.ts | ||
High Level Read Receipt Tests
Tips for writing these tests:
-
Break up your tests into the smallest test case possible. The purpose of these tests is to understand hard-to-find bugs, so small tests are necessary. We know that Playwright recommends combining tests together for performance, but that will frustrate our goals here. (We will need to find a different way to reduce CI time.)
-
Try to assert something after every action, to make sure it has completed. E.g.: markAsRead(room2); assertRead(room2); You should especially follow this rule if you are jumping to a different room or similar straight afterward.
-
Use assertStillRead() if you are asserting something is read when it was also read before. This waits a little while to make sure you're not getting a false positive.