mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-23 16:49:23 +08:00
cf8b87fd14
* Create new method for header button behaviour With the introduction of tabs, the behaviour of the header buttons is changed as follows: - Close any right panel if open - Open the correct right panel if no panel was open before The old method (and behaviour) is retained as showOrHidePhase. * Implement tabs in the right panel There are three tabs: Info, People and Threads * Remove unwanted code from RoomSummaryCard - Remove the menu item for opening the memberlist since that is now taken of by the tabs. - Remove the close button * Remove code for focusing close button from tac item See https://github.com/matrix-org/matrix-react-sdk/pull/12410 There's no longer a close button to focus so we instead focus the thread tab. This is done in RightPaneltabs.tsx so we just need to remove this code. * Introduce a room info icon to the header This was previously present in the legacy room header but not in the new header. * BaseCard changes - Adds id, ariaLabelledBy and role props to implement tab accessibility. - Adds hideHeaderButtons prop to hide header buttons (think back and close buttons). - Change confusing header rendering code: header is not rendered ONLY when no header is passed AND hideHeaderButtons is true. * Refactor repeated code into function Created a new function createSpaceScopeHeader which returns the component if the room is a space room. Previously this code was duplicated in every component that uses SpaceScopeHeader component. * Pass BaseCard attributes and use helper function Actually using the code from the last two commits * Add, update and remove tests/screenshots/snapshots * Fix distance between search bar and tabs * Update compound * Update screenshots/snapshots
153 lines
6.7 KiB
TypeScript
153 lines
6.7 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { Locator, type Page } from "@playwright/test";
|
|
|
|
import { test, expect } from "../../element-web-test";
|
|
import { checkRoomSummaryCard, viewRoomSummaryByName } from "./utils";
|
|
|
|
const ROOM_NAME = "Test room";
|
|
const ROOM_NAME_LONG =
|
|
"Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore " +
|
|
"et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut " +
|
|
"aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum " +
|
|
"dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui " +
|
|
"officia deserunt mollit anim id est laborum.";
|
|
const SPACE_NAME = "Test space";
|
|
const NAME = "Alice";
|
|
const ROOM_ADDRESS_LONG =
|
|
"loremIpsumDolorSitAmetConsecteturAdipisicingElitSedDoEiusmodTemporIncididuntUtLaboreEtDoloreMagnaAliqua";
|
|
|
|
function getMemberTileByName(page: Page, name: string): Locator {
|
|
return page.locator(`.mx_EntityTile, [title="${name}"]`);
|
|
}
|
|
|
|
test.describe("RightPanel", () => {
|
|
test.use({
|
|
displayName: NAME,
|
|
});
|
|
|
|
test.beforeEach(async ({ app, user }) => {
|
|
await app.client.createRoom({ name: ROOM_NAME });
|
|
await app.client.createSpace({ name: SPACE_NAME });
|
|
});
|
|
|
|
test.describe("in rooms", () => {
|
|
test("should handle long room address and long room name", async ({ page, app }) => {
|
|
await app.client.createRoom({ name: ROOM_NAME_LONG });
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME_LONG);
|
|
|
|
await app.settings.openRoomSettings();
|
|
|
|
// Set a local room address
|
|
const localAddresses = page.locator(".mx_SettingsFieldset", { hasText: "Local Addresses" });
|
|
await localAddresses.getByRole("textbox").fill(ROOM_ADDRESS_LONG);
|
|
await localAddresses.getByRole("button", { name: "Add" }).click();
|
|
await expect(localAddresses.getByText(`#${ROOM_ADDRESS_LONG}:localhost`)).toHaveClass(
|
|
"mx_EditableItem_item",
|
|
);
|
|
|
|
await app.closeDialog();
|
|
|
|
// Close and reopen the right panel to render the room address
|
|
await page.getByRole("button", { name: "Room info" }).click();
|
|
await expect(page.locator(".mx_RightPanel")).not.toBeVisible();
|
|
await page.getByRole("button", { name: "Room info" }).click();
|
|
|
|
await expect(page.locator(".mx_RightPanel")).toMatchScreenshot("with-name-and-address.png");
|
|
});
|
|
|
|
test("should handle clicking add widgets", async ({ page, app }) => {
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME);
|
|
|
|
await page.getByRole("button", { name: "Add widgets, bridges & bots" }).click();
|
|
await expect(page.locator(".mx_IntegrationManager")).toBeVisible();
|
|
});
|
|
|
|
test("should handle viewing export chat", async ({ page, app }) => {
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME);
|
|
|
|
await page.getByRole("menuitem", { name: "Export Chat" }).click();
|
|
await expect(page.locator(".mx_ExportDialog")).toBeVisible();
|
|
});
|
|
|
|
test("should handle viewing share room", async ({ page, app }) => {
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME);
|
|
|
|
await page.getByRole("menuitem", { name: "Copy link" }).click();
|
|
await expect(page.locator(".mx_ShareDialog")).toBeVisible();
|
|
});
|
|
|
|
test("should handle viewing room settings", async ({ page, app }) => {
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME);
|
|
|
|
await page.getByRole("menuitem", { name: "Settings" }).click();
|
|
await expect(page.locator(".mx_RoomSettingsDialog")).toBeVisible();
|
|
await expect(page.locator(".mx_Dialog_title").getByText("Room Settings - " + ROOM_NAME)).toBeVisible();
|
|
});
|
|
|
|
test("should handle viewing files", async ({ page, app }) => {
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME);
|
|
|
|
await page.getByRole("menuitem", { name: "Files" }).click();
|
|
await expect(page.locator(".mx_FilePanel")).toBeVisible();
|
|
await expect(page.locator(".mx_FilePanel_empty")).toBeVisible();
|
|
|
|
await page.getByRole("button", { name: "Room information" }).click();
|
|
await checkRoomSummaryCard(page, ROOM_NAME);
|
|
});
|
|
|
|
test("should handle viewing room member", async ({ page, app }) => {
|
|
await viewRoomSummaryByName(page, app, ROOM_NAME);
|
|
|
|
await page.locator(".mx_RightPanelTabs").getByText("People").click();
|
|
await expect(page.locator(".mx_MemberList")).toBeVisible();
|
|
|
|
await getMemberTileByName(page, NAME).click();
|
|
await expect(page.locator(".mx_UserInfo")).toBeVisible();
|
|
await expect(page.locator(".mx_UserInfo_profile").getByText(NAME)).toBeVisible();
|
|
|
|
await page.getByRole("button", { name: "Room members" }).click();
|
|
await expect(page.locator(".mx_MemberList")).toBeVisible();
|
|
|
|
await page.locator(".mx_RightPanelTabs").getByText("Info").click();
|
|
await checkRoomSummaryCard(page, ROOM_NAME);
|
|
});
|
|
});
|
|
|
|
test.describe("in spaces", () => {
|
|
test("should handle viewing space member", async ({ page, app }) => {
|
|
await app.viewSpaceHomeByName(SPACE_NAME);
|
|
|
|
// \d represents the number of the space members
|
|
await page
|
|
.locator(".mx_RoomInfoLine_private")
|
|
.getByRole("button", { name: /\d member/ })
|
|
.click();
|
|
await expect(page.locator(".mx_MemberList")).toBeVisible();
|
|
await expect(page.locator(".mx_SpaceScopeHeader").getByText(SPACE_NAME)).toBeVisible();
|
|
|
|
await getMemberTileByName(page, NAME).click();
|
|
await expect(page.locator(".mx_UserInfo")).toBeVisible();
|
|
await expect(page.locator(".mx_UserInfo_profile").getByText(NAME)).toBeVisible();
|
|
await expect(page.locator(".mx_SpaceScopeHeader").getByText(SPACE_NAME)).toBeVisible();
|
|
|
|
await page.getByRole("button", { name: "Back" }).click();
|
|
await expect(page.locator(".mx_MemberList")).toBeVisible();
|
|
});
|
|
});
|
|
});
|