mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-26 02:18:25 +08:00
0b0d77cbcc
* utils to persist clientId and issuer after oidc authentication * add dep oidc-client-ts * persist issuer and clientId after successful oidc auth * add OidcClientStore * comments and tidy * format
184 lines
6.9 KiB
TypeScript
184 lines
6.9 KiB
TypeScript
/*
|
|
Copyright 2023 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { mocked } from "jest-mock";
|
|
import { M_AUTHENTICATION } from "matrix-js-sdk/src/client";
|
|
import { logger } from "matrix-js-sdk/src/logger";
|
|
import { discoverAndValidateAuthenticationConfig } from "matrix-js-sdk/src/oidc/discovery";
|
|
import { OidcError } from "matrix-js-sdk/src/oidc/error";
|
|
|
|
import { OidcClientStore } from "../../../src/stores/oidc/OidcClientStore";
|
|
import { flushPromises, getMockClientWithEventEmitter } from "../../test-utils";
|
|
import { mockOpenIdConfiguration } from "../../test-utils/oidc";
|
|
|
|
jest.mock("matrix-js-sdk/src/oidc/discovery", () => ({
|
|
discoverAndValidateAuthenticationConfig: jest.fn(),
|
|
}));
|
|
|
|
describe("OidcClientStore", () => {
|
|
const clientId = "test-client-id";
|
|
const metadata = mockOpenIdConfiguration();
|
|
const account = metadata.issuer + "account";
|
|
const mockSessionStorage: Record<string, string> = {
|
|
mx_oidc_client_id: clientId,
|
|
mx_oidc_token_issuer: metadata.issuer,
|
|
};
|
|
|
|
const mockClient = getMockClientWithEventEmitter({
|
|
getClientWellKnown: jest.fn().mockReturnValue({}),
|
|
});
|
|
|
|
beforeEach(() => {
|
|
jest.spyOn(sessionStorage.__proto__, "getItem")
|
|
.mockClear()
|
|
.mockImplementation((key) => mockSessionStorage[key as string] ?? null);
|
|
mocked(discoverAndValidateAuthenticationConfig).mockClear().mockResolvedValue({
|
|
metadata,
|
|
account,
|
|
issuer: metadata.issuer,
|
|
});
|
|
mockClient.getClientWellKnown.mockReturnValue({
|
|
[M_AUTHENTICATION.stable!]: {
|
|
issuer: metadata.issuer,
|
|
account,
|
|
},
|
|
});
|
|
jest.spyOn(logger, "error").mockClear();
|
|
});
|
|
|
|
describe("isUserAuthenticatedWithOidc()", () => {
|
|
it("should return true when an issuer is in session storage", () => {
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
expect(store.isUserAuthenticatedWithOidc).toEqual(true);
|
|
});
|
|
|
|
it("should return false when no issuer is in session storage", () => {
|
|
jest.spyOn(sessionStorage.__proto__, "getItem").mockReturnValue(null);
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
expect(store.isUserAuthenticatedWithOidc).toEqual(false);
|
|
});
|
|
});
|
|
|
|
describe("initialising oidcClient", () => {
|
|
it("should initialise oidc client from constructor", () => {
|
|
mockClient.getClientWellKnown.mockReturnValue(undefined);
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
// started initialising
|
|
// @ts-ignore private property
|
|
expect(store.initialisingOidcClientPromise).toBeTruthy();
|
|
});
|
|
|
|
it("should log and return when no client well known is available", async () => {
|
|
mockClient.getClientWellKnown.mockReturnValue(undefined);
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
expect(logger.error).toHaveBeenCalledWith("Cannot initialise OidcClientStore: client well known required.");
|
|
// no oidc client
|
|
// @ts-ignore private property
|
|
expect(await store.getOidcClient()).toEqual(undefined);
|
|
});
|
|
|
|
it("should log and return when no clientId is found in storage", async () => {
|
|
jest.spyOn(sessionStorage.__proto__, "getItem").mockImplementation((key) =>
|
|
key === "mx_oidc_token_issuer" ? metadata.issuer : null,
|
|
);
|
|
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
expect(logger.error).toHaveBeenCalledWith(
|
|
"Failed to initialise OidcClientStore",
|
|
new Error("Oidc client id not found in storage"),
|
|
);
|
|
// no oidc client
|
|
// @ts-ignore private property
|
|
expect(await store.getOidcClient()).toEqual(undefined);
|
|
});
|
|
|
|
it("should log and return when discovery and validation fails", async () => {
|
|
mocked(discoverAndValidateAuthenticationConfig).mockRejectedValue(new Error(OidcError.OpSupport));
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
await flushPromises();
|
|
|
|
expect(logger.error).toHaveBeenCalledWith(
|
|
"Failed to initialise OidcClientStore",
|
|
new Error(OidcError.OpSupport),
|
|
);
|
|
// no oidc client
|
|
// @ts-ignore private property
|
|
expect(await store.getOidcClient()).toEqual(undefined);
|
|
});
|
|
|
|
it("should create oidc client correctly", async () => {
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
// @ts-ignore private property
|
|
const client = await store.getOidcClient();
|
|
|
|
expect(client?.settings.client_id).toEqual(clientId);
|
|
expect(client?.settings.authority).toEqual(metadata.issuer);
|
|
});
|
|
|
|
it("should set account management endpoint when configured", async () => {
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
// @ts-ignore private property
|
|
await store.getOidcClient();
|
|
|
|
expect(store.accountManagementEndpoint).toEqual(account);
|
|
});
|
|
|
|
it("should set account management endpoint to issuer when not configured", async () => {
|
|
mocked(discoverAndValidateAuthenticationConfig).mockClear().mockResolvedValue({
|
|
metadata,
|
|
account: undefined,
|
|
issuer: metadata.issuer,
|
|
});
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
// @ts-ignore private property
|
|
await store.getOidcClient();
|
|
|
|
expect(store.accountManagementEndpoint).toEqual(metadata.issuer);
|
|
});
|
|
|
|
it("should reuse initialised oidc client", async () => {
|
|
const store = new OidcClientStore(mockClient);
|
|
|
|
// @ts-ignore private property
|
|
store.getOidcClient();
|
|
// @ts-ignore private property
|
|
store.getOidcClient();
|
|
|
|
await flushPromises();
|
|
|
|
// finished initialising
|
|
// @ts-ignore private property
|
|
expect(await store.getOidcClient()).toBeTruthy();
|
|
|
|
// @ts-ignore private property
|
|
store.getOidcClient();
|
|
|
|
// only called once for multiple calls to getOidcClient
|
|
// before and after initialisation is complete
|
|
expect(discoverAndValidateAuthenticationConfig).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
});
|