mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-29 14:00:48 +08:00
4e68b91515
* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer & other data Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Fix tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
90 lines
3.4 KiB
TypeScript
90 lines
3.4 KiB
TypeScript
/*
|
|
Copyright 2023 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { IdTokenClaims } from "oidc-client-ts";
|
|
|
|
import {
|
|
getStoredOidcClientId,
|
|
getStoredOidcIdTokenClaims,
|
|
getStoredOidcTokenIssuer,
|
|
persistOidcAuthenticatedSettings,
|
|
} from "../../../src/utils/oidc/persistOidcSettings";
|
|
|
|
describe("persist OIDC settings", () => {
|
|
jest.spyOn(Storage.prototype, "getItem");
|
|
jest.spyOn(Storage.prototype, "setItem");
|
|
|
|
beforeEach(() => {
|
|
localStorage.clear();
|
|
});
|
|
|
|
const clientId = "test-client-id";
|
|
const issuer = "https://auth.org/";
|
|
const idTokenClaims: IdTokenClaims = {
|
|
// audience is this client
|
|
aud: "123",
|
|
// issuer matches
|
|
iss: issuer,
|
|
sub: "123",
|
|
exp: 123,
|
|
iat: 456,
|
|
};
|
|
|
|
describe("persistOidcAuthenticatedSettings", () => {
|
|
it("should set clientId and issuer in session storage", () => {
|
|
persistOidcAuthenticatedSettings(clientId, issuer, idTokenClaims);
|
|
expect(localStorage.setItem).toHaveBeenCalledWith("mx_oidc_client_id", clientId);
|
|
expect(localStorage.setItem).toHaveBeenCalledWith("mx_oidc_token_issuer", issuer);
|
|
expect(localStorage.setItem).toHaveBeenCalledWith("mx_oidc_id_token_claims", JSON.stringify(idTokenClaims));
|
|
});
|
|
});
|
|
|
|
describe("getStoredOidcTokenIssuer()", () => {
|
|
it("should return issuer from session storage", () => {
|
|
localStorage.setItem("mx_oidc_token_issuer", issuer);
|
|
expect(getStoredOidcTokenIssuer()).toEqual(issuer);
|
|
expect(localStorage.getItem).toHaveBeenCalledWith("mx_oidc_token_issuer");
|
|
});
|
|
|
|
it("should return undefined when no issuer in session storage", () => {
|
|
expect(getStoredOidcTokenIssuer()).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe("getStoredOidcClientId()", () => {
|
|
it("should return clientId from session storage", () => {
|
|
localStorage.setItem("mx_oidc_client_id", clientId);
|
|
expect(getStoredOidcClientId()).toEqual(clientId);
|
|
expect(localStorage.getItem).toHaveBeenCalledWith("mx_oidc_client_id");
|
|
});
|
|
it("should throw when no clientId in session storage", () => {
|
|
expect(() => getStoredOidcClientId()).toThrow("Oidc client id not found in storage");
|
|
});
|
|
});
|
|
|
|
describe("getStoredOidcIdTokenClaims()", () => {
|
|
it("should return issuer from session storage", () => {
|
|
localStorage.setItem("mx_oidc_id_token_claims", JSON.stringify(idTokenClaims));
|
|
expect(getStoredOidcIdTokenClaims()).toEqual(idTokenClaims);
|
|
expect(localStorage.getItem).toHaveBeenCalledWith("mx_oidc_id_token_claims");
|
|
});
|
|
|
|
it("should return undefined when no issuer in session storage", () => {
|
|
expect(getStoredOidcIdTokenClaims()).toBeUndefined();
|
|
});
|
|
});
|
|
});
|