mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-25 09:58:11 +08:00
e946674df3
* Add Stores and StoresContext and use it in MatrixChat and RoomView Added a new kind of class: - Add God object `Stores` which will hold refs to all known stores and the `MatrixClient`. This object is NOT a singleton. - Add `StoresContext` to hold onto a ref of `Stores` for use inside components. `StoresContext` is created via: - Create `Stores` in `MatrixChat`, assigning the `MatrixClient` when we have one set. Currently sets the RVS to `RoomViewStore.instance`. - Wrap `MatrixChat`s `render()` function in a `StoresContext.Provider` so it can be used anywhere. `StoresContext` is currently only used in `RoomView` via the following changes: - Remove the HOC, which redundantly set `mxClient` as a prop. We don't need this as `RoomView` was using the client from `this.context`. - Change the type of context accepted from `MatrixClientContext` to `StoresContext`. - Modify alllll the places where `this.context` is used to interact with the client and suffix `.client`. - Modify places where we use `RoomViewStore.instance` and replace them with `this.context.roomViewStore`. This makes `RoomView` use a non-global instance of RVS. * Linting * SDKContext and make client an optional constructor arg * Move SDKContext to /src/contexts * Inject all RVS deps * Linting * Remove reset calls; deep copy the INITIAL_STATE to avoid test pollution * DI singletons used in RoomView; DI them in RoomView-test too * Initial RoomViewStore.instance after all files are imported to avoid cyclical deps * Lazily init stores to allow for circular dependencies Rather than stores accepting a list of other stores in their constructors, which doesn't work when A needs B and B needs A, make new-style stores simply accept Stores. When a store needs another store, they access it via `Stores` which then lazily constructs that store if it needs it. This breaks the circular dependency at constructor time, without needing to introduce wiring diagrams or any complex DI framework. * Delete RoomViewStore.instance Replaced with Stores.instance.roomViewStore * Linting * Move OverridableStores to test/TestStores * Rejig how eager stores get made; don't automatically do it else tests break * Linting * Linting and review comments * Fix new code to use Stores.instance * s/Stores/SdkContextClass/g * Update docs * Remove unused imports * Update src/stores/RoomViewStore.tsx Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Remove empty c'tor to make sonar happy Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
146 lines
5.0 KiB
TypeScript
146 lines
5.0 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import React from "react";
|
|
import { act } from "react-dom/test-utils";
|
|
import {
|
|
Room,
|
|
PendingEventOrdering,
|
|
MatrixClient,
|
|
RoomMember,
|
|
RoomStateEvent,
|
|
} from "matrix-js-sdk/src/matrix";
|
|
import { ClientWidgetApi, Widget } from "matrix-widget-api";
|
|
import {
|
|
cleanup,
|
|
render,
|
|
screen,
|
|
} from "@testing-library/react";
|
|
import { mocked, Mocked } from "jest-mock";
|
|
|
|
import {
|
|
mkRoomMember,
|
|
MockedCall,
|
|
setupAsyncStoreWithClient,
|
|
stubClient,
|
|
useMockedCalls,
|
|
} from "../../../test-utils";
|
|
import RoomCallBanner from "../../../../src/components/views/beacon/RoomCallBanner";
|
|
import { CallStore } from "../../../../src/stores/CallStore";
|
|
import { WidgetMessagingStore } from "../../../../src/stores/widgets/WidgetMessagingStore";
|
|
import { MatrixClientPeg } from "../../../../src/MatrixClientPeg";
|
|
import { ConnectionState } from "../../../../src/models/Call";
|
|
import { SdkContextClass } from "../../../../src/contexts/SDKContext";
|
|
|
|
describe("<RoomCallBanner />", () => {
|
|
let client: Mocked<MatrixClient>;
|
|
let room: Room;
|
|
let alice: RoomMember;
|
|
useMockedCalls();
|
|
|
|
const defaultProps = {
|
|
roomId: "!1:example.org",
|
|
};
|
|
|
|
beforeEach(() => {
|
|
stubClient();
|
|
|
|
client = mocked(MatrixClientPeg.get());
|
|
|
|
room = new Room("!1:example.org", client, "@alice:example.org", {
|
|
pendingEventOrdering: PendingEventOrdering.Detached,
|
|
});
|
|
alice = mkRoomMember(room.roomId, "@alice:example.org");
|
|
jest.spyOn(room, "getMember").mockImplementation((userId) =>
|
|
userId === alice.userId ? alice : null,
|
|
);
|
|
|
|
client.getRoom.mockImplementation((roomId) =>
|
|
roomId === room.roomId ? room : null,
|
|
);
|
|
client.getRooms.mockReturnValue([room]);
|
|
client.reEmitter.reEmit(room, [RoomStateEvent.Events]);
|
|
|
|
setupAsyncStoreWithClient(CallStore.instance, client);
|
|
setupAsyncStoreWithClient(WidgetMessagingStore.instance, client);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
client.reEmitter.stopReEmitting(room, [RoomStateEvent.Events]);
|
|
});
|
|
|
|
const renderBanner = async (props = {}): Promise<void> => {
|
|
render(<RoomCallBanner {...defaultProps} {...props} />);
|
|
await act(() => Promise.resolve()); // Let effects settle
|
|
};
|
|
|
|
it("renders nothing when there is no call", async () => {
|
|
await renderBanner();
|
|
const banner = await screen.queryByText("Video call");
|
|
expect(banner).toBeFalsy();
|
|
});
|
|
|
|
describe("call started", () => {
|
|
let call: MockedCall;
|
|
let widget: Widget;
|
|
|
|
beforeEach(() => {
|
|
MockedCall.create(room, "1");
|
|
const maybeCall = CallStore.instance.getCall(room.roomId);
|
|
if (!(maybeCall instanceof MockedCall)) {throw new Error("Failed to create call");}
|
|
call = maybeCall;
|
|
|
|
widget = new Widget(call.widget);
|
|
WidgetMessagingStore.instance.storeMessaging(widget, room.roomId, {
|
|
stop: () => {},
|
|
} as unknown as ClientWidgetApi);
|
|
});
|
|
afterEach(() => {
|
|
cleanup(); // Unmount before we do any cleanup that might update the component
|
|
call.destroy();
|
|
WidgetMessagingStore.instance.stopMessaging(widget, room.roomId);
|
|
});
|
|
|
|
it("renders if there is a call", async () => {
|
|
await renderBanner();
|
|
await screen.findByText("Video call");
|
|
});
|
|
|
|
it("shows Join button if the user has not joined", async () => {
|
|
await renderBanner();
|
|
await screen.findByText("Join");
|
|
});
|
|
|
|
it("doesn't show banner if the call is connected", async () => {
|
|
call.setConnectionState(ConnectionState.Connected);
|
|
await renderBanner();
|
|
const banner = await screen.queryByText("Video call");
|
|
expect(banner).toBeFalsy();
|
|
});
|
|
|
|
it("doesn't show banner if the call is shown", async () => {
|
|
jest.spyOn(SdkContextClass.instance.roomViewStore, "isViewingCall");
|
|
mocked(SdkContextClass.instance.roomViewStore.isViewingCall).mockReturnValue(true);
|
|
await renderBanner();
|
|
const banner = await screen.queryByText("Video call");
|
|
expect(banner).toBeFalsy();
|
|
});
|
|
});
|
|
|
|
// TODO: test clicking buttons
|
|
// TODO: add live location share warning test (should not render if there is an active live location share)
|
|
});
|