mirror of
https://github.com/vector-im/element-web.git
synced 2024-11-26 10:28:46 +08:00
75c2c1a572
* VoiceRecordings: honor advanced audio processing settings Audio processing settings introduced in #8759 is now taken into account when recording a voice message. Signed-off-by: László Várady <laszlo.varady@protonmail.com> * VoiceRecordings: add higher-quality audio recording When recording non-voice audio (e.g. music, FX), a different Opus encoder application should be specified. It is also recommended to increase the bitrate to 64-96 kb/s for musical use. Note: the HQ mode is currently activated when noise suppression is turned off. This is a very arbitrary condition. Signed-off-by: László Várady <laszlo.varady@protonmail.com> * RecorderWorklet: fix type mismatch src/audio/VoiceRecording.ts:129:67 - Argument of type 'null' is not assignable to parameter of type 'string | URL'. Signed-off-by: László Várady <laszlo.varady@protonmail.com> * VoiceRecording: test audio settings Signed-off-by: László Várady <laszlo.varady@protonmail.com> * Fix typos Signed-off-by: László Várady <laszlo.varady@protonmail.com> * VoiceRecording: refactor using destructuring assignment Signed-off-by: László Várady <laszlo.varady@protonmail.com> * VoiceRecording: add comments about constants and non-trivial conditions Signed-off-by: László Várady <laszlo.varady@protonmail.com> Signed-off-by: László Várady <laszlo.varady@protonmail.com>
174 lines
5.9 KiB
TypeScript
174 lines
5.9 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { mocked } from 'jest-mock';
|
|
// @ts-ignore
|
|
import Recorder from 'opus-recorder/dist/recorder.min.js';
|
|
|
|
import { VoiceRecording, voiceRecorderOptions, highQualityRecorderOptions } from "../../src/audio/VoiceRecording";
|
|
import { createAudioContext } from '../..//src/audio/compat';
|
|
import MediaDeviceHandler from "../../src/MediaDeviceHandler";
|
|
|
|
jest.mock('opus-recorder/dist/recorder.min.js');
|
|
const RecorderMock = mocked(Recorder);
|
|
|
|
jest.mock('../../src/audio/compat', () => ({
|
|
createAudioContext: jest.fn(),
|
|
}));
|
|
const createAudioContextMock = mocked(createAudioContext);
|
|
|
|
jest.mock("../../src/MediaDeviceHandler");
|
|
const MediaDeviceHandlerMock = mocked(MediaDeviceHandler);
|
|
|
|
/**
|
|
* The tests here are heavily using access to private props.
|
|
* While this is not so great, we can at lest test some behaviour easily this way.
|
|
*/
|
|
describe("VoiceRecording", () => {
|
|
let recording: VoiceRecording;
|
|
let recorderSecondsSpy: jest.SpyInstance;
|
|
|
|
const itShouldNotCallStop = () => {
|
|
it("should not call stop", () => {
|
|
expect(recording.stop).not.toHaveBeenCalled();
|
|
});
|
|
};
|
|
|
|
const simulateUpdate = (recorderSeconds: number) => {
|
|
beforeEach(() => {
|
|
recorderSecondsSpy.mockReturnValue(recorderSeconds);
|
|
// @ts-ignore
|
|
recording.processAudioUpdate(recorderSeconds);
|
|
});
|
|
};
|
|
|
|
beforeEach(() => {
|
|
recording = new VoiceRecording();
|
|
// @ts-ignore
|
|
recording.observable = {
|
|
update: jest.fn(),
|
|
close: jest.fn(),
|
|
};
|
|
jest.spyOn(recording, "stop").mockImplementation();
|
|
recorderSecondsSpy = jest.spyOn(recording, "recorderSeconds", "get");
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.resetAllMocks();
|
|
});
|
|
|
|
describe("when starting a recording", () => {
|
|
beforeEach(() => {
|
|
const mockAudioContext = {
|
|
createMediaStreamSource: jest.fn().mockReturnValue({
|
|
connect: jest.fn(),
|
|
disconnect: jest.fn(),
|
|
}),
|
|
createScriptProcessor: jest.fn().mockReturnValue({
|
|
connect: jest.fn(),
|
|
disconnect: jest.fn(),
|
|
addEventListener: jest.fn(),
|
|
removeEventListener: jest.fn(),
|
|
}),
|
|
destination: {},
|
|
close: jest.fn(),
|
|
};
|
|
createAudioContextMock.mockReturnValue(mockAudioContext as unknown as AudioContext);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await recording.stop();
|
|
});
|
|
|
|
it("should record high-quality audio if voice processing is disabled", async () => {
|
|
MediaDeviceHandlerMock.getAudioNoiseSuppression.mockReturnValue(false);
|
|
await recording.start();
|
|
|
|
expect(navigator.mediaDevices.getUserMedia).toHaveBeenCalledWith(expect.objectContaining({
|
|
audio: expect.objectContaining({ noiseSuppression: { ideal: false } }),
|
|
}));
|
|
expect(RecorderMock).toHaveBeenCalledWith(expect.objectContaining({
|
|
encoderBitRate: highQualityRecorderOptions.bitrate,
|
|
encoderApplication: highQualityRecorderOptions.encoderApplication,
|
|
}));
|
|
});
|
|
|
|
it("should record normal-quality voice if voice processing is enabled", async () => {
|
|
MediaDeviceHandlerMock.getAudioNoiseSuppression.mockReturnValue(true);
|
|
await recording.start();
|
|
|
|
expect(navigator.mediaDevices.getUserMedia).toHaveBeenCalledWith(expect.objectContaining({
|
|
audio: expect.objectContaining({ noiseSuppression: { ideal: true } }),
|
|
}));
|
|
expect(RecorderMock).toHaveBeenCalledWith(expect.objectContaining({
|
|
encoderBitRate: voiceRecorderOptions.bitrate,
|
|
encoderApplication: voiceRecorderOptions.encoderApplication,
|
|
}));
|
|
});
|
|
});
|
|
|
|
describe("when recording", () => {
|
|
beforeEach(() => {
|
|
// @ts-ignore
|
|
recording.recording = true;
|
|
});
|
|
|
|
describe("and there is an audio update and time left", () => {
|
|
simulateUpdate(42);
|
|
itShouldNotCallStop();
|
|
});
|
|
|
|
describe("and there is an audio update and time is up", () => {
|
|
// one second above the limit
|
|
simulateUpdate(901);
|
|
|
|
it("should call stop", () => {
|
|
expect(recording.stop).toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe("and the max length limit has been disabled", () => {
|
|
beforeEach(() => {
|
|
recording.disableMaxLength();
|
|
});
|
|
|
|
describe("and there is an audio update and time left", () => {
|
|
simulateUpdate(42);
|
|
itShouldNotCallStop();
|
|
});
|
|
|
|
describe("and there is an audio update and time is up", () => {
|
|
// one second above the limit
|
|
simulateUpdate(901);
|
|
itShouldNotCallStop();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("when not recording", () => {
|
|
describe("and there is an audio update and time left", () => {
|
|
simulateUpdate(42);
|
|
itShouldNotCallStop();
|
|
});
|
|
|
|
describe("and there is an audio update and time is up", () => {
|
|
// one second above the limit
|
|
simulateUpdate(901);
|
|
itShouldNotCallStop();
|
|
});
|
|
});
|
|
});
|