Commit Graph

8966 Commits

Author SHA1 Message Date
Michael Telatynski
b2249d0561 Initial rejig 2019-12-19 20:09:05 +00:00
Michael Telatynski
a410cc004f
Merge pull request #3745 from matrix-org/t3chguy/get_rid_of_emoji_stripped_data
Get rid of stripped-emoji.json in favour of an in-memory single source of truth
2019-12-19 19:25:50 +00:00
David Baker
290df9f50e
Merge pull request #3753 from matrix-org/dbkr/combine_cross_sig_dm_verif_feature_flags
Combine cross signing and verification over DM feature flags
2019-12-19 17:27:41 +00:00
Michael Telatynski
ba2078e262
Merge pull request #3754 from matrix-org/t3chguy/fuzzy_filter_room_list
apply unhomoglyph when filtering room list to fuzzify it
2019-12-19 17:16:09 +00:00
Michael Telatynski
f3802bfd05
Merge pull request #3746 from matrix-org/t3chguy/emoji_picker
Make EmojiPicker an unmanaged Context Menu as it is too complex to be managed
2019-12-19 16:58:34 +00:00
Michael Telatynski
a13ee490e8
Merge pull request #3750 from matrix-org/t3chguy/m_too_large
Internationalise M_TOO_LARGE error from Synapse
2019-12-19 16:27:17 +00:00
Michael Telatynski
e54429680b tidy up 2019-12-19 15:28:11 +00:00
Michael Telatynski
26980e2ad5 apply unhomoglyph when filtering room list to fuzzify it 2019-12-19 15:26:04 +00:00
David Baker
3d8422c88a Combine cross signing and verification over DM feature flags
This means we can just make the new member info panel support
cross-signing exclusively rather than having to try & make it
temporarily support both
2019-12-19 15:23:32 +00:00
Michael Telatynski
709b2eed7c Add bunch of null-guards and similar to fix React Errors/complaints 2019-12-19 15:10:54 +00:00
Michael Telatynski
db069b9602 delint 2019-12-19 14:33:46 +00:00
Michael Telatynski
6c1944359e Add RoomTile online indicator to DMs 2019-12-19 14:29:46 +00:00
Michael Telatynski
3678e64f5d Internationalise M_TOO_LARGE error from Synapse 2019-12-19 13:25:43 +00:00
Michael Telatynski
66783dff9e Fix scaling of the avatar in UserInfo 2019-12-19 12:27:25 +00:00
Michael Telatynski
3196655524 Replace UserInfo avatar with <MemberAvatar/> for fallback logic 2019-12-19 10:42:47 +00:00
Michael Telatynski
a1df87a375 Make EmojiPicker an unmanaged Context Menu as it is too complex to be managed 2019-12-19 07:23:05 +00:00
Michael Telatynski
d35b01b63a Get rid of stripped-emoji.json in favour of an in-memory single truth source 2019-12-18 15:40:19 +00:00
Michael Telatynski
f30e919f9e
Merge pull request #3741 from matrix-org/t3chguy/dropdown_keyboard_propagation
Dropdown stop keyboard propagation if key handled
2019-12-17 17:39:41 +00:00
Michael Telatynski
da4d72b3c4 delint 2019-12-17 17:34:03 +00:00
Michael Telatynski
b094f0fe47 delint 2019-12-17 17:31:29 +00:00
Michael Telatynski
937b32663c Migrate away from Legacy React Contexts 2019-12-17 17:26:12 +00:00
Michael Telatynski
2e8d66fa36 Null-guard member mention pills for rooms you have left (notif panel) 2019-12-17 16:54:59 +00:00
Michael Telatynski
3f5dc4fcdc
Merge pull request #3740 from matrix-org/t3chguy/field_validation_async_tooltip_sticks
Fix Field validation tooltip sticking if blurred before async validation resolved
2019-12-17 16:45:48 +00:00
Michael Telatynski
7f78f55c94 Dropdown stop keyboard propagation if key handled 2019-12-17 15:14:01 +00:00
Michael Telatynski
0c89ab9fb5
Merge pull request #3738 from matrix-org/t3chguy/null-guard-useIsEncrypted
Fix UserInfo exploding without a room being passed to it
2019-12-17 15:13:59 +00:00
Travis Ralston
590ef79300
Merge pull request #3737 from matrix-org/travis/room-dir
Fix room directory maintaining and error state
2019-12-17 08:07:12 -07:00
Michael Telatynski
0e86c2648d improve comment 2019-12-17 14:36:20 +00:00
Michael Telatynski
213bc4c3ac Fix Field validation tooltip sticking if blurred before async validation resolved 2019-12-17 14:28:18 +00:00
Michael Telatynski
c1133ebfc6 null-guard useIsEncrypted 2019-12-17 14:05:51 +00:00
Michael Telatynski
17463c401f post-merge fix 2019-12-17 09:58:04 +00:00
Michael Telatynski
3a8ab6ec2b
Merge pull request #3736 from matrix-org/t3chguy/stop_using_deprecated_keyCode
Stop using KeyboardEvent.keyCode as it is deprecated
2019-12-17 09:55:13 +00:00
Travis Ralston
b2a1a40961 Fix room directory maintaining and error state
Fixes https://github.com/vector-im/riot-web/issues/11665

We weren't clearing the error from a previous lookup, which effectively prevented the UI from working after an error happened.
2019-12-16 16:47:33 -07:00
Michael Telatynski
3b0f8233e8 delint 2019-12-16 17:22:00 +00:00
Michael Telatynski
d28a892bb0 Stop using KeyboardEvent.keyCode as it is deprecated 2019-12-16 17:14:03 +00:00
Michael Telatynski
bf06b1f379 Merge branches 'develop' and 't3chguy/remove_avatar_2.0' of https://github.com/matrix-org/matrix-react-sdk into t3chguy/remove_avatar_2.0
 Conflicts:
	res/css/views/settings/_ProfileSettings.scss
2019-12-16 16:23:25 +00:00
Michael Telatynski
5ab98e9899 open ImageView when clicking on a set avatar 2019-12-16 15:21:05 +00:00
Michael Telatynski
9fa2680dc6 Implement new design for uploading/removing avatars 2019-12-16 14:58:12 +00:00
Michael Telatynski
85ade7e1a1 Switch to react-focus-lock for it to comprehend Portals 2019-12-16 12:16:41 +00:00
Michael Telatynski
2569b78db3
Merge pull request #3729 from matrix-org/t3chguy/aria_dropdown
Make combobox dropdown keyboard and screen reader accessible
2019-12-16 11:14:46 +00:00
David Baker
be914c7b0c
Merge pull request #3728 from matrix-org/jryans/verify-users
Verify users when cross-signing enabled
2019-12-16 10:12:46 +00:00
Michael Telatynski
9c4eb1d649 clean up new code 2019-12-16 10:03:40 +00:00
Michael Telatynski
224ee05b62 this is a combobox, HOME/END should pertain to the input, not selection 2019-12-15 15:07:49 +00:00
Michael Telatynski
cecf581e04 Make Combobox dropdown keyboard and screen reader accessible 2019-12-15 15:04:57 +00:00
Michael Telatynski
f67eedf843 Fix keyboard handling including scroll into view, add aria roles 2019-12-15 14:24:56 +00:00
J. Ryan Stinnett
2df72bfde2 Update room / user decoration for cross-signing 2019-12-13 17:57:26 +00:00
Michael Telatynski
9f0e2412c7
Merge pull request #3727 from matrix-org/t3chguy/unignore_a11y
Improve a11y of the unignore button in Settings
2019-12-13 17:53:30 +00:00
Michael Telatynski
2313285be2
Merge pull request #3726 from matrix-org/t3chguy/fix_ToggleSwitch_a11y
Fix ToggleSwitch A11Y (trapping tab and switch v. checkbox)
2019-12-13 17:53:21 +00:00
Michael Telatynski
0bc02564bc Improve a11y of the unignore button in Settings 2019-12-13 14:31:34 +00:00
Michael Telatynski
9d0bf13ca0 Fix ToggleSwitch A11Y (trapping tab and switch v. checkbox) 2019-12-13 14:18:41 +00:00
Michael Telatynski
17a42cd287 Make LInkPreviewWidget close button Keyboard & SR Accessible 2019-12-13 14:02:50 +00:00
J. Ryan Stinnett
3ac0deebab Use static modals for verification
Verification with cross-signing may requiring asking for your secret storage
passphrase, which is displayed in it's own modal on top of flows. For now while
verification takes in modals also, mark the verification ones as static so they
don't lose state when secret storage appears on top mid-flow.
2019-12-13 13:55:28 +00:00
J. Ryan Stinnett
b7fe06706d
Merge pull request #3720 from matrix-org/jryans/4s-new-key-backup
Create new key backups using secret storage
2019-12-12 17:33:11 +00:00
J. Ryan Stinnett
38ee1aed09 Replace sign-ins with sessions
The designs were changed to use the term "sessions" instead of "sign-ins".
2019-12-12 16:35:02 +00:00
J. Ryan Stinnett
3cbb3c12cd Update cross-signing details on trust changes 2019-12-12 15:42:27 +00:00
J. Ryan Stinnett
458cc9598d Support restoring key backup with stored secret 2019-12-12 15:18:36 +00:00
J. Ryan Stinnett
e87ff54eee Clean up cross-signing debug panel 2019-12-12 14:27:57 +00:00
J. Ryan Stinnett
4417235d9e Show whether backup key is stored 2019-12-12 14:06:44 +00:00
J. Ryan Stinnett
d2f2d3b344 Handle cross-singing sigs in key backup details 2019-12-12 13:51:45 +00:00
Travis Ralston
7230d51cca
Merge pull request #3703 from matrix-org/travis/right-panel-v2
Refactor RightPanel to match expected behaviour
2019-12-11 10:50:45 -07:00
Travis Ralston
633aa59e6c
Merge pull request #3716 from matrix-org/travis/mjolnir-render
Render policy room event updates in the timeline
2019-12-11 10:50:27 -07:00
J. Ryan Stinnett
8cbc9baddd Add testing flow for new key backups with SSSS
This adds a path to test key backups with SSSS via an extra button only visible
when the cross-signing feature is enabled.
2019-12-11 16:32:49 +00:00
J. Ryan Stinnett
66f7600969 Add accessSecretStorage helper with common flow setup
This moves the details of dialogs that may be needed when accessing secret
storage to centralised helper. In addition, this clears the secret storage key
cache so that keys are only live for a single operation.
2019-12-11 15:07:46 +00:00
J. Ryan Stinnett
fae819dfe5 Merge remote-tracking branch 'origin/develop' into jryans/4s-new-key-backup 2019-12-11 10:05:20 +00:00
Michael Telatynski
cb50f5ff5f
Merge pull request #3715 from matrix-org/t3chguy/fix_roomlist_context_menu_regression
Fix remaining context menu regressions
2019-12-11 09:36:45 +00:00
Michael Telatynski
c1b1f98201
Merge pull request #3712 from matrix-org/t3chguy/react16_refs
Migrate away from React Legacy string refs
2019-12-10 17:43:37 +00:00
Travis Ralston
b6d0308a54
Merge pull request #3706 from matrix-org/travis/dm-copy
Update copy for DM invites
2019-12-10 10:19:47 -07:00
Travis Ralston
c8c344804e Remove special case RHS resizer logic
It doesn't seem to affect anything by being removed.
2019-12-10 10:01:45 -07:00
Travis Ralston
f529a6c7a2 Render policy room event updates in the timeline
Fixes https://github.com/matrix-org/mjolnir/issues/15

This should be completely safe to deploy, even without a labs flag, because policy rooms (ban lists) are usually only joined by the people who know what they are. This also has no relation to the Mjolnir functionality currently in Riot, though it does make seeing your ban list a bit less awkward. 

Ban list rules only show up in ban list rooms and rarely show up in public rooms, hence the somewhat vague messaging. It should be obvious that it's a ban list room due to the surrounding room decoration/purpose.
2019-12-09 20:36:00 -07:00
Michael Telatynski
44adda3547 Add right-click context menu to GroupInviteTile.js
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-10 00:14:36 +00:00
Michael Telatynski
5c92f8ab25 Fix RoomTile right click context menu
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-10 00:08:45 +00:00
Michael Telatynski
52c20db963 Fix chevron offset for toRightOf
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-09 23:58:09 +00:00
Michael Telatynski
2691d1a611 Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into t3chguy/fix_mab_regression 2019-12-09 14:13:11 +00:00
Michael Telatynski
69eeabd99e Fix accessibility to the reaction picker (not of it though)
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-09 14:12:30 +00:00
Half-Shot
6225e402cc i18n'ed all over the plaace 2019-12-09 13:54:21 +00:00
Michael Telatynski
cd73162957
Merge branch 'develop' into t3chguy/react16_refs 2019-12-09 13:47:06 +00:00
Michael Telatynski
f079c2fdd2
Merge pull request #3709 from matrix-org/t3chguy/what-input
Add what-input to allow different scoping to focus-visible for MAB a11y
2019-12-09 13:45:59 +00:00
Michael Telatynski
b1788fb4b5
Merge pull request #3708 from matrix-org/t3chguy/search_accessible_radios
Mark the This/All Rooms scope buttons as radios for a11y
2019-12-09 13:43:32 +00:00
Michael Telatynski
21647cf596
Merge pull request #3707 from matrix-org/t3chguy/improve_a11y_reactions_row_button
Switch ReactionsRowButton to an AccessibleButton for space/enter handling
2019-12-09 13:43:06 +00:00
Half-Shot
7ee5f7ba38 Add feature flag 2019-12-09 13:28:43 +00:00
Half-Shot
d9943754f7 Remove status as it's no longer part of the MSC 2019-12-09 13:28:16 +00:00
Will Hunt
ce21ce8bbe Lint 2019-12-09 13:22:45 +00:00
Half-Shot
9f2ccdf913 Add support for displaying avatars and links in bridge info 2019-12-09 13:22:45 +00:00
Half-Shot
7c35b16f4d Add bridge tab button 2019-12-09 13:22:45 +00:00
Half-Shot
0d537ecbb3 Add bridge info tab 2019-12-09 13:22:45 +00:00
Michael Telatynski
702f061341 ref is used earlier so assign it earlier
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-08 12:45:59 +00:00
Michael Telatynski
ff71f4ec8d Migrate RoomSubList to ES6 Class due to new/vs old React API incompat
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-08 12:43:06 +00:00
Michael Telatynski
d22985f12e Migrate string refs over to createRef
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-08 12:16:17 +00:00
Michael Telatynski
4c55f3c5b5 Remove unused refs
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-08 12:12:06 +00:00
Michael Telatynski
33eff43313 Change the (edited) link to an AccessibleButton for a11y
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-07 21:01:21 +00:00
Michael Telatynski
4be8b87869 Add what-input to allow different scoping to focus-visible for MessageActionBar keyboard a11y
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-07 13:07:52 +00:00
Michael Telatynski
86e52d1ef3 Mark the This/All Rooms scope buttons as radios for a11y
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-07 12:45:28 +00:00
Michael Telatynski
680c5c2b27 Switch ReactionsRowButton to an AccessibleButton for space/enter handling
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-07 12:20:06 +00:00
Travis Ralston
8d3418dfa9 Update copy for DM invites
Fixes https://github.com/vector-im/riot-web/issues/10766
2019-12-06 17:08:24 -07:00
Travis Ralston
94ae06db4d Fix cold open of the RightPanel directly to MemberInfo
This requires us to track some of the phase's state in the RightPanelStore, which is not great - trying to get it through the app is a bit difficult.
2019-12-06 15:05:02 -07:00
Travis Ralston
78ce801c25 Fix incorrect function call into RightPanelStore
We dispatch to open, not call directly into the store.
2019-12-06 14:52:31 -07:00
Travis Ralston
4bcf99f65e Fix member info not opening
The subclasses listen for view_user and similar dispatches, which then start up the RightPanel. We weren't registering a listener though because we changed to using the RightPanelStore for most of our logic.
2019-12-06 14:51:49 -07:00
Travis Ralston
814c408e23 Disable the right panel when the app asks us to
Currently this is only used in the GroupView and for forwarding messages.
2019-12-06 14:18:18 -07:00
J. Ryan Stinnett
24d6e7e456 Use private key check to provide feedback 2019-12-06 17:54:00 +00:00
Marco Zehe
19e6587548 Add tabIndex to the button to make it keyboard focusable
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2019-12-06 16:03:19 +01:00
Marco Zehe
78555ed422 Make reaction buttons more accessible
Fixes vector-im/riot-web/issues/11608.

This patch:

1. Turns the container of reaction buttons into a toolbar.
2. Makes each button span into a button with a tabindex and an aria-label.
3. Constructs an alternative label that differs slightly from the text displayed by the tool tip:
   * It uses the names of the people who reacted.
   * It puts a space before the "reacted with" text.
   * It uses the actual emoji characters, not the converted colon-delimited shortNames, because the emojis usually tell blind users more about the expression.
   * It omits the number of reactions, since that information is already conveyed by the names.

Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2019-12-06 15:58:28 +01:00
J. Ryan Stinnett
9b9e074d30 Use consistent import style 2019-12-06 14:15:41 +00:00
Travis Ralston
a24bbdffd0 Appease the linter
Mid-PR cleanup.
2019-12-05 23:58:19 -07:00
Travis Ralston
4873b526df Ensure the right panel stays the same between room changes if possible
Fixes https://github.com/vector-im/riot-web/issues/10149
2019-12-05 23:48:05 -07:00
Travis Ralston
bbdff701b4 Actually render the right panel in the new system 2019-12-05 23:40:25 -07:00
Travis Ralston
42898ec414 Rid ourselves of RightPanel.Phases completely 2019-12-05 23:35:12 -07:00
Travis Ralston
756cf3a88b Convert the GroupMemberList actions to the new RightPanelStore 2019-12-05 23:34:44 -07:00
Travis Ralston
eda712ece8 Update sticker picker handling for new right panel actions 2019-12-05 23:30:26 -07:00
Travis Ralston
d8d8e59002 Don't show/hide the right panel depending on window size
Fixes https://github.com/vector-im/riot-web/issues/8772
2019-12-05 23:30:13 -07:00
Travis Ralston
8b492fdaa5 Remove dead code from GroupView
This was for a caret that is no longer in the app. Instead, the header buttons act as a toggle.
2019-12-05 23:29:43 -07:00
Travis Ralston
ca0c393783 Use new right panel store for header buttons
This introduces a new dispatch action (unused, so far) and routes the buttons towards the RightPanelStore for processing.
2019-12-05 23:28:06 -07:00
Travis Ralston
6e882251bd Break the right panel completely
This lays a foundation for redirecting all the traffic through the new store, but for now the core parts of the app need to stop caring if the right panel is open.
2019-12-05 17:47:18 -07:00
Travis Ralston
5253f29928 Build out a store for the right panel state machine
This should make it easier to funnel the expected behaviour through a central block of code.
2019-12-05 15:31:01 -07:00
J. Ryan Stinnett
d66dbdea61 Indicate which access flow was used 2019-12-05 16:23:00 +00:00
J. Ryan Stinnett
9f1c2cd3e1 Add dialogs for creating and accessing secret storage
This adds dialogs for creating and accessing secret storage via a passphrase or
recovery key. These flows are adapted from the ones used for key backup.
2019-12-05 15:34:07 +00:00
David Baker
fc4926600a Fix propTypes declaration
With this version of babel (via babel-eslint), eslint now fails
with a somewhat confusing, "Unexpected reserved type number"
(from the flow plugin...) if you get this wrong.
2019-12-05 10:42:20 +00:00
J. Ryan Stinnett
a7d94ebcaa Convert RestoreKeyBackupDialog to modern style 2019-12-04 17:23:48 +00:00
Michael Telatynski
be6da03348
Merge pull request #3611 from matrix-org/t3chguy/context_menus
ARIA compliant context menus
2019-12-04 17:17:47 +00:00
David Baker
bc52db5423
Merge pull request #3697 from matrix-org/travis/e2e-icons
Match e2e icons on events to expectations
2019-12-04 10:33:47 +00:00
David Baker
2058ba8fd9
Merge pull request #3695 from matrix-org/travis/new-upgrade-dialog
Match room upgrade warning to the new design
2019-12-04 10:17:33 +00:00
Travis Ralston
b4e60af61f Appease the linter and de-dupe code 2019-12-03 23:15:49 -07:00
Travis Ralston
33044d713e Match e2e icons on events to expectations
Fixes https://github.com/vector-im/riot-web/issues/11547

Steps taken:
* Convert `E2ePadlock` to a class-style component so the hover state can be tracked (tooltips).
* Convert the image mask to a background image to keep the `!` in the shield.
* Update copy.
2019-12-03 22:41:22 -07:00
Michael Telatynski
d3de792f79 fix bits which missed the review cutting block
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-03 10:53:32 +00:00
David Baker
910c50370b
Merge pull request #3678 from matrix-org/dbkr/remove_dead_velocity_ui
Remove broken velocity-ui animation
2019-12-03 10:38:40 +00:00
Travis Ralston
6d42da8160 Actually spawn a bug report dialog. 2019-12-02 17:26:08 -07:00
Travis Ralston
0d63a2bea1
Merge pull request #3685 from aaronraimist/edit-message-remove-btn
Hide Remove button in message editing history if you don't have permission to redact
2019-12-02 17:22:01 -07:00
Travis Ralston
e47752ff8d Match room upgrade warning to the new design
See https://github.com/matrix-org/matrix-react-sdk/pull/3684#issuecomment-560514872
2019-12-02 17:21:53 -07:00
Travis Ralston
4d5f133b17
Merge pull request #3684 from matrix-org/travis/auto-invite-upgrades
Add an option to invite users to upgraded private rooms
2019-12-02 17:03:25 -07:00
Michael Telatynski
901e402a5c apply renames suggested in PR review
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-02 23:23:11 +00:00
Michael Telatynski
757f811126 s/ContextualMenu/ContextMenu/
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-02 23:21:59 +00:00
Michael Telatynski
a062fe0096 Merge branches 'develop' and 't3chguy/context_menus' of github.com:matrix-org/matrix-react-sdk into t3chguy/context_menus 2019-12-02 23:20:47 +00:00
J. Ryan Stinnett
139e19630a Watch for account data changes in debug panel 2019-12-02 14:34:32 +00:00
J. Ryan Stinnett
c21c0e1150 Add error to debug panel 2019-12-02 14:22:47 +00:00
Michael Telatynski
a17df6dd38
Merge pull request #3689 from matrix-org/t3chguy/dont_trap_context_menu_keyboard
Do not trap Key ContextMenu into composer for keyboard a11y
2019-12-02 11:37:24 +00:00
Michael Telatynski
7a3b8a522f Make EmojiPicker filtering case-insensitive
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-02 10:18:02 +00:00
Michael Telatynski
e2733a27c4 add null-guard
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-02 10:06:58 +00:00
Michael Telatynski
3ad4b0fb64 Do not trap Key ContextMenu into composer for keyboard a11y
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-02 10:01:08 +00:00
J. Ryan Stinnett
798d5c8ada Always update cross-signing status even if error 2019-11-29 17:53:39 +00:00
J. Ryan Stinnett
c32c1d201c Rename device signing auth param 2019-11-29 17:49:51 +00:00
J. Ryan Stinnett
6140803b7f Fix key upload auth to test confirmation 2019-11-29 17:43:24 +00:00
Travis Ralston
9cae685e22
Merge pull request #3686 from matrix-org/travis/theme-fix
Ensure the settings page accurately represents theme choices
2019-11-29 10:17:55 -07:00
Travis Ralston
1c766d8594
Merge pull request #3688 from matrix-org/travis/rr-fix
Ensure read receipts end up with a valid reference to checkUnmounting
2019-11-29 07:41:49 -07:00
J. Ryan Stinnett
a21285143f Add tbody to silence React warning 2019-11-29 11:55:36 +00:00
J. Ryan Stinnett
c6e56d98b3 Merge remote-tracking branch 'origin/develop' into jryans/4s-new-key-backup 2019-11-29 11:31:23 +00:00
J. Ryan Stinnett
c103fe4273 Add cross-signing diagnostic panel
This is not part of any designs, so it may be short-lived, but it's quite handy
for diagnosing issues with cross-signing at least while the feature is in
development.
2019-11-29 11:29:08 +00:00
Travis Ralston
5aad914c25
Merge pull request #3675 from aaronraimist/labs-explain
Add a link to the labs feature documentation
2019-11-28 22:07:47 -07:00
Aaron Raimist
4c50ac0e56
Improve wording
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2019-11-28 22:22:42 -06:00
Travis Ralston
36f9fab474 Ensure read receipts end up with a valid reference to checkUnmounting
Fixes https://github.com/vector-im/riot-web/issues/11496
Fixes https://github.com/vector-im/riot-web/issues/11385
Fixes https://github.com/vector-im/riot-web/issues/10007
Fixes https://github.com/vector-im/riot-web/issues/9769

React does (kinda) bind `this._isUnmounting` for us in the context of the EventTile, but the EventTile then passes the function straight through to the ReadReceiptMarker component, which then binds it in the context of EventTile. This results in `this._mounted` being falsey all the time, preventing the ReadReceiptMarker from hitting the code where it updates rrInfo in its unmount. 

The velocity stuff is smart enough to realize that it has a read receipt and shuffles everything over by one, but when it goes to check the starting height (which will be null/undefined because the RRMarker didn't update it) it assumes it has never seen the receipt before and appends it again - this is what causes some holes/stacking.

By forcefully binding the `this._isUnmounting` function we ensure that the `this._mounted` variable is correctly referenced in the context of the MessagePanel, allowing the RRMarker to update its position, and therefore allowing the velocity behaviour to be consistent.
2019-11-28 19:45:37 -07:00
Michael Telatynski
bfb5706b4a don't consume all keys
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-11-28 20:51:21 +00:00
Michael Telatynski
29b59dde5b undo unrelated change
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-11-28 20:44:08 +00:00
Travis Ralston
37ec7e6f7e Ensure the settings page accurately represents theme choices
Fixes https://github.com/vector-im/riot-web/issues/11518

This also fixes a bug where the the theme logic can incorrectly get stuck in the light theme - the ThemeController was overriding *all* values, not just supposed themes. Null values aren't overridden so that the various theme logic bits don't assume the user has chosen the light theme explicitly.
2019-11-28 13:40:28 -07:00