Commit Graph

42688 Commits

Author SHA1 Message Date
Robin
a85799b87c
Make PiP motion smoother and react to window resizes correctly (#8747)
* Make PiP motion smoother and react to window resizes correctly

* Remove debugging logs

* Apply code review suggestions
2022-06-02 18:11:28 +00:00
Suguru Hirahara
68bc8112b3
Adjust message timestamp position on TimelineCard in non-bubble layouts (#8745) 2022-06-02 19:26:48 +02:00
Kerry
79a2dfe171
Live location share - enable reply and react to tiles (#8721)
* test most basic paths in messageactionbar

Signed-off-by: Kerry Archibald <kerrya@element.io>

* tidy

Signed-off-by: Kerry Archibald <kerrya@element.io>

* use rtl for MessageActionBar test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* make beacon_info events semi actionable

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove log

Signed-off-by: Kerry Archibald <kerrya@element.io>

* test thread exception for beacon

Signed-off-by: Kerry Archibald <kerrya@element.io>

* eat click events in beacon status to stop jumping from reply tile

Signed-off-by: Kerry Archibald <kerrya@element.io>

* set max width on beaconbody for render in thread panel
2022-06-02 15:43:19 +00:00
Janne Mareike Koschinski
a74b9a7083
Prevent Invite and DevTools dialogs from being cut off (#8646)
* fix: replace fixed height based styling with flex for invite and dev dialogs
* feat: create flex wrapper class for dialogs
* feat: make invite dialogs use flex layout
* feat: make devtools dialogs use flex layout
2022-06-02 15:59:40 +02:00
Robin
4b957b57af
Squish event bubble tiles less (#8740) 2022-06-02 09:10:41 -04:00
Robin
f152310c08
Use random widget IDs for video rooms (#8739) 2022-06-02 09:10:22 -04:00
Suguru Hirahara
abfc66a34e
Improve _ShareType.scss (#8737)
* Specify the button style explicitly removing the dependency on the mixin

The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove element='button' from AccessibleButton

Since AccessibleButton has role='button' by default, setting the element button property is redundant.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Protect mx_ShareType_option from being regressed structurally

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Wrap buttons with declarations for spacing

box-sizing is not required for the buttons or the wrapper.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* fix eslint errors

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix LocationShareMenu-test.tsx

AccessibleButton is div by default

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Reflect the review

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert "Remove element='button' from AccessibleButton"

This reverts commit af78d2713f6b4fca9405498e0090db1e6218ff1b.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert "Fix LocationShareMenu-test.tsx"

This reverts commit 7d783a733ec84af6453b2359b2d00443fcece2ef.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-02 14:18:26 +02:00
Kerry
158e42f764
Unit test MessageActionBar (#8732)
* test most basic paths in messageactionbar

Signed-off-by: Kerry Archibald <kerrya@element.io>

* tidy

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add rtl

* add code style note about using rtl

Signed-off-by: Kerry Archibald <kerrya@element.io>

* downgrade to rtl 12

* use rtl for MessageActionBar test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* try mocking settingsstore for ci only failure

Signed-off-by: Kerry Archibald <kerrya@element.io>

* mock setValue too

Signed-off-by: Kerry Archibald <kerrya@element.io>

* uupdate lockfile

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-06-02 10:25:56 +02:00
Suguru Hirahara
7c57680b93
Fix read avatars overflow from the right chat panel with a maximized widget on bubble message layout (#8470)
* Fix RR overflow on the right chat panel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Align with RR outside of info tile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use inset-inline property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-02 02:43:07 +00:00
Šimon Brandner
6574c5c3e2
Fix CallView crash (#8735) 2022-06-01 17:14:43 +02:00
Faye Duxovni
23cc1aff73
Fix flakiness of cypress crypto tests (#8731) 2022-06-01 09:57:53 +01:00
Esha Goel
e11dbae89b
Change dash to em dash issues fixed (#8455)
* addedd em dash

* Update src/components/views/settings/tabs/user/GeneralUserSettingsTab.tsx

Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>

* changes pushed

Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-05-31 16:21:11 -06:00
Suguru Hirahara
b12a272385
Use AccessibleButton for 'In reply to' link button on ReplyChain (#8726)
- Remove ButtonResetDefault mixin to respect the concept of cascading

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-31 15:52:12 -06:00
RiotRobot
afeea12167 v3.46.0-rc.1 2022-05-31 11:41:44 +01:00
RiotRobot
f41ae5c726 Prepare changelog for v3.46.0-rc.1 2022-05-31 11:41:43 +01:00
RiotRobot
7ca3b6bb13 Upgrade matrix-js-sdk to 18.1.0-rc.1 2022-05-31 11:35:17 +01:00
Johannes Krude
b776cc8c1f
Fetch homeUrl from .well-known (#7790)
* Fetch homeUrl from .well-known

* homeUrl: prefer config.json over .well-known

* homeUrl: prefer deprecated config.json variant over .well-known

* Apply suggestions from code review

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-05-30 19:01:55 +00:00
Michael Telatynski
e87ef3b6ab
Revert "Github Actions pull_request synchronize runs on PR open anyway" (#8720)
* Revert "Github Actions pull_request synchronize runs on PR open anyway (#8718)"

This reverts commit eaace4b4d1.

* Update pull_request.yaml
2022-05-30 15:40:26 +01:00
Michael Telatynski
af6ded3b0b
Move update tests to Cypress (#8716)
* Move update tests to Cypress

* Fix /version intercept to account for cachebuster
2022-05-30 13:40:55 +00:00
Michael Telatynski
eaace4b4d1
Github Actions pull_request synchronize runs on PR open anyway (#8718) 2022-05-30 14:33:36 +01:00
Faye Duxovni
5b520e84c4
Start adding Cypress tests for crypto (#8577)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-30 09:26:48 -04:00
Kerry
f742e3a17d
matrix-mock-request 2.0 (#8717) 2022-05-30 12:19:13 +00:00
Suguru Hirahara
bae8854c13
Remove inline margin from UTD error message inside a reply tile on ThreadView (#8708)
* Remove inline margin from UTD error message inside a reply tile on ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge 'mx_ReplyChain_wrapper' blocks

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-30 08:55:12 +02:00
Travis Ralston
150c530850
Disable no-non-null assertions lint rule (#8699)
This *allows* us to use `variable!.prop` to ensure `variable` is not null/undefined.
2022-05-30 00:21:55 -06:00
Andy Balaam
2649c6fd75
Tests for roundtrips md<->HTML (#8696)
* Tests for roundtrips md<->HTML

* Convert roundtrip tests to it.each table style

* Fix lint errors

* Remove extraneous "f "

Co-authored-by: Travis Ralston <travisr@matrix.org>

* Test __ -> **

* Test for code blocks containing markdown

* Test for more ordered lists

* Test for code blocks with language specifiers

* Additional cases for HTML->markdown->HTML

Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-05-27 13:10:22 -06:00
Andy Balaam
5f31fef874
Add documentation about how to run lint and fix dependencies (#8703) 2022-05-27 13:08:41 -06:00
Robin
f47121ece7
Revert "Fix wide image overflowing from the thumbnail container (#8663)" (#8709)
This reverts commit 5082d67dc1.
2022-05-27 17:18:44 +00:00
Kerry
15c2fb6b71
Live location sharing - open location in OpenStreetMap (PSF-1040) (#8695)
* share plain lat,lon string from beacon tooltip and list item

Signed-off-by: Kerry Archibald <kerrya@element.io>

* export makeMapSiteLink helper fn

Signed-off-by: Kerry Archibald <kerrya@element.io>

* use currentColor in external-link.svg

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add open in openstreetmap link

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fussy import ordering

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix icon color var

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-27 11:58:39 +02:00
Suguru Hirahara
12abbf4042
Prevent overflow of grid items on a bubble with UTD generally (#8697) 2022-05-27 10:41:53 +01:00
Andy Balaam
6f56471362
Make README markdown more consistent (#8705)
* Make README markdown more consistent
* Most lines were 80 characters wide, others not - make them all 80.
* Switch to === titles in README where possible
2022-05-27 10:33:09 +01:00
Suguru Hirahara
aef080ac80
Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout (#8704) 2022-05-27 09:23:34 +01:00
Kerry
14cf6275d0
Fix: AccessibleButton does not set disabled attribute (PSF-1055) (#8682)
* remove old styles for pin drop buttons

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fully disable share location button until location is shared

Signed-off-by: Kerry Archibald <kerrya@element.io>

* set disabled on button

Signed-off-by: Kerry Archibald <kerrya@element.io>

* test AccessibleButton disabled

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove disbaled check in LocationPicker

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-27 07:13:50 +00:00
Robin
0d1bb3bd9a
Show a dialog when Jitsi encounters an error (#8701)
* Show a dialog when Jitsi encounters an error

* Capitalize 'Meet'

* Revise copy to not mention Jitsi
2022-05-26 14:14:13 +00:00
Michael Telatynski
655bca63e6
Move Enterprise Erin tests from Puppeteer to Cypress (#8569)
* Move Enterprise Erin tests from Puppeteer to Cypress

* delint

* types

* Fix double space

* Better handle logout in Lifecycle

* Fix test by awaiting the network request

* Improve some logout handlings

* Try try try again

* Delint

* Fix tests

* Delint
2022-05-26 10:12:49 +00:00
Michael Telatynski
7efd7b67ea
Fix gha concurrency conditions (#8702) 2022-05-26 10:21:44 +01:00
Michael Telatynski
f3f14afbbf
Move spaces tests from Puppeteer to Cypress (#8645)
* Move spaces tests from Puppeteer to Cypress

* Add missing fixture

* Tweak synapsedocker to not double error on a docker failure

* Fix space hierarchy loading race condition

Fixes https://github.com/matrix-org/element-web-rageshakes/issues/10345

* Fix race condition when creating public space with url update code

* Try Electron once more due to perms issues around clipboard

* Try set browser permissions properly

* Try to enable clipboard another way

* Try electron again

* Try electron again again

* Switch to built-in cypress feature for file uploads

* Mock clipboard instead

* TMPDIR ftw?

* uid:gid pls

* Clipboard tests can now run on any browser due to mocking

* Test Enter as well as button for space creation

* Make the test actually work

* Update cypress/support/util.ts

Co-authored-by: Eric Eastwood <erice@element.io>

Co-authored-by: Eric Eastwood <erice@element.io>
2022-05-26 10:19:00 +01:00
Michael Telatynski
d75e2f19c5
Fix font not resetting when logging out (#8670)
* Fix font not resetting when logging out

* Adopt on_logged_in and on_logged_out into DispatcherAction

* Add tests

* Add copyright
2022-05-26 09:56:53 +01:00
Suguru Hirahara
f3b762c1a8
Move unread notification dots of the threads list to the expected position (#8700)
* Change dot size from 10px to 8px

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set inset 8px to the dot

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use shorthand properties for inset

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move blocks from '.mx_EventTile:not([data-layout=bubble])' to '.mx_EventTile[data-shape=ThreadsList]'

For a notification dot it does not matter whether the layout of the event tile is bubble or not. Instead what matters is that the dot is expected to be displayed on the threads list.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove an obsolete z-index declaration

The declaration was added with ed34952 to fix a clickability issue. Now the event tile is clickable everywhere, it is no longer required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 23:33:35 +01:00
Travis Ralston
0f26ddd285
Update local aliases checks to use stable API (#8698)
Fixes https://github.com/vector-im/element-web/issues/22337
2022-05-25 15:56:30 -06:00
Michael Telatynski
8b17007795
Remove stale release.sh parameter for no-jsdoc (#8640) 2022-05-25 21:02:04 +00:00
James Salter
1dd0f8cd5e
Convert references to direct chat -> direct message (#8694) 2022-05-25 14:20:46 +00:00
Suguru Hirahara
dbd9911fe7
Align EventTile_line with display name on message bubble (#8692) 2022-05-25 14:08:43 +00:00
Michael Telatynski
249d52c6f3
Add additional debug logging for thread timeline mixup (#8693) 2022-05-25 15:02:14 +01:00
Suguru Hirahara
948f81d25f
Make the empty thread panel fill BaseCard (#8690)
Use border-box to make maintaining the layout more intuitive.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 14:33:27 +02:00
Michael Telatynski
e69ba24f96
Fix edge case around composer handling gendered facepalm emoji (#8686)
* Write tests around composer badly handling gendered facepalm emoji

* Commit export for tests to be happy

* Fix edge case around composer handling gendered facepalm emoji

* Fix offset calculations and make code more readable
2022-05-25 12:41:36 +01:00
Suguru Hirahara
90dfb8d61f
Move style rules related to ThreadPanel from EventTile (#8683)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 09:36:12 +02:00
Suguru Hirahara
03c2bdbde1
Remove ButtonResetDefault from mx_AccessibleButton of EventTile_keyRequestInfo_text (#8678)
To respect the concept of cascading. Also using a mixin to unset the declarations can easily cause a style inconsistency.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 08:45:18 +02:00
Suguru Hirahara
8afb1abd36
Fix a grid blowout due to nowrap displayName on a bubble with UTD (#8688) 2022-05-25 06:50:36 +02:00
Suguru Hirahara
412c207b23
Apply the same max-width to image tile on the thread timeline as message bubble (#8669) 2022-05-25 06:31:39 +02:00
Matthew Hodgson
ef69946440
Improve combining diacritics in Chrome (#8687)
This makes all but 9 of U+20D0 to U+20F0 combine
correctly on Chrome. See also
https://bugs.chromium.org/p/chromium/issues/detail?id=1328898
2022-05-24 21:37:08 -06:00