Commit Graph

226 Commits

Author SHA1 Message Date
R Midhun Suresh
cf8b87fd14
Add tabs to the right panel (#12672)
* Create new method for header button behaviour

With the introduction of tabs, the behaviour of the header buttons is
changed as follows:
- Close any right panel if open
- Open the correct right panel if no panel was open before

The old method (and behaviour) is retained as showOrHidePhase.

* Implement tabs in the right panel

There are three tabs: Info, People and Threads

* Remove unwanted code from RoomSummaryCard

- Remove the menu item for opening the memberlist since that is now
  taken of by the tabs.
- Remove the close button

* Remove code for focusing close button from tac item

See https://github.com/matrix-org/matrix-react-sdk/pull/12410

There's no longer a close button to focus so we instead focus the thread
tab. This is done in RightPaneltabs.tsx so we just need to remove this
code.

* Introduce a room info icon to the header

This was previously present in the legacy room header but not in the new
header.

* BaseCard changes

- Adds id, ariaLabelledBy and role props to implement tab accessibility.
- Adds hideHeaderButtons prop to hide header buttons (think back and
  close buttons).
- Change confusing header rendering code:
  header is not rendered ONLY when no header is passed AND
  hideHeaderButtons is true.

* Refactor repeated code into function

Created a new function createSpaceScopeHeader which returns the
component if the room is a space room. Previously this code was
duplicated in every component that uses SpaceScopeHeader component.

* Pass BaseCard attributes and use helper function

Actually using the code from the last two commits

* Add, update and remove tests/screenshots/snapshots

* Fix distance between search bar and tabs

* Update compound

* Update screenshots/snapshots
2024-07-09 11:36:50 +00:00
ElementRobot
7487b27857
[create-pull-request] automated change (#12740)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-07-09 06:24:22 +00:00
Michael Telatynski
2a26afe438
Redesign room search interface (#12677)
* Extract SearchInfo interface and SearchScope enum

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix in-progress and update behaviour of RoomSearchView

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Remove search button from legacy header

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Move search from aux panel to room summary card

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Wire up Cmd/Ctrl F for moved search field

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Use cpd space tokens

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Remove stale props

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix ctrl/cmd f search shortcut

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update Compound

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Revert the back button for now

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* i18n

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Cancel search on escape

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix missing X

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Improve coverage

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Extract SearchScope and SearchInfo into Searching

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* delint

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* delint

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix test

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Switch to icon button for cancel search

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* yarn.lock

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* lint

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* i18n

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update locators

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Revert screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update snapshots

* Discard changes to package.json

* i18n

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Snapshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Handle narrow viewports

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Improve coverage

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Improve coverage

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Revert copy

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2024-07-08 09:57:41 +00:00
ElementRobot
5bda8d0d5c
[create-pull-request] automated change (#12734)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-07-06 06:22:31 +00:00
David Baker
81f29d13dc
Move language settings to 'preferences' (#12723)
* Move language settings to 'preferences'

Their new home is in this tab

* Update snapshot

* Move playwright test code

* Add test

* tests

* Update screenshot
2024-07-05 22:04:27 +00:00
David Baker
06117695bc
Fix close button on forgot password flow (#12732)
* Fix close button on forgot password flow

The 'x' had escaped out the right of the button for some reason

* Add test that actually opens the dialog in question

* Actually screenshot the right thing

* Unnecessary screenshot
2024-07-05 09:51:21 +00:00
Florian Duros
2f953f1d0f
New layout selector ui in user settings (#12676)
* feat: reworked the layout switcher

* feat: make the classname optional in EventTilePreview.tsx

* test: add tests to LayoutSwitcher

* feat: change appearance tab

* test: update appearance snapshot

* e2e: add tests

* css: add comment for gap overriding
2024-07-05 07:30:31 +00:00
ElementRobot
6f5d21fedb
[create-pull-request] automated change (#12731)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-07-05 06:22:38 +00:00
Richard van der Hoff
de12d69e6b
Flaky-test bot: reopen existing issues (#12727)
If a test becomes flaky again, reopen the old issue.
2024-07-04 10:24:15 +00:00
ElementRobot
e75dc4e038
[create-pull-request] automated change (#12724)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-07-04 06:24:09 +00:00
ElementRobot
2702f8ba8c
[create-pull-request] automated change (#12722)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-07-03 06:25:00 +00:00
Florian Duros
53ea045c54
Update @vector-im/compound-web (#12718)
* deps: update `@vector-im/compound-web`

* feat: use new EditInPlace

* e2e: update snapshots
2024-07-02 12:35:13 +00:00
Florian Duros
7d8623de89
Fix Match system theme toggle (#12719)
* deps: force react-id version

* e2e: use checkbox name
2024-07-02 08:39:22 +00:00
ElementRobot
6ebaf3b46b
[create-pull-request] automated change (#12717)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-07-02 06:25:26 +00:00
ElementRobot
9b00af6b56
[create-pull-request] automated change (#12712)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-06-28 06:24:33 +00:00
Richard van der Hoff
8feaae66fb
Playwright: use rust crypto for the bot user (#12708)
... because legacy crypto is legacy
2024-06-27 15:43:24 +00:00
ElementRobot
b449dc835b
[create-pull-request] automated change (#12707)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-06-27 06:24:50 +00:00
Florian Duros
33a017b528
New theme ui in user settings (#12576)
* Add hook to get the theme

* Adapt subsection settings to new ui

* WIP new theme subsection

* Add theme selection

* Fix test types

* Disabled theme selector when system theme is used

* Update compound to `4.4.1`

* Add custom theme support

* Remove old ThemChoicePanel

* Fix QuickThemeSwitcher-test.tsx

* Fix AppearanceUserSettingsTab-test.tsx

* Update i18n

* Fix ThemeChoicePanel-test.tsx

* Update `@vector-im/compound-web`

* Small tweaks

* Fix CSS comments and use compound variable

* Remove custom theme title

* i18n: update

* test: add tests to theme selection

* test: update AppearanceUserSettingsTab-test snapshot

* test: rework custom theme

* playwright: fix audio-player.spec.ts

* playwright: appearance tab

* test: update snapshot

* playright: add custom theme

* i18n: use correct char for ellipsis

* a11y: add missing aria-label to delete button

* dialog: update close button tooltip

* theme: remove local state and handle custom delete

* theme: don't add twice the same custom theme

* test: update snapshot

* playwright: update snapshot

* custom theme: add background to custom theme list

* update compound web

* Use new destructive property on `IconButton` of theme panel

* test: update snapshots

* rename new ui into legacy

* remove wrong constructor doc

* fix theme selector padding

* theme selector: fix key

* test: fix e2e
2024-06-26 15:47:01 +00:00
David Baker
ea0baee101
Split out email & phone number settings to separate components & move discovery to privacy tab (#12670)
* WIP update of threepid settings section

* Remove email / phone number section from original place

and don't show the new one if 3pids are disabled

* Update snapshots

* Pull identity server / 3pid binding settings out to separate component

and put it in the security & privacy section which is its new home

* Update snapshot

* Move relevant part of test & update screenshots / snapshots

* Remove unnecessary dependency

* Add test for discovery settings

* Add spacing in terms agreement
2024-06-26 13:04:19 +00:00
ElementRobot
95c8aa3d18
[create-pull-request] automated change (#12702)
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
2024-06-26 06:24:43 +00:00
renovate[bot]
ffbb903eb6
Update all non-major dependencies (#12681)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-06-25 17:14:16 +00:00
Florian Duros
15de0010a1
Remove legacy crypto parameter (#12679) 2024-06-25 09:06:55 +00:00
ElementRobot
cea0b7c37e
[create-pull-request] automated change (#12678)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-25 06:20:36 +00:00
Richard van der Hoff
efd309f5f9
Disable playwright tests for legacy crypto (#12662)
* Disable "legacy crypto" playwright project

* playwight: Remove crypto stack conditions

We only ever run under the rust stack now, so these conditions are
redundant.

* playwright: remove `cryptoBackend` test option

* playwright: remove redundant `projects`

We don't need this any more

* playwright: remove redundant `TestOptions`
2024-06-24 10:30:59 +00:00
Richard van der Hoff
9c862907f9
Switch to Rust crypto stack for all logins (#12630)
* Use Rust crypto stack universally

Ignore the `feature_rust_crypto` and `RustCrypto.staged_rollout_percent`
settings, and just use RustCrypto everywhere.

* Remove labs setting for rust crypto

* Remove support for legacy crypto stack in `StorageManager`

We're not going to use the legacy stack any more.

* Update docs on `Features.RustCrypto`

* Remove now-unreachable `tryToUnlockSecretStorageWithDehydrationKey`

* Comment out test which doesn't work

* fix typo
2024-06-24 09:14:42 +00:00
ElementRobot
ce7b538770
[create-pull-request] automated change (#12671)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-22 06:25:53 +00:00
Richard van der Hoff
736b083a79
Deflake verification playwright tests (#12669)
Turns out the sleep that got removed in
https://github.com/matrix-org/matrix-react-sdk/pull/12667 was useful.
2024-06-21 16:58:38 +00:00
Richard van der Hoff
87bdc784b8
Playwright: check the welcome page is loaded and works (#12660) 2024-06-21 11:21:24 +00:00
Richard van der Hoff
132669fd28
Remove redundant sleep from playwright test (#12667)
Nobody seems to know why this is here. Let's get rid of it and see what
happens.
2024-06-21 09:18:09 +00:00
Richard van der Hoff
5bcf76c9ab
Playwright test: ensure that links are preserved over login (#12657) 2024-06-20 17:18:11 +00:00
Michael Telatynski
e9abc55869
Work around rust crypto bug which causes flakiness (#12656)
* Work around rust crypto bug which causes flakiness

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Add comment

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update playwright/e2e/crypto/crypto.spec.ts

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2024-06-20 15:38:03 +00:00
ElementRobot
d5e06c95cb
[create-pull-request] automated change (#12655)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-20 09:42:39 +00:00
Florian Duros
6c99b91210
Minor tweaks to UserSettings dialog (#12651)
* Make user settings dialog title looks like figma design

* dialog: add title to close button

* Update dialog snapshot

* Update playwright snapshot
2024-06-20 09:29:38 +00:00
Richard van der Hoff
7e7b55efe3
Playwright tests to replace old loading-test.tsx (#12654)
A selection of Playwright tests intended to replace the old Jest tests in
Element-Web's `loading-test.tsx`.
2024-06-20 09:20:52 +00:00
David Baker
e49f8e033d
Update to compound-web 4.8.0 (#12650) 2024-06-20 09:09:20 +00:00
ElementRobot
2b4b415eb3
[create-pull-request] automated change (#12641)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-19 06:28:14 +00:00
ElementRobot
042aa17a60
[create-pull-request] automated change (#12631)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-18 08:45:08 +00:00
ElementRobot
28bcbd4056
Playwright Docker image updates (#12626)
* [create-pull-request] automated change

* Complete UIA password prompt

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2024-06-17 09:30:33 +00:00
David Baker
72a8f8f03b
Show tooltips on narrow tabbed views (#12624)
* Show tooltips on narrow tabbed views

* Also only show on left-side tabs

* Unused import

* Comments

* Add test

* More test

* Assert tooltip appears in playwright test
2024-06-14 14:17:46 +00:00
David Baker
650b9cb0cf
Add in-progress view to display name EditInPlace (#12609)
* Add in-progress view to display name EditInPlace

Requires https://github.com/element-hq/compound-web/pull/180

* Update to new compound-web

for editinplace component with spinner

* Update snapshots

for https://github.com/element-hq/compound-web/pull/178

* Update screenshots

* Remove margin

which isn't necessary now there's no 'Remove' link on the bottom

* Update screenshots
2024-06-14 14:16:13 +00:00
ElementRobot
bd196aee29
[create-pull-request] automated change (#12620)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-14 09:00:37 +00:00
Travis Ralston
6a44f5e087
Use stable endpoints for MSC3916 (#12602) 2024-06-13 18:18:25 +00:00
Michael Telatynski
8c49f3f2ea
Update gfm.css to github-markdown-css (#12613)
* Update gfm.css to github-markdown-css

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2024-06-13 16:27:37 +00:00
Michael Telatynski
347229be60
Avoid flakiness from hover styling in screenshot tests (#12615)
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2024-06-13 16:04:38 +00:00
Michael Telatynski
2547777de7
Tweak copy for user verification toast (#12605)
* Tweak copy for user verification toast

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2024-06-13 16:04:33 +00:00
ElementRobot
7ae50dbce5
[create-pull-request] automated change (#12611)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-13 07:55:04 +00:00
David Baker
25e4515c3c
Fix image upload preview size (#12607)
* Fix image upload preview size

and add a playwright test for it

* Add the actual playwright test
2024-06-12 22:35:02 +00:00
ElementRobot
6198ce511f
[create-pull-request] automated change (#12603)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-12 06:29:49 +00:00
David Baker
3e7511cc5d
Keep dialog glass border on narrow screens (#12591)
* Keep dialog glass border on narrow screens

It got pushed off the edge and eventually disappeared on narrow
screens, so force it to always be present.

* Update screenshot
2024-06-11 08:31:17 +00:00
ElementRobot
4e3de2b27e
[create-pull-request] automated change (#12595)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
2024-06-11 06:28:48 +00:00