J. Ryan Stinnett
c2e87dde85
Add code quality review policy
...
This adds a new review policy which encourages tests for new features. As with
everything, we'll continue to tune this based on feedback.
2021-04-16 18:53:18 +01:00
J. Ryan Stinnett
001b15b856
Rewrap review guide
2021-04-16 16:02:46 +01:00
J. Ryan Stinnett
ec781b3ebe
Document pull request previews
...
This documents the pull request previews we recently added when working on
https://github.com/vector-im/element-web/issues/12624 .
2020-12-09 13:59:45 +00:00
J. Ryan Stinnett
f1e89bf833
Replace various instances of Riot with Element
2020-11-25 17:01:19 +00:00
Qt Resynth
21329f17c9
Update Riot -> Element in docs/review.md
2020-09-30 11:05:19 +00:00
J. Ryan Stinnett
bc1cad01c4
Add testing to review guidelines
...
This adds a initial statement on testing to the review guidelines. No
requirements are made at this time, but reviewers are encouraged to request
tests where they believe it is reasonable to provide them.
Fixes https://github.com/vector-im/element-web/issues/14945
2020-08-26 15:57:31 +01:00
Resynth
6b317798dc
Update docs/review.md
...
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
2020-07-17 13:04:55 +01:00
Resynth
17649dc2b1
Update review.md
2020-07-17 13:04:03 +01:00
Jorik Schellekens
6ed81eadbf
Some grammar and clarifications.
2020-03-30 11:52:23 +01:00
J. Ryan Stinnett
5b94d8bbd7
Add line about UI for network activity
2020-03-26 11:28:51 +00:00
J. Ryan Stinnett
5808ea2ba1
Add notes about chatting with the team
2020-03-18 11:18:29 +00:00
J. Ryan Stinnett
e348546e59
Reformat
2020-03-18 10:59:46 +00:00
J. Ryan Stinnett
34f3671c09
Add notes on review request handling
2020-03-18 10:59:33 +00:00
J. Ryan Stinnett
3989f41985
Clarify merge options
2020-03-18 10:53:48 +00:00
J. Ryan Stinnett
bd8b3a9046
Move multi-repo linking to workflow section
2020-03-18 10:21:28 +00:00
J. Ryan Stinnett
1aecc3d7e5
Add multi-repo PR linking
...
Co-Authored-By: Travis Ralston <travpc@gmail.com>
2020-03-18 10:18:41 +00:00
J. Ryan Stinnett
0b772ca50a
Tweak issue assigning
...
Co-Authored-By: Travis Ralston <travpc@gmail.com>
2020-03-13 16:48:03 +00:00
J. Ryan Stinnett
d930d14735
Add review policy doc
...
This documents various attributes of our overall review policy from code,
design, and product perspectives.
Fixes https://github.com/vector-im/riot-web/issues/12614
2020-03-13 16:39:29 +00:00
