Commit Graph

45359 Commits

Author SHA1 Message Date
Suguru Hirahara
b06b602c5b
Remove an obsolete style block related to highlighting from _IRCLayout.pcss (#10451)
* Remove an obsolete style block related to highlighting from _IRCLayout.pcss

Initially it has been added with this commit 67249e1e9c for the implementation of IRC layout, but the border declarations for highlighting were removed with this commit 3a2aa9d96c to replace the 'border-left' declaration with the 'box-shadow' declaration.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-04 11:07:53 +02:00
Suguru Hirahara
4064ae7ad0
Use Cypress Testing Library - timeline.spec.ts (#10471)
* Use Cypress Testing Library - timeline.spec.ts

- findButton
- findMenuitem

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove force: false from click()

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add const messageEdit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-04 09:54:06 +01:00
Eric Eastwood
2ebec3a3c7
Remove orphaned GenericError class (#10500)
Originally introduced in
https://github.com/matrix-org/matrix-react-sdk/pull/8329

All usages were removed in
https://github.com/matrix-org/matrix-react-sdk/pull/9605

This error also has problems with showing tranlsated versions in the logs.
Part of https://github.com/vector-im/element-web/issues/9597

We should be using the new `UserFriendlyError` for this kind of thing anyway.
Introduced in https://github.com/matrix-org/matrix-react-sdk/pull/10440
2023-04-04 02:46:27 -05:00
Suguru Hirahara
d3cd44d44e
Fix a FilePanel test to have Percy take a snapshot of file tiles on the panel (#10429)
* Fix a FilePanel test to have Percy take a snapshot of file tiles on the panel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Check other layouts too

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove resetting the viewport size as it is not necessary

The viewport size should be reset after each test.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-03 11:02:06 +01:00
Michael Weimann
56423d4d53
Restore createRoom.canEncryptToAllUsers (#10491) 2023-04-03 11:28:17 +02:00
alunturner
6ac366ee5a
Style mentions as pills in rich text editor (#10448) 2023-04-03 10:16:29 +01:00
Shivam Mahajan
f933806b63
Added auto focus to Github URL on opening of debug logs modal (#10479)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-04-03 09:09:32 +00:00
Michael Kaye
5cd459ff2d
Check kiwi_enable value for '1'-ness, not presence (#10482)
Change from string-y checking for true ('0' is true) to comparison against the string '1', which is only true if exactly equal to '1'.

This has been submitting more test results to Kiwi than we want/need.
2023-04-03 09:54:49 +01:00
Kerry
81a4498a8f
Apply strictNullChecks to src/utils/*!exportUtils (#10455
* Apply `strictNullChecks` to `src/utils/exportUtils`

* strict fix

* fix strictNullChecks issues in some utils

* fix error message

* test coverage

* lint

* more strictNullChecks

* small optimisation for getUniqueRoomsWithIndividuals

* tidy

* test coverage
2023-04-03 09:26:55 +01:00
Suguru Hirahara
4ed6e39067
Use Cypress Testing Library - editing.spec.ts (#10480)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-03 16:06:58 +12:00
Kerry
6f1a3af895
Properly generate mentions when editing a reply with MSC3952 (#10486)
* remove redundant feature_intentional_mentions settings check

* tests

* pass replytoevent to attachmmentions in editmessagecomposer

* lint

* strict fix
2023-04-02 21:32:12 +00:00
maheichyk
d3da171765
Show room create icon if "UIComponent.roomCreation" is enabled (#10364)
* Show room create button in RoomSublist if "UIComponent.roomCreation" is enabled

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>

* Revert "Show room create button in RoomSublist if "UIComponent.roomCreation" is enabled"

This reverts commit a332a0b02a6c3253ea7ac606211c41a09c409de5.

* Use UIComponent.ExploreRooms to display menu item "Explore public rooms" ("Explore rooms" in case of space room) in context menu of "Rooms" section of RoomList component. The context menu will be available if one of UIComponent.ExploreRooms or UIComponent.CreateRooms is enabled.

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>

* "Explore rooms" of space room should not be controlled by UIComponent.ExploreRooms.

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>

---------

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
Co-authored-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
2023-04-03 09:19:56 +12:00
Michael Telatynski
24eed963d3
Use frozen lockfile instead of pure lockfile on yarn install (#10493) 2023-03-31 15:06:08 +00:00
alunturner
6f791d28c8
Add mentions as links to rte (#10463)
* adds autocomplete behaviour for mentions in rich text editor
* allows adding mentions as links
* adds tests
2023-03-31 14:14:55 +01:00
Michael Telatynski
212977c4ac
Apply strictNullChecks to src/contexts/* (#10490) 2023-03-31 10:35:02 +01:00
RiotRobot
17b456c7ee Reset matrix-js-sdk back to develop branch 2023-03-31 10:16:52 +01:00
RiotRobot
10a7f588c7 Merge remote-tracking branch 'origin/develop' into develop 2023-03-31 10:15:19 +01:00
RiotRobot
0904f6a1bb Merge branch 'master' into develop 2023-03-31 10:11:09 +01:00
Michael Telatynski
404c412bcb
Handle IDB closed event by showing modal with prompt to reload app (#10395
* Handle IDB `closed` event by showing modal with prompt to reload app

* Iterate

* Skip the modal for guests, e.g. during registration

* Iterate

* Add tests
2023-03-31 10:08:45 +01:00
RiotRobot
af3e57f9e1 v3.69.1 2023-03-31 09:57:42 +01:00
RiotRobot
5a132e42e1 Prepare changelog for v3.69.1 2023-03-31 09:57:40 +01:00
Michael Telatynski
f152613f83
Apply strictNullChecks to src/components/auth/* (#10484
* Apply `strictNullChecks` to `src/components/auth/*`

* fix

* strict types
2023-03-31 09:26:15 +01:00
Michael Weimann
af151700c9
Strictify src/components/structures/Space* (#10481) 2023-03-31 10:20:15 +02:00
ElementRobot
3693255cd5
Fix detection of encryption for all users in a room (#10487) (#10489)
(cherry picked from commit dddef858f1)

Co-authored-by: Michael Weimann <michaelw@matrix.org>
2023-03-31 08:07:47 +00:00
Michael Weimann
dddef858f1
Fix detection of encryption for all users in a room (#10487) 2023-03-31 09:43:47 +02:00
Eric Eastwood
ff1468b6d3
Replace newTranslatableError with UserFriendlyError (#10440
* Introduce UserFriendlyError

* Replace newTranslatableError with UserFriendlyError

* Remove ITranslatableError

* Fix up some strict lints

* Document when we/why we can remove

* Update matrix-web-i18n

Includes changes to find `new UserFriendlyError`,
see https://github.com/matrix-org/matrix-web-i18n/pull/6

* Include room ID in error

* Translate fallback error

* Translate better

* Update i18n strings

* Better re-use

* Minor comment fixes
2023-03-31 08:30:43 +01:00
Michael Telatynski
567248d5c5
Add aria labels to message search bar to improve accessibility (#10476) 2023-03-30 10:26:19 +01:00
David Baker
15523cde36
Update test interface to add call object (#10477)
Compatibility with https://github.com/matrix-org/matrix-js-sdk/pull/3237
2023-03-30 10:22:27 +01:00
Suguru Hirahara
232daaff68
Fix decryption failure bar covering the timeline (#10360)
* Use grid layout instead

- BEM naming style
- Increase block gap from 4px to 8px
- Use flexbox inside 'header' grid-area to let the buttons wrapped
- Use variables
- Remove 4px gap when one of the buttons is not rendered
- Change 'body' to 'message'
- Set 'align-self: start' to the icon and spinner

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Unset height of spinner

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Break lines at newline characters with white-space: pre-line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Edit tests to check decryption failure bars on narrow timeline

- checkTimelineNarrow() looks for buttons by default
- Test indicator as well

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Edit the test to have it check mx_EventTile_last only inside mx_RoomView_body

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix double underscores

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix double underscores - pcss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Iterate - buttons at the bottom

- Set common spacing to buttons with variables
- Remove line breaks, yarn run i18n
- Set data-testid for headlines and buttons in case the tested strings would be displayed elsewhere simultaneously

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Check waiting headline as well

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Increase spacing between the message and the buttons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* lint

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Increase block gap between wrapped buttons for clickability

Apply 8px between wrapped buttons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert bottom margin of buttons which are not expected to be wrapped

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Check visibility instead of existence

This commit removes data-testid from headlines and data-testid-button and checks whether the elements are really visible, not overflowing the viewport.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant gap between 'mx_DecryptionFailureBar_start' and the bottom edge

This commit adds '.mx_DecryptionFailureBar--withEnd' class name to have it applied to the bar only if it has button(s). This way the bar is rendered with a flexbox and the row-gap declaration is respected only if there is a 'mx_DecryptionFailureBar--withEnd' element. The element  currently includes the button(s) only.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* lint - prettier

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Have Percy take a snapshot of the bar loading spinner before checkTimelineNarrow()

The loading spinner is likely to disappear while checking the bar on the narrow timeline.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Kerry <kerrya@element.io>
2023-03-30 10:11:16 +01:00
Andy Balaam
bebfbacded
Update changelog for v3.69.0 now the security issue is public (#10468) 2023-03-30 09:10:04 +00:00
Michael Weimann
052c7e6d27
Strictify components/structures/Thread* (#10478)
* Strictify `components/structures/Thread*`

* Fix ThreadView event Id
2023-03-30 09:44:28 +01:00
Suguru Hirahara
beb8861df6
Add E2E test of MessageEditHistoryDialog (#10406) 2023-03-30 10:32:02 +02:00
Michael Weimann
9aef1874db
Strictify stores/room-list (#10474) 2023-03-30 09:06:50 +01:00
Michael Telatynski
9848cdf4e7
Apply strictNullChecks to src/components/structures/Space* (#10475) 2023-03-30 08:28:08 +01:00
Kerry
9a733a6444
Apply strictNullChecks to src/utils/exportUtils (#10379)
* Apply `strictNullChecks` to `src/utils/exportUtils`

* strict fix

* test coverage

* lint

* test coverage

* one more test
2023-03-29 21:47:07 +00:00
Michael Telatynski
1447829543
Improve profile picture settings accessibility (#10470) 2023-03-29 14:00:45 +00:00
Michael Weimann
968b6fc5df
Implement permalink end-2-end test (#10434) 2023-03-29 13:52:57 +02:00
Michael Telatynski
a47b3eb0ee
Apply strictNullChecks to src/components/views/elements/* (#10462
* Apply `strictNullChecks` to `src/components/views/elements/*`

* Iterate

* Iterate

* Iterate

* Apply `strictNullChecks` to `src/components/views/elements/*`

* Iterate

* Iterate

* Iterate

* Update snapshot
2023-03-29 08:23:54 +01:00
Michael Telatynski
cefd94859c
Conform src/components/views/messages/* code to strictNullChecks (#10461) 2023-03-29 08:22:35 +01:00
Michael Weimann
7cb90d0f78
Add Cypress Testing Library (#10446) 2023-03-29 08:47:05 +02:00
Kerry
6eda1fa6e2
replace Polls history strings with Poll history (#10454)
Co-authored-by: Michael Weimann <michaelw@matrix.org>
2023-03-28 22:13:51 +00:00
RiotRobot
f5115e047e Reset matrix-js-sdk back to develop branch 2023-03-28 14:33:05 +01:00
RiotRobot
0475e7107f Merge branch 'master' into develop 2023-03-28 14:30:52 +01:00
RiotRobot
500a543662 v3.69.0 2023-03-28 14:23:32 +01:00
RiotRobot
ef46e9a94e Prepare changelog for v3.69.0 2023-03-28 14:23:29 +01:00
RiotRobot
0d8a1eb850 Upgrade matrix-js-sdk to 24.0.0 2023-03-28 14:21:30 +01:00
Robin
edef4cc52e
Handle group call redaction (#10465)
Redacted group call events should be interpreted as terminated calls.
2023-03-28 13:16:30 +00:00
Michael Weimann
c30b2637c5 Changes for v3.69.0 2023-03-28 11:23:16 +01:00
Suguru Hirahara
f1667870a0
Change the category of a test from message displaying to configure room (#10449) 2023-03-28 08:57:17 +01:00
Kerry
ae50eee135
Apply strictNullChecks to src/utils/pillify.tsx (#10456)
* apply strictNullChecks to src/utils/pillify.tsx

* include change to utility

* apply strictNullChecks to src/utils/permalinks
2023-03-28 10:07:49 +13:00